[Trigger] My first attempt to create a custom spell, but is it any good?

[hoplitespear]

Hi there everyone i recently started mapping in wc III again and I'm currently doing a project. For this project i attempted for the first time to create a custom spell using triggers. I gathered info and so on. But i read allot about leaks to; So know i would ask some of you, who are prolly more skilled in this then I am to take a look.

The skill basicly is a target dummy that taunts nearby units making them attack it and then explodes dealing damage and stunning (the tauren war chief - war stomp).

The trigger is in two parts:
MAIN:

ACTIONS:

I know i could just let a dummy unit cast taunt, but believe me taunt is a freaking weard skill. If u don't let an unmodified mountian giant cast it it doesn't seem to work. Anyway i hope some of u can find a bit of time to take a look and i look forward to your comment on what you think of it.

Thx in advance -hoplitespear-

 

[Magissia]

It's leak, you must add all "Group unit" thing into a group unit variable and clean it after

 

[hoplitespear]

So what u are saying is i have to put my new unit groups into a variable and then clear that or? Could u be a bit more specific

like this then?:

 

[Restor]

well, it is not MUI after all.

 

[hoplitespear]

Well i guess i still have to tweak a bit more then. Any tips on how to improve it? (btw for now it works perfect.) But i haven't checked casting it with two different heroes on the same time yet.

EDIT: well i just tested that, and it fails badly. I guess the wait cuases my problem Then, but how do i get the same effect withouth it?

 

[Thyrael]

By the use of local variables instead of globals. These easy steps can be done without knowing anything about jass. use the searchfunktion or have a look into the JASStuts. There you'll find your answers, I promise

Thy

 

[hoplitespear]

Will do thx for the helpfull reply m8.

EDIT: Ok thanks to my C# knowledge and the use of some handy tutorials i see the prob. when using local variables, it doesn't matter how mucht the trigger fire's i won't overwrite any variables. So i won't have any problems with casting the spell a second time in the first spell's wiating time.

Thx for the tip thyrael