Monarch Domain v1.2

[Rheiko]

Some issues I found:

• Special effect is not created properly. This is because you don't null MonDomain_SpcEffectBuff variable after destroying it. Just destroying the special effect is not enough because the reference still exists so you have to manually set it to null.
• Effect is not removed properly. When a target has been casted upon by two different casters and either of the caster run out of mana, if the caster ever get enough mana to cast the spell again on the same target and their mana runs out, the effect doesn't disappear, allowing for a permanent buff.
• When another caster uses the spell on already affected units, the effect for those units cannot stack but the caster still lose mana. You need to somehow check whether the picked units are already affected by the same spell but different caster or not. If they are, do not activate the mana drain (or the spell at all). This is most likely related to the previous issue I encountered.

 

[Daffa]

Some issues I found:

• Special effect is not created properly. This is because you don't null MonDomain_SpcEffectBuff variable after destroying it. Just destroying the special effect is not enough because the reference still exists so you have to manually set it to null.
• Effect is not removed properly. When a target has been casted upon by two different casters and either of the caster run out of mana, if the caster ever get enough mana to cast the spell again on the same target and their mana runs out, the effect doesn't disappear, allowing for a permanent buff.
• When another caster uses the spell on already affected units, the effect for those units cannot stack but the caster still lose mana. You need to somehow check whether the picked units are already affected by the same spell but different caster or not. If they are, do not activate the mana drain (or the spell at all). This is most likely related to the previous issue I encountered.

Hi Rheiko, thanks for the feedback!
1. What do you mean the buff special effect not created properly? Do you mean they doesn't appear on second onward casts, or they appear but not removed, or there's leak left behind? The 'destroying is not enough without nulling' point can have large implications for systems like TSELL so I want to be sure what this point core issue is.
2. I have found the issue after re-reading the entire loop code and apparently the way I designed the spell has a room for higher levelled spell to override weaker levelled instance (meant to mimic buffs in Warcraft), which might have spawn this issue. I plan to attach each unit to their caster, and when the instance is altered, the group are also moved around.
3. Same as point 2

 

[Daffa]

Version 1.2:

• Fix Monarch Domain buff from Red colored to Green colored (negative to positive)
• Added a link between source and target
• If spell is overridden, source is overwritten and moves the unit from old group to new group (prevent multiple mana drains)
• Fixes a bug with Special Effect not being nulled correctly (effect not appearing bug fix)
• Rearrange Cast trigger to fix a bug with Group Creation now working correctly for second cast onward (mana not drained on second cast onward)
• Minor object editor ID changes to accomodate some of the changes

This should address all issues mentioned by @Rheiko and other minor stuffs I found while fixing them
Let me know if there are other issues

 

[Rheiko]

It looks like all the issues I previously mentioned have been fixed. I tried to be thorough but so far I have not found any more issues or bugs. Hopefully, I did not miss a thing. Also, I believe in your MonarchDomainCast, you can use your Special Effect variable instead of calling Last created special effect everytime for a slight increase in speed and efficiency. But no biggie, everything else looks good and man, this is a pretty cool spell!

Approved

 

[Daffa]

It has to be cool, otherwise the anime character can't aura farm

Thanks for the approval, I'll consider this a birthday gift