[General] Memory leaks.

[InSaNe_97]

Greetings. I made trigger and want it without memory leak if possible. I want to use same variables in multiple triggers. Also I want to make this works multiple times at once when needed.


Events
Unit - A unit Finishes casting an ability

Conditions
(Ability being cast) Equal to Transition

Actions
Set Vracanje_mesto = (Position of (Casting unit))
Unit - Create 1 Freza Madjija for (Owner of (Casting unit)) at Vracanje_mesto facing (Facing of (Casting unit)) degrees
Custom script: call RemoveLocation (udg_Vracanje_mesto)
Set Freza_Madjija = (Last created unit)
Unit - Order Freza_Madjija to Human Sorceress - Invisibility (Casting unit)
Wait 0,40 game-time seconds
Unit - Remove Freza_Madjija from the game


I know that I should use timer instead of wait but I will do it one day, not now.

In advice thank You <3.

 

[The_Silent]

Then you need to use locals,

• Events
  • Unit - A unit Finishes casting an ability
• Conditions
  • (Ability being cast) Equal to Transition
• Actions
  • Custom Script: local unit spawn
  • Set Vracanje_mesto = (Position of (Casting unit))
  • Unit - Create 1 Freza Madjija for (Owner of (Casting unit)) at Vracanje_mesto facing (Facing of (Casting unit)) degrees
  • Custom script: Set spawn =bj_lastCreatedUnit
  • Custom script: call RemoveLocation (udg_Vracanje_mesto)
  • Set Freza_Madjija = (Last created unit)
  • Unit - Order Freza_Madjija to Human Sorceress - Invisibility (Casting unit)
  • Wait 0,40 game-time seconds
  • Custom Script: call RemoveUnit(spawn)
  • Custom Script: set spawn = null
  • Custom Script: set udg_Vracanje_mesto = null
  • Custom script: set udg_Freezer_madjija = null

Something like that, i do not have the editor right here.
Not quite sure if RemoveLocation is the same as setting it to null.

 

[InSaNe_97]

In online lessons stays that RemoveLocation can be used that way. Hmm, About custom scripts you have, I can write it exactly?

Edit: I mean these question marks, I don't know how to set them.

 

[The_Silent]

I think so, the logic should work, but the functions is from memory.

 

[InSaNe_97]

Aham, okay, now I check that I do not need wait function. So that change something? Will be okay if I from My trigger just remove that wait time without making it as you said? I mean I do not want to make something messy then after don't know how to find and fix a mistake.

 

[The_Silent]

Then you just need to add

• Custom script: set udg_Freezer_madjija = null

To the end of your original script (I think)

 

[InSaNe_97]

Okay, thank you.

Edit: "Freezer" XD. <3 ahahaha.

 

[Pyrogasm]

You only need the spawn=null line at the end, not the other 2 as well. Only spawn is a local that needs to be billed.

 

[InSaNe_97]

I don't know, I am not used to make triggers as he show, thing I do not know in certain situation is how to make this Green question mark custom scripts.

 

[Pyrogasm]

I'm not asking you... I'm telling you. You do custom scripts by choosing the "custom script" action and typing in the box. It's really simple.

 

[InSaNe_97]

Yeah, I know how to use custom scripts, but didn't show green question mark icon as he show.

 

[Pyrogasm]

That's because The_Silent typed Custom Script instead of Custom script, and the vB code used to show triggers on this site is case-sensitive. It looks reads the text before the - to see what symbol it should show there.

• Custom script: do something
• Custom Script: do something
• -------- another example --------
• Unit Group - Pick...
• Unit group - Pick...

 

[The_Silent]

It is just normal 'custom script' functions

It is just the trigger markdown being weird i think.

Edit: Pyrogasm is correct

 

[InSaNe_97]

Thank you both, I will try soon. Maybe even tomorrow but will try, I really need it.

 

[Wrda]

With an expiration timer this would be much more simple. You don't need to null udg_Freezer_madjija nor udg_Vracanje_mesto since they're globals, and it doesn't make any sense nulling them after the wait.

 

[InSaNe_97]

Okay thank you.

 

[Dr Super Good]

Wait game time inherently leaks a handle ID. Only way to avoid it currently is to use a fixed implementation of the function called by a custom script line, or to import a modified blizzard.j with the implementation fixed.

 

[InSaNe_97]

Oh Dear, that's above my WarCraft III language.

Edit: I don't understand anyone, everyone give me their ways I don't know what is right.

 

[Wrda]

Use the other wait instead of the game-time wait...
I mean, seriously, who on earth even uses game-time waits?

 

[InSaNe_97]

Okay.

Edit: I forgot that I actually remove wait, it works without it as well.

 

[Dr Super Good]

I mean, seriously, who on earth even uses game-time waits?

Because it is vaguely synchronized with game time (so also with game speed) unlike the other sort of wait, TriggerSleepAction, which is vaguely synchronized to real time and so will progress even when the game is paused.

 

[InSaNe_97]

That means it will be paused on game pause or not?

 

[Wrda]

That means it will be paused on game pause or not?

It won't pause, but in your case it is pretty much irrelevant whether it pauses or not.

 

[InSaNe_97]

Okay.