Mass variable for reason?

[chasin225]

Ok so i always see everyone having a new variable that sets the caster

• Set Power_Slam_Caster = (Triggering unit)

What if i would cast another ability then Power Slam and use the same variable then whats the problem? will it bug? Couse i would prefer to use 1 variable that sets the (triggering unit) in all spell without waits.

 

[chobibo]

If there are no waits, then there wouldn't be any problem.

 

[chasin225]

ok good to know

 

[Dr Super Good]

You really should be using a local for this sort of variable setting. Changing the values of globals is slower than those of locals due to the level of memory access (locals in stack, globals in main memeory).

Ofcourse blizzard did not bother letting GUI access locals.

 

[defskull]

I've always wanted to ask this similar kinda question...
Example:
We got 2 running trigger at the same time using same variable
Will it collide ?

Trigger 1:

• Engulfing Flame
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Engulfing Flame
  • Actions
    • Set Caster = (Triggering unit)
    • Set Target = (Target unit of ability being cast)
    • Trigger - Turn on Looping Damage <gen>

• Looping Damage
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Unit - Cause Caster to damage Target, dealing 20.00 damage of attack type Spells and damage type Normal

Trigger 2:

• Thunderstorm
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Thunderstorm
  • Actions
    • Set Caster = (Triggering unit)
    • Set Target = (Target unit of ability being cast)
    • Set TargetLoc = (Position of Target)
    • Trigger - Turn on Ground Shake <gen>

• Ground Shake
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Environment - Create a 1.00 second Normal ripple deformation at TargetLoc with starting radius 1024.00, ending radius 1024.00, and depth 64.00, using 1.00 second ripples spaced 512.00 apart

I'm not talking about MUI or leaking in triggers, I just wanna know whether a same set variable would collide with each other if used on the same time EVEN that trigger is, MUI ?

 

[Dr Super Good]

We got 2 running trigger at the same time using same variable

No you do not. It is impossible for 2 triggers to run at the same time...

You should easilly be aware of this by the fact that WC3 is only single threaded (next to interupt handlers and external components which are too small to consider). As such only 1 thing in the game can run at any time. It will always run 1 trigger before the other.

Because the variable is global, it can be subject to incorrect use as your example showed. 2 different systems reference the same variable but rely on it being un altered and thus it will bug as their usage collide. This is why local or private variables were created to prevent such collisions from occuring.

It is perfectly alright to use the same global in many different tasks as long as the tasks instantly free (same scope as a local variable). This is still incorrect use of a global as a local variable should be used instead.

 

[chobibo]

You're asking a different question, chasin255 asked about triggers without waits, yours had timers, which executes after some time. If you're triggers didn't have timers then using global variables like that would work properly.

 

[defskull]

I understood about "single action trigger..."
What I want to ask is, related trigger, like Turn On Trigger action that executes after-effect of the trigger

 

[baassee]

What I want to ask is, related trigger, like Turn On Trigger action that executes after-effect of the trigger

This is a mess, some more detailed description required.

 

[defskull]

Do you mean that my question is not clear enough ?

 

[baassee]

Yes. Please explain a bit further.

 

[defskull]

I believe that DSG has explained to me regarding my question