[Solved] Make shockwave destroy trees

[Lordul Dracula]

Hi i want to help somebody with a skill. A shockwave that will destroy trees but i can't make this skill to work fine. Can somebody tell me want i need to change here? Thx +rep

• Untitled Trigger 002
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Shockwave...
  • Actions
    • Set ShockwaveCasterPoint = (Position of (Triggering unit))
    • Set Distance = 100.00
    • For each (Integer A) from 1 to 5, do (Actions)
      • Loop - Actions
        • Set ShockwaveCasterPoint2 = (ShockwaveCasterPoint offset by Distance towards (Facing of (Triggering unit)) degrees)
        • Destructible - Pick every destructible within 125.00 of ShockwaveCasterPoint2 and do (Actions)
          • Loop - Actions
            • Destructible - Kill (Picked destructible)
            • Custom script: call RemoveLocation (udg_ShockwaveCasterPoint2)
        • Set Distance = (Distance + 100.00)
    • Custom script: call RemoveLocation (udg_ShockwaveCasterPoint)

 

[Pyrogasm]

Move this out of (to go after) the destructible-picking loop: Custom script: call RemoveLocation (udg_ShockwaveCasterPoint2). Instead of using the facing angle you should use the angle between the caster's position and the targeted cast point.

Improvements, but these shouldn't 'make' the trigger 'work'.

 

[Lordul Dracula]

Move this out of (to go after) the destructible-picking loop: Custom script: call RemoveLocation (udg_ShockwaveCasterPoint2). Instead of using the facing angle you should use the angle between the caster's position and the targeted cast point.

Improvements, but these shouldn't 'make' the trigger 'work'.

so i need to make a new trigger to make this to work fine?

 

[Pyrogasm]

No... you change what I said you should change. And then read the second half of my reply which says it shouldn't fix anything.

Nobody can help you here until you put in some debug messages and figure out what isn't running. That trigger looks like it should kill destructibles in 5 125-range areas situated 100-500 units from the caster in the direct ion it's facing.

 

[Lordul Dracula]

No... you change what I said you should change. And then read the second half of my reply which says it shouldn't fix anything.

Nobody can help you here until you put in some debug messages and figure out what isn't running. That trigger looks like it should kill destructibles in 5 125-range areas situated 100-500 units from the caster in the direct ion it's facing.

Ok thx now is working fine

• Untitled Trigger 002
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Shockwave...
  • Actions
    • Set ShockwaveCasterPoint = (Position of (Triggering unit))
    • Set Distance = 200.00
    • For each (Integer A) from 1 to 5, do (Actions)
      • Loop - Actions
        • Set ShockwaveCasterPoint2 = (ShockwaveCasterPoint offset by Distance towards (Angle from ShockwaveCasterPoint to (Target point of ability being cast)) degrees)
        • Destructible - Pick every destructible within 150.00 of ShockwaveCasterPoint2 and do (Actions)
          • Loop - Actions
            • Destructible - Kill (Picked destructible)
        • Custom script: call RemoveLocation (udg_ShockwaveCasterPoint2)
        • Set Distance = (Distance + 100.00)
    • Custom script: call RemoveLocation (udg_ShockwaveCasterPoint)

 

[Uncle]

Some more improvements can be made:

• Untitled Trigger 002
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Shockwave...
  • Actions
    • Set ShockwaveCasterPoint = (Position of (Triggering unit))
    • Set ShockwaveCasterPoint2 = (Target point of ability being cast)
    • Set Distance = 200.00
    • Set Angle = (Angle from ShockwaveCasterPoint to ShockwaveCasterPoint2)
    • Custom script: call RemoveLocation (udg_ShockwaveCasterPoint2)
    • For each (Integer A) from 1 to 5, do (Actions)
      • Loop - Actions
        • Set ShockwaveCasterPoint2 = (ShockwaveCasterPoint offset by Distance towards Angle degrees)
        • Destructible - Pick every destructible within 150.00 of ShockwaveCasterPoint2 and do (Actions)
          • Loop - Actions
            • Destructible - Kill (Picked destructible)
        • Custom script: call RemoveLocation (udg_ShockwaveCasterPoint2)
        • Set Distance = (Distance + 100.00)
    • Custom script: call RemoveLocation (udg_ShockwaveCasterPoint)

This fixes a memory leak -> (Target point of ability being cast) and calculates the Angle only once instead of doing it 5 times.

Also, if you want a Shockwave that Destroys trees as it collides with them you can use a system like this:

Shockwave/Carrion Swarm System v1.1

Found this laying dormant in my WIP Triggers. I decided to share this because I haven't found any Shockwave Systems yet, but if there is already, I guess it is far better than this one, so please give a link to it and just reject this one. An easy-to-use Ability-related system which allows the...

www.hiveworkshop.com

I also attached a custom shockwave spell I made in GUI a year ago, it's not perfect but gets the job done.

 

[Lordul Dracula]

Some more improvements can be made:

• Untitled Trigger 002
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Shockwave...
  • Actions
    • Set ShockwaveCasterPoint = (Position of (Triggering unit))
    • Set ShockwaveCasterPoint2 = (Target point of ability being cast)
    • Set Distance = 200.00
    • Set Angle = (Angle from ShockwaveCasterPoint to ShockwaveCasterPoint2)
    • Custom script: call RemoveLocation (udg_ShockwaveCasterPoint2)
    • For each (Integer A) from 1 to 5, do (Actions)
      • Loop - Actions
        • Set ShockwaveCasterPoint2 = (ShockwaveCasterPoint offset by Distance towards Angle degrees)
        • Destructible - Pick every destructible within 150.00 of ShockwaveCasterPoint2 and do (Actions)
          • Loop - Actions
            • Destructible - Kill (Picked destructible)
        • Custom script: call RemoveLocation (udg_ShockwaveCasterPoint2)
        • Set Distance = (Distance + 100.00)
    • Custom script: call RemoveLocation (udg_ShockwaveCasterPoint)

This fixes a memory leak -> (Target point of ability being cast) and calculates the Angle only once instead of doing it 5 times.

Also, if you want a Shockwave that Destroys trees as it collides with them you can use a system like this:

Shockwave/Carrion Swarm System v1.1

Found this laying dormant in my WIP Triggers. I decided to share this because I haven't found any Shockwave Systems yet, but if there is already, I guess it is far better than this one, so please give a link to it and just reject this one. An easy-to-use Ability-related system which allows the...

www.hiveworkshop.com

I also attached a custom shockwave spell I made in GUI a year ago, it's not perfect but gets the job done.

Thx @Uncle for your answer but it seems that this trigger will not destroy trees. I will give my friend your map. Like you said my friend didn't like my trigger because the trees will die instantly...

Shockwave/Carrion Swarm System v1.1

Found this laying dormant in my WIP Triggers. I decided to share this because I haven't found any Shockwave Systems yet, but if there is already, I guess it is far better than this one, so please give a link to it and just reject this one. An easy-to-use Ability-related system which allows the...

www.hiveworkshop.com

I found this skill too

Advanced Shockwave [Paladon] + Documentation

Shockwave The hero releases a powerful shockwave to damage and knock all unit in its way back. Level 1 - 75 damage & 100 knockback distance. Level 2 - 130 damage & 200 knockback distance. Level 3 - 200 damage & 300 knockback distance. This Spell was a request by Igor_Z. I added an...

www.hiveworkshop.com

 

[Uncle]

You'll have to add in the tree destruction yourself. All of these custom shockwave systems (and really any trigger that interacts with nearby units) use the same method for damaging units.

Every X seconds -> Set a Point -> Pick every unit within range of that Point -> Deal damage to (Picked unit)

So all you have to do is add in your Tree destruction actions there as well:

• Destructible - Pick every destructible within 150.00 of ThePoint and do (Actions)
  • Loop - Actions
    • Destructible - Kill (Picked destructible)

Then you can add an If Then Else to Filter the (Picked destructible) so that you only destroy trees, unless you want any kind of Destructible to be destroyed.

 

[Lordul Dracula]

You'll have to add in the tree destruction yourself. All of these custom shockwave systems (and really any trigger that interacts with nearby units) use the same method for damaging units.

Every X seconds -> Set a Point -> Pick every unit within range of that Point -> Deal damage to (Picked unit)

So all you have to do is add in your Tree destruction actions there as well:

• Destructible - Pick every destructible within 150.00 of ThePoint and do (Actions)
  • Loop - Actions
    • Destructible - Kill (Picked destructible)

Then you can add an If Then Else to Filter the (Picked destructible) so that you only destroy trees, unless you want any kind of Destructible to be destroyed.

I already gave him this ability

Advanced Shockwave [Paladon] + Documentation

Shockwave The hero releases a powerful shockwave to damage and knock all unit in its way back. Level 1 - 75 damage & 100 knockback distance. Level 2 - 130 damage & 200 knockback distance. Level 3 - 200 damage & 300 knockback distance. This Spell was a request by Igor_Z. I added an...

www.hiveworkshop.com

If he will not be able to make this one to work, i will give him this trigger that you send me . Thx again @Uncle for your help