[LUA] Leaks?

[iown_azz]

I don't know if you LUA leaks but if anyone can skim through my code to see if I have any leaks...

function CheckPlayers()
    ForGroup(GetUnitsOfTypeIdAll(FourCC("Edem")), HeroRemove)
end

function HeroRemove()
    local x = GetEnumUnit()
    local playerSlot = GetPlayerSlotState(GetOwningPlayer(x))
    if playerSlot == PLAYER_SLOT_STATE_EMPTY then
        RemoveUnit(x)
    end
end

function deathbounds()
    local regionarray = {}
    for i = 1, 175, 1 do
            regnum = i - 1
            if i >= 11 and i < 101 then
                    regionarray[i] = "gg_rct_Region_0" .. regnum
            elseif i >= 101 then
                    regionarray[i] = "gg_rct_Region_" .. regnum
            else
                    regionarray[i] = "gg_rct_Region_00".. regnum
            end
        print(regionarray[i])     
    end

    print("work")
    local deathRegion = CreateRegion()
    for i = 1, 175, 1 do
        RegionAddRect(deathRegion, _G[string.format(regionarray[i])]);
    end
    local deathTrigger = CreateTrigger()
    TriggerRegisterEnterRegion(deathTrigger, deathRegion, nil)
    TriggerAddAction(deathTrigger, killHero)
end

function killHero()
    print("die bitch")
    KillUnit(GetEnteringUnit()) 
end

 

[Pyrogasm]

CheckPlayers leaks a group.

 

[iown_azz]

CheckPlayers leaks a group.

So I would add 'bj_wantDestroyGroup = TRUE' before the ForGroup ? or turn getunitsoftype into a variable and then use 'DestroyGroup(checkedplayers)'

 

[Pyrogasm]

ForGroup doesn’t use that wantDestroy variable; only ForGroupBJ. Use a variable.

 

[iown_azz]

ForGroup doesn’t use that wantDestroy variable; only ForGroupBJ. Use a variable.

so call DestroyGroup(variable)?

 

[Rigborn]

so call DestroyGroup(variable)?

yes

 

[iown_azz]

yes

Thanks

 

[Dr Super Good]

One should be able to use my garbage collector to automatically clear such leaks. Assuming no JASS hashtable are used to manage locations, groups and forces.

 

[iown_azz]

One should be able to use my garbage collector to automatically clear such leaks. Assuming no JASS hashtable are used to manage locations, groups and forces.

I couldn't find your garbage collector....

 

[Dr Super Good]

I couldn't find your garbage collector....

[Lua]Obliterate all GUI leaks with 1 trigger!

It proxies the creation functions to keep track of the created objects. Thanks to Lua's in built garbage collector it will automatically remove objects like locations and groups when no more references to them exist (they leaked) hence fixing the leak.

The only issue was that in 1.31 the JASS hashtable functionality did not count as an Lua reference and so locations and groups only referenced by hashtable might be recycled pre-maturely. Of course this is only an issue for GUI which uses the JASS hashtable functionality. If one writes Lua directly one should use the native table type instead which will track references as expected.