Lightning Flare v1.0b

Moderator · Aug 22, 2014

16:27, 20th Sep 2014
TriggerHappy:

I don't understand why you're using a different dummy unit for each level.

For the dummy caster it would probably be best to create one at initialization and reuse it as Dalvengyr said. Doing this at map initialization will also allow people to specify their own dummy caster if they already have one. Paused units apparently use up less resources so you'll want to do that, then un-pause the dummy caster when you need to.

LF_ is also a kind of generic prefix and might collide with some maps. For example LF_Index.

mogulkhan1Axe · Aug 22, 2014

Please if somebody notices something wrong with the code please let me know what exactly it is so i can fix it. Thank You!

deathismyfriend · Aug 22, 2014

Never use casting unit. Use triggering unit instead.
Anything you have in the same then and else blocks should be placed before or after depending on the code.
Example:

Set LF_NumberOfStrikes[tempInt] = (LF_NumberOfStrikes[tempInt] + 1)
Set LF_Interval[tempInt] = 0.00

Same with your de-indexing. You have that in the then and else blocks.

Instead of such a huge unitgroup creation use an ITE and filter out these units when running the code.

Set tempGroup = (Units within LF_GroupAoE of tempPoint matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of (Owner of LF_Flare[tempInt])) Equal to True) and ((((Matching unit) is A structure) Equal to False) and ((((Matching unit

Also using random unit from unit group action leaks a unit group so that needs to be cleaned up.
I believe number of units in unit group also leaks a unit group.
You should instead create a custom integer to count the units in the unit group as it is more efficient.

mogulkhan1Axe · Aug 22, 2014

deathismyfriend said:
Never use casting unit. Use triggering unit instead.
Anything you have in the same then and else blocks should be placed before or after depending on the code.
Example:

Set LF_NumberOfStrikes[tempInt] = (LF_NumberOfStrikes[tempInt] + 1)

Set LF_Interval[tempInt] = 0.00

Same with your de-indexing. You have that in the then and else blocks.

Instead of such a huge unitgroup creation use an ITE and filter out these units when running the code.

Set tempGroup = (Units within LF_GroupAoE of tempPoint matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of (Owner of LF_Flare[tempInt])) Equal to True) and ((((Matching unit) is A structure) Equal to False) and ((((Matching unit

Also using random unit from unit group action leaks a unit group so that needs to be cleaned up.
I believe number of units in unit group also leaks a unit group.
You should instead create a custom integer to count the units in the unit group as it is more efficient.

Im new to mui rly new could u like write that trigger for me with what u said when u have free time. Anywho thanks for the reply

deathismyfriend · Aug 22, 2014

Your MUI is fine. Your coding isn't that was what I was talking about.

mogulkhan1Axe · Aug 22, 2014

deathismyfriend said:
Your MUI is fine. Your coding isn't that was what I was talking about.

Well my main question is, is the code alright and what line of code leaks if there is any

deathismyfriend · Aug 22, 2014

This line.

(Number of units in tempGroup) Greater than 0
and this.
- Unit Group - Pick every unit in (Random 1 units from tempGroup) and do (Actions)

mogulkhan1Axe · Aug 22, 2014

deathismyfriend said:
This line.

(Number of units in tempGroup) Greater than 0

and this.

Unit Group - Pick every unit in (Random 1 units from tempGroup) and do (Actions)

can it be fixed

(Number of units in tempGroup) Greater than SOMEINTEGER
and this.
Unit Group - Pick every unit in (Random SOMEINTEGER2 units from tempGroup) and do (Actions)

???

deathismyfriend · Aug 22, 2014

yes don't use the first one and use an integer to do the counting.

For the next one either set it to a tempGroup or use the set bj_wantdestroygroup to true.

mogulkhan1Axe · Aug 22, 2014

deathismyfriend said:
yes don't use the first one and use an integer to do the counting.

For the next one either set it to a tempGroup or use the set bj_wantdestroygroup to true.

but i got this after the casting point

Custom script: call DestroyGroup(udg_tempGroup)

deathismyfriend · Aug 22, 2014

mogulkhan1Axe said:
but i got this after the casting point

Custom script: call DestroyGroup(udg_tempGroup)

That is for a different unit group.

mogulkhan1Axe · Aug 22, 2014

deathismyfriend said:
That is for a different unit group.

What you mean there is only one group that in each tempInt destroyes and sets again

deathismyfriend · Aug 22, 2014

These 2 actions create 2 more unit groups.

(Number of units in tempGroup) Greater than 0
and this.
- Unit Group - Pick every unit in (Random 1 units from tempGroup) and do (Actions)

mogulkhan1Axe · Aug 22, 2014

deathismyfriend said:
These 2 actions create 2 more unit groups.

(Number of units in tempGroup) Greater than 0

and this.

Unit Group - Pick every unit in (Random 1 units from tempGroup) and do (Actions)

So how should i do it correctly should i like create another variable and to set that group to (random SOMEINTERGER units from tempGroup) and when i need to pick it to be

Unit Group - Pick every unit in (Newly CREATED GROUP) and do (Actions)

deathismyfriend · Aug 22, 2014

Yes then after that you destroy the group.

mogulkhan1Axe · Aug 22, 2014

deathismyfriend said:
Yes then after that you destroy the group.

Can it be done like this watch where i destroy groups also did i do that the right way?

test
- Events
- Conditions
- Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Number of units in tempGroup) Greater than LF_GroupInteger
    - Then - Actions
      - Set tempGroup2 = (Random LF_NumberOfRandomUnits units from tempGroup)
      - Custom script: call DestroyGroup(udg_tempGroup)
      - Unit Group - Pick every unit in tempGroup2 and do (Actions)
        
        Loop - Actions
        
        Set tempUnit = (Picked unit)
        
        Unit - Create 1 LF_CastingDummy for (Owner of LF_Flare[tempInt]) at tempPoint facing Default building facing degrees
        
        Set tempUnit2 = (Last created unit)
        
        Unit - Add a 1.00 second Generic expiration timer to tempUnit2
        
        Unit - Add LF_DummyAbility to tempUnit2
        
        Unit - Set level of LF_DummyAbility for tempUnit2 to LF_Level[tempInt]
        
        Unit - Order tempUnit2 to Orc Far Seer - Chain Lightning tempUnit
        
        Set tempUnit = No unit
        
        Set tempUnit2 = No unit
        
        Custom script: call DestroyGroup(udg_tempGroup2)
      - Set LF_NumberOfStrikes[tempInt] = (LF_NumberOfStrikes[tempInt] + 1)
      - Set LF_Interval[tempInt] = 0.00
    - Else - Actions
      - Custom script: call DestroyGroup(udg_tempGroup)
      - Set LF_NumberOfStrikes[tempInt] = (LF_NumberOfStrikes[tempInt] + 1)
      - Set LF_Interval[tempInt] = 0.00

deathismyfriend · Aug 22, 2014

No it can't. In the above you first create the group and add units to it. Then you destroy the group. Then you use the group. So there are no units in the group and there is no group so it will bug the trigger since you are trying to get units out of nothing.

mogulkhan1Axe · Aug 22, 2014

deathismyfriend said:
No it can't. In the above you first create the group and add units to it. Then you destroy the group. Then you use the group. So there are no units in the group and there is no group so it will bug the trigger since you are trying to get units out of nothing.

but the spell works i tested it u know i set units above i didnt copy it and if there is more than 0 units in it it will first set ''tempGroup2'' and after that will destroy ''tempGroup'' so now the main is tempgroup2 and it picks unit from that

mogulkhan1Axe · Aug 22, 2014

here is the whole loop trigger

LF Loop
- Events
- Conditions
- Actions
  - For each (Integer tempInt) from 1 to LF_Index, do (Actions)
    - Loop - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (LF_Flare[tempInt] is alive) Equal to True
        
        Then - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        LF_NumberOfStrikes[tempInt] Equal to LF_MaxNumberofStrikes
        
        Then - Actions
        
        Unit - Kill LF_Flare[tempInt]
        
        Set LF_Caster[tempInt] = LF_Caster[LF_Index]
        
        Set LF_Flare[tempInt] = LF_Flare[LF_Index]
        
        Set LF_Interval[tempInt] = LF_Interval[LF_Index]
        
        Set LF_Level[tempInt] = LF_Level[LF_Index]
        
        Set LF_NumberOfStrikes[tempInt] = LF_NumberOfStrikes[LF_Index]
        
        Set LF_Caster[LF_Index] = No unit
        
        Set LF_Flare[LF_Index] = No unit
        
        Set LF_Index = (LF_Index - 1)
        
        Set tempInt = (tempInt - 1)
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        LF_Index Equal to 0
        
        Then - Actions
        
        Trigger - Turn off (This trigger)
        
        Else - Actions
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        LF_Interval[tempInt] Equal to LF_StrikeTime
        
        Then - Actions
        
        Set tempPoint = (Position of LF_Flare[tempInt])
        
        Set tempGroup = (Units within LF_GroupAoE of tempPoint matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of (Owner of LF_Flare[tempInt])) Equal to True) and ((((Matching unit) is A structure) Equal to False) and ((((Matching unit
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Number of units in tempGroup) Greater than LF_GroupInteger
        
        Then - Actions
        
        Set tempGroup2 = (Random LF_NumberOfRandomUnits units from tempGroup)
        
        Custom script: call DestroyGroup(udg_tempGroup)
        
        Unit Group - Pick every unit in tempGroup2 and do (Actions)
        
        Loop - Actions
        
        Set tempUnit = (Picked unit)
        
        Unit - Create 1 LF_CastingDummy for (Owner of LF_Flare[tempInt]) at tempPoint facing Default building facing degrees
        
        Set tempUnit2 = (Last created unit)
        
        Unit - Add a 1.00 second Generic expiration timer to tempUnit2
        
        Unit - Add LF_DummyAbility to tempUnit2
        
        Unit - Set level of LF_DummyAbility for tempUnit2 to LF_Level[tempInt]
        
        Unit - Order tempUnit2 to Orc Far Seer - Chain Lightning tempUnit
        
        Set tempUnit = No unit
        
        Set tempUnit2 = No unit
        
        Custom script: call DestroyGroup(udg_tempGroup2)
        
        Set LF_NumberOfStrikes[tempInt] = (LF_NumberOfStrikes[tempInt] + 1)
        
        Set LF_Interval[tempInt] = 0.00
        
        Else - Actions
        
        Custom script: call DestroyGroup(udg_tempGroup)
        
        Set LF_NumberOfStrikes[tempInt] = (LF_NumberOfStrikes[tempInt] + 1)
        
        Set LF_Interval[tempInt] = 0.00
        
        Custom script: call RemoveLocation (udg_tempPoint)
        
        Else - Actions
        
        Set LF_Interval[tempInt] = (LF_Interval[tempInt] + 0.05)
        
        Else - Actions
        
        Unit - Kill LF_Flare[tempInt]
        
        Set LF_Caster[tempInt] = LF_Caster[LF_Index]
        
        Set LF_Flare[tempInt] = LF_Flare[LF_Index]
        
        Set LF_Interval[tempInt] = LF_Interval[LF_Index]
        
        Set LF_Level[tempInt] = LF_Level[LF_Index]
        
        Set LF_NumberOfStrikes[tempInt] = LF_NumberOfStrikes[LF_Index]
        
        Set LF_Caster[LF_Index] = No unit
        
        Set LF_Flare[LF_Index] = No unit
        
        Set LF_Index = (LF_Index - 1)
        
        Set tempInt = (tempInt - 1)
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        LF_Index Equal to 0
        
        Then - Actions
        
        Trigger - Turn off (This trigger)
        
        Else - Actions

deathismyfriend · Aug 22, 2014

ooo sorry I misread tempGroup and tempGroup2

mogulkhan1Axe · Aug 22, 2014

deathismyfriend said:
ooo sorry I misread tempGroup and tempGroup2

no problemo my friend i will reupload all now and u take a look at new loop trigger

Vinz · Aug 22, 2014

Seems to be a nice spell and idea. 4/5

mogulkhan1Axe · Aug 22, 2014

CakeMaster said:
Seems to be a nice spell and idea. 4/5

Thanks!

deathismyfriend · Aug 22, 2014

This still leaks a unit group.

(Number of units in tempGroup) Greater than LF_GroupInteger

Move these out of the ITE. You have them both in the Then and in the Else blocks.

Custom script: call DestroyGroup(udg_tempGroup)
Custom script: call RemoveLocation (udg_tempPoint)
Set LF_NumberOfStrikes[tempInt] = (LF_NumberOfStrikes[tempInt] + 1)
Set LF_Interval[tempInt] = 0.00

Other than that it looks good.

mogulkhan1Axe · Aug 22, 2014

deathismyfriend said:
This still leaks a unit group.

(Number of units in tempGroup) Greater than LF_GroupInteger

Move these out of the ITE. You have them both in the Then and in the Else blocks.

Custom script: call DestroyGroup(udg_tempGroup)

Custom script: call RemoveLocation (udg_tempPoint)

Set LF_NumberOfStrikes[tempInt] = (LF_NumberOfStrikes[tempInt] + 1)

Set LF_Interval[tempInt] = 0.00

Other than that it looks good.

first how it leaks a unit group

second. that jas to be there bcz if there is more than 0 units it will shoot lightning and still do the count if not if there is 0 units it will just do the count remove point and group

deathismyfriend · Aug 22, 2014

The first does not leak it in your case. Sorry about that.

The second needs to be moved from the then and else block to after the ITE they are in.

mogulkhan1Axe · Aug 22, 2014

deathismyfriend said:
The first does not leak it in your case. Sorry about that.

The second needs to be moved from the then and else block to after the ITE they are in.

Can u show me like exactly what u mean can u print screen my loop trigger and mark it what needs to be moved and where post it on imgur

deathismyfriend · Aug 23, 2014

If (All Conditions are True) then do (Then Actions) else do (Else Actions)
- If - Conditions
  - LF_Interval[tempInt] Equal to LF_StrikeTime
- Then - Actions
  - Set tempPoint = (Position of LF_Flare[tempInt])
  - Set tempGroup = (Units within LF_GroupAoE of tempPoint matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of (Owner of LF_Flare[tempInt])) Equal to True) and ((((Matching unit) is A structure) Equal to False) and ((((Matching unit
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Number of units in tempGroup) Greater than LF_GroupInteger
    - Then - Actions
      - Set tempGroup2 = (Random LF_NumberOfRandomUnits units from tempGroup)
      - Custom script: call DestroyGroup(udg_tempGroup)
      - Unit Group - Pick every unit in tempGroup2 and do (Actions)
        
        Loop - Actions
        
        Set tempUnit = (Picked unit)
        
        Unit - Create 1 LF_CastingDummy for (Owner of LF_Flare[tempInt]) at tempPoint facing Default building facing degrees
        
        Set tempUnit2 = (Last created unit)
        
        Unit - Add a 1.00 second Generic expiration timer to tempUnit2
        
        Unit - Add LF_DummyAbility to tempUnit2
        
        Unit - Set level of LF_DummyAbility for tempUnit2 to LF_Level[tempInt]
        
        Unit - Order tempUnit2 to Orc Far Seer - Chain Lightning tempUnit
        
        Set tempUnit = No unit
        
        Set tempUnit2 = No unit
        
        Custom script: call DestroyGroup(udg_tempGroup2)
      - Set LF_NumberOfStrikes[tempInt] = (LF_NumberOfStrikes[tempInt] + 1)
      - Set LF_Interval[tempInt] = 0.00
    - Else - Actions
      - Custom script: call DestroyGroup(udg_tempGroup)
      - Set LF_NumberOfStrikes[tempInt] = (LF_NumberOfStrikes[tempInt] + 1)
      - Set LF_Interval[tempInt] = 0.00
  - Custom script: call RemoveLocation (udg_tempPoint)
- Else - Actions
  - Set LF_Interval[tempInt] = (LF_Interval[tempInt] + 0.05)

If (All Conditions are True) then do (Then Actions) else do (Else Actions)
- If - Conditions
  - LF_Interval[tempInt] Equal to LF_StrikeTime
- Then - Actions
  - Set tempPoint = (Position of LF_Flare[tempInt])
  - Set tempGroup = (Units within LF_GroupAoE of tempPoint matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of (Owner of LF_Flare[tempInt])) Equal to True) and ((((Matching unit) is A structure) Equal to False) and ((((Matching unit
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Number of units in tempGroup) Greater than LF_GroupInteger
    - Then - Actions
      - Set tempGroup2 = (Random LF_NumberOfRandomUnits units from tempGroup)
      - Unit Group - Pick every unit in tempGroup2 and do (Actions)
        
        Loop - Actions
        
        Set tempUnit = (Picked unit)
        
        Unit - Create 1 LF_CastingDummy for (Owner of LF_Flare[tempInt]) at tempPoint facing Default building facing degrees
        
        Set tempUnit2 = (Last created unit)
        
        Unit - Add a 1.00 second Generic expiration timer to tempUnit2
        
        Unit - Add LF_DummyAbility to tempUnit2
        
        Unit - Set level of LF_DummyAbility for tempUnit2 to LF_Level[tempInt]
        
        Unit - Order tempUnit2 to Orc Far Seer - Chain Lightning tempUnit
        
        Set tempUnit = No unit
        
        Set tempUnit2 = No unit
        
        Custom script: call DestroyGroup(udg_tempGroup2)
    - Else - Actions
  - Custom script: call DestroyGroup(udg_tempGroup)
  - Custom script: call RemoveLocation (udg_tempPoint)
  - Set LF_NumberOfStrikes[tempInt] = (LF_NumberOfStrikes[tempInt] + 1)
  - Set LF_Interval[tempInt] = 0.00
- Else - Actions
  - Set LF_Interval[tempInt] = (LF_Interval[tempInt] + 0.05)

The above may also be able to be done with your de-indexing portion of code.

mogulkhan1Axe · Aug 23, 2014

deathismyfriend said:
If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

LF_Interval[tempInt] Equal to LF_StrikeTime

Then - Actions

Set tempPoint = (Position of LF_Flare[tempInt])

Set tempGroup = (Units within LF_GroupAoE of tempPoint matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of (Owner of LF_Flare[tempInt])) Equal to True) and ((((Matching unit) is A structure) Equal to False) and ((((Matching unit

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

(Number of units in tempGroup) Greater than LF_GroupInteger

Then - Actions

Set tempGroup2 = (Random LF_NumberOfRandomUnits units from tempGroup)

Custom script: call DestroyGroup(udg_tempGroup)

Unit Group - Pick every unit in tempGroup2 and do (Actions)

Loop - Actions

Set tempUnit = (Picked unit)

Unit - Create 1 LF_CastingDummy for (Owner of LF_Flare[tempInt]) at tempPoint facing Default building facing degrees

Set tempUnit2 = (Last created unit)

Unit - Add a 1.00 second Generic expiration timer to tempUnit2

Unit - Add LF_DummyAbility to tempUnit2

Unit - Set level of LF_DummyAbility for tempUnit2 to LF_Level[tempInt]

Unit - Order tempUnit2 to Orc Far Seer - Chain Lightning tempUnit

Set tempUnit = No unit

Set tempUnit2 = No unit

Custom script: call DestroyGroup(udg_tempGroup2)

Set LF_NumberOfStrikes[tempInt] = (LF_NumberOfStrikes[tempInt] + 1)

Set LF_Interval[tempInt] = 0.00

Else - Actions

Custom script: call DestroyGroup(udg_tempGroup)

Set LF_NumberOfStrikes[tempInt] = (LF_NumberOfStrikes[tempInt] + 1)

Set LF_Interval[tempInt] = 0.00

Custom script: call RemoveLocation (udg_tempPoint)

Else - Actions

Set LF_Interval[tempInt] = (LF_Interval[tempInt] + 0.05)

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

LF_Interval[tempInt] Equal to LF_StrikeTime

Then - Actions

Set tempPoint = (Position of LF_Flare[tempInt])

Set tempGroup = (Units within LF_GroupAoE of tempPoint matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of (Owner of LF_Flare[tempInt])) Equal to True) and ((((Matching unit) is A structure) Equal to False) and ((((Matching unit

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

(Number of units in tempGroup) Greater than LF_GroupInteger

Then - Actions

Set tempGroup2 = (Random LF_NumberOfRandomUnits units from tempGroup)

Unit Group - Pick every unit in tempGroup2 and do (Actions)

Loop - Actions

Set tempUnit = (Picked unit)

Unit - Create 1 LF_CastingDummy for (Owner of LF_Flare[tempInt]) at tempPoint facing Default building facing degrees

Set tempUnit2 = (Last created unit)

Unit - Add a 1.00 second Generic expiration timer to tempUnit2

Unit - Add LF_DummyAbility to tempUnit2

Unit - Set level of LF_DummyAbility for tempUnit2 to LF_Level[tempInt]

Unit - Order tempUnit2 to Orc Far Seer - Chain Lightning tempUnit

Set tempUnit = No unit

Set tempUnit2 = No unit

Custom script: call DestroyGroup(udg_tempGroup2)

Else - Actions

Custom script: call DestroyGroup(udg_tempGroup)

Custom script: call RemoveLocation (udg_tempPoint)

Set LF_NumberOfStrikes[tempInt] = (LF_NumberOfStrikes[tempInt] + 1)

Set LF_Interval[tempInt] = 0.00

Else - Actions

Set LF_Interval[tempInt] = (LF_Interval[tempInt] + 0.05)

The above may also be able to be done with your de-indexing portion of code.

Ah i see what u've done i didnt rly get what u were saying yes i could do that i putted that 2 in if there is more units than 0 and as u did when the Interval is equal to strike time i will do that and reupload as soon as i get home

Wrda · Aug 23, 2014

Quite interesting and good spell.

Kazeon · Aug 23, 2014

store (Owner of LF_Caster) into a player variable, then change all (Owner of LF_Flare[tempInt]) to that variable.

mogulkhan1Axe · Aug 23, 2014

Dalvengyr said:
store (Owner of LF_Caster) into a player variable, then change all (Owner of LF_Flare[tempInt]) to that variable.

Should it be an arrayed or not?

Wrda said:
Quite interesting and good spell.

Thanks!

Kazeon · Aug 23, 2014

object data looks good, you can only use one flare unit though, or not?

I will check the trigger later.

mogulkhan1Axe · Aug 23, 2014

Dalvengyr said:
object data looks good, you can only use one flare unit though, or not?

I will check the trigger later.

Its MUi if u are talking about that and how one flare unit? i dont get what u mean

Vinz · Aug 24, 2014

mogulkhan1Axe said:
Should it be an arrayed or not?

Arrayed, just like other indexed variables.

mogulkhan1Axe · Aug 24, 2014

CakeMaster said:
Arrayed, just like other indexed variables.

Yea already done thanks for the reply tho!

Kazeon · Aug 31, 2014

.
- Unit - Create 1 LF_CastingDummy for LF_OwnerOfCaster[tempInt] at tempPoint facing Default building facing degrees
- Set tempUnit2 = (Last created unit)
- Unit - Add a 1.00 second Generic expiration timer to tempUnit2
- Unit - Add LF_DummyAbility to tempUnit2
- Unit - Set level of LF_DummyAbility for tempUnit2 to LF_Level[tempInt]
- Unit - Order tempUnit2 to Orc Far Seer - Chain Lightning tempUnit
Only use one casting unit for the whole game: means only create it once at map init (hide it somewhere, must be invisible to all players) and never remove/kill it.
Set tempGroup = (Units within LF_GroupAoE of tempPoint matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of LF_OwnerOfCaster[tempInt]) Equal to True) and ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) i...
You can use If Then Else checking:
- Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
  - Loop - Actions
    - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      - If - Conditions
      - = Move those conditions here =
      - Then - Actions
      - Else - Actions
But remember, you will use (Picked unit) if so.

Vinz · Aug 31, 2014

It is pretty much the same in that way, however it will save a few nanoseconds if Picked Unit is cached. Do not forget set bj_wantDestroyGroup = true.

Kazeon · Aug 31, 2014

Pendantic improvements are important, or all MUI spells can be approved instantly. And we won't need Jass if we don't care about that few nanoseconds

everything should be fairly efficient to be approved here

mogulkhan1Axe · Aug 31, 2014

CakeMaster said:
It is pretty much the same in that way, however it will save a few nanoseconds if Picked Unit is cached. Do not forget set bj_wantDestroyGroup = true.

i destroy group at the end of the loop (both of them)

Dalvengyr said:
.

Unit - Create 1 LF_CastingDummy for LF_OwnerOfCaster[tempInt] at tempPoint facing Default building facing degrees

Set tempUnit2 = (Last created unit)

Unit - Add a 1.00 second Generic expiration timer to tempUnit2

Unit - Add LF_DummyAbility to tempUnit2

Unit - Set level of LF_DummyAbility for tempUnit2 to LF_Level[tempInt]

Unit - Order tempUnit2 to Orc Far Seer - Chain Lightning tempUnit

Only use one casting unit for the whole game: means only create it once at map init (hide it somewhere, must be invisible to all players) and never remove/kill it.

Set tempGroup = (Units within LF_GroupAoE of tempPoint matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of LF_OwnerOfCaster[tempInt]) Equal to True) and ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) i...

You can use If Then Else checking:

Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)

Loop - Actions

Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

= Move those conditions here =

Then - Actions

Else - Actions

But remember, you will use (Picked unit) if so.

in casting dummy ive set the casting point to 0 and backswing. now im asking if i create 1 dummy only and like at the same time the spell is cast will dummy be able to cast both at the same time?

and i have to create every time cuz its the location that matters for the lightning

Kazeon · Aug 31, 2014

and i have to create every time cuz its the location that matters for the lightning

kinda forgot about that. I might be wrong, but

now im asking if i create 1 dummy only and like at the same time the spell is cast will dummy be able to cast both at the same time?

I think it's possible. If not, you can code your own chain lightning

EDIT:
this is a bitter reality, but if you dont fix it. this spell will never gets approved

(by today's standart)

mogulkhan1Axe · Aug 31, 2014

Dalvengyr said:
kinda forgot about that. I might be wrong, but

I think it's possible. If not, you can code your own chain lightning

well if i code my own chain lightning it will need more code its simpler for me like this

Vinz · Aug 31, 2014

Dummies are able to cast spells simultaneously, especially with 0 movement speed (removes need for turning which otherwise cannot be turned off).

mogulkhan1Axe · Aug 31, 2014

CakeMaster said:
Dummies are able to cast spells simultaneously, especially with 0 movement speed (removes need for turning which otherwise cannot be turned off).

but is my way good?

Vinz · Aug 31, 2014

Nope. Units may or may not leak, but the burst of unit creation is a factor in lowering FPS.

Do as said and create one dummy per group pick.

mogulkhan1Axe · Aug 31, 2014

CakeMaster said:
Nope. Units may or may not leak, but the burst of unit creation is a factor in lowering FPS.

Do as said and create one dummy per group pick.

So when a unit casts spel i create the dummy and do not destroy it till spell is over or the flare is dead?

Vinz · Aug 31, 2014

Adding a ~0.3 expiration timer after creation would be okay.

mogulkhan1Axe · Aug 31, 2014

i dont get it anymore what u said... do i keep one dummy for 1 caster and destroy it when spell is over
or do i
create multiple dummies per lightning (1.5 secs)

Vinz · Aug 31, 2014

1 before each group pick.

Lightning Flare v1.0b

Just another Warcraft III map (Map)

Moderator

Moderator