LifeBloom 1.06 v

[Moderator]

12.12
IcemanBo: For long time as NeedsFix. Rejected.

14:49, 4th May 2011
Bribe:

Needs an in-game screenshot.

 

[Magtheridon96]

Please post triggers and provide an in-game screenshot

-----
EDIT:

Since I don't feel like waiting

Triggers

• HealStart
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Life bloom
  • Actions
    • -------- Store the duration in the Hashtable under the unit's Handle ID --------
    • Hashtable - Save 6.00 as 0 of (Key (Target unit of ability being cast)) in hashTable
    • -------- Add the unit to the group of units that are being healed over time --------
    • Unit Group - Add (Target unit of ability being cast) to HealOverTimeUnits
    • Unit Group - Pick every unit in HealOverTimeUnits and do (Special Effect - Create a special effect attached to the chest of (Picked unit) using s_Nature'sBloom Effect.mdx)

• Healing
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Hashtable - Save + 10 as 0 of 0 in hashTable
    • Special Effect - Destroy rejucgreen
    • Unit Group - Pick every unit in HealOverTimeUnits and do (Actions)
      • Loop - Actions
        • Set RemainingTime = (Load 0 of (Key (Picked unit)) from hashTable)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • RemainingTime Greater than 0.00
          • Then - Actions
            • Unit - Set life of (Picked unit) to ((Life of (Picked unit)) + 10.00)
            • Set loadedtext = (Load 0 of 0 from hashTable)
            • Floating Text - Create floating text that reads loadedtext above (Picked unit) with Z offset 0.00, using font size 10.00, color (0.00%, 100.00%, 0.00%), and 0.00% transparency
            • Floating Text - Change (Last created floating text): Disable permanence
            • Floating Text - Change the lifespan of (Last created floating text) to 0.70 seconds
            • Hashtable - Save (RemainingTime - 1.00) as 0 of (Key (Picked unit)) in hashTable
            • Unit Group - Pick every unit in HealOverTimeUnits and do (Special Effect - Create a special effect attached to the chest of (Picked unit) using Fireworksgreen.mdx)
            • Set rejucgreen = (Last created special effect)
          • Else - Actions
            • Floating Text - Create floating text that reads + 200 above (Picked unit) with Z offset 0.00, using font size 20.00, color (0.00%, 100.00%, 0.00%), and 0.00% transparency
            • Floating Text - Change (Last created floating text): Disable permanence
            • Floating Text - Change the lifespan of (Last created floating text) to 0.70 seconds
            • Unit - Set life of (Picked unit) to ((Life of (Picked unit)) + 200.00)
            • Special Effect - Create a special effect attached to the chest of (Picked unit) using LifeBloom.mdx
            • Unit Group - Remove (Picked unit) from HealOverTimeUnits
            • Hashtable - Clear all child hashtables of child (Key (Picked unit)) in hashTable
            • Wait 1.00 seconds
            • Floating Text - Destroy (Last created floating text)
            • Special Effect - Destroy rejucgreen

*First of all, get rid of that pesky "wait"
*Second, for the sake of cosmetics, give the floating texts
velocity and a fading age.
*Third, it's too simple
*Fourh, instead of waiting before you destroy the special effect,
destroy it immediately after you create it (The effect will execute
either way)
*Fifth, ... I got nothing ;p


Please fix this spell. Good luck

EDIT:
Fifth, the loop trigger was never turned off.
Sixth, the spell isn't fully MUI (look it up ;P)

 

[88WaRCraFT3]

This is idea is stolen just from hashtables tutorial. And... no other words, fix it pls BTW: Nice comment Magtheridon96

 

[Magtheridon96]

^^ Thanks

 

[Adiktuz]

One more... Use in-game screenshot... (oh, Magtheridon already said...)

and, imported models/icons are totally unnecessary for most spell resources...

 

[Tomek320]

damn i give him credits but what i can do if is in real World Of Warcraft spell that simple ..?

 

[88WaRCraFT3]

Don't make it...

 

[Marcos DAB]

We want to see an in-game screenshot.

 

[Dr Super Good]

Hashtable - Save + 10 as 0 of 0 in hashTable
...
Set loadedtext = (Load 0 of 0 from hashTable)

This defeats the purpose of hashtables using them with static indicies.
Rather use a global (or local where possible) variable.

You also do not need to destroy floating text if it is set to fade as it gets destroyed automatically.

You leak a ton of special effects. You need to destroy them after creating them.

I do not see any multi level support.

 

[KinG_O_DarknesS]

No lvls?? wTF?? -1000000/5