[Trigger] Leak?Can it be done better?

[Shade Da Scout]

Are these 2 triggers ok, efficiant, etc.

1

• Food rot
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Item - Pick every item in Food no rot <gen> and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Item-type of (Picked item)) Equal to Chicken Meat
          • Then - Actions
            • Item - Set life of (Picked item) to ((Current life of (Picked item)) - 1.00)
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Item-type of (Picked item)) Equal to Pig Meat
              • Then - Actions
                • Item - Set life of (Picked item) to ((Current life of (Picked item)) - 1.00)
              • Else - Actions

2

• Food dies
  • Events
    • Time - Every 3.00 seconds of game time
  • Conditions
  • Actions
    • Item - Pick every item in (Playable map area) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Item-type of (Picked item)) Equal to Chicken Meat
            • ((Picked item) is in Food no rot <gen>) Equal to False
          • Then - Actions
            • Item - Remove (Picked item)
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Item-type of (Picked item)) Equal to Pig Meat
                • ((Picked item) is in Food no rot <gen>) Equal to False
              • Then - Actions
                • Item - Remove (Picked item)
              • Else - Actions

 

[edo494]

you can merge the conditions in the first trigger to one if statement, because you are doing the same action, just put there or condition and put both of them in there

the same goes for the second one, you can merge it

other then that, I see no problems or leaks, because afaik item enuming doesnt leak

 

[deathismyfriend]

anything u use twice or more store into a variable and use the variable. ex: picked item
same with item type of picked item.

also combine the 2 ITEs and use the or condition so they fire

edit: edo beat me 2 it lol

 

[Shade Da Scout]

Thanks you both
Case solved, thread may be closed.

 

[Wrda]

anything u use twice or more store into a variable and use the variable.

DIMF, you should make a document with this sentence or put in your signature so that people can see that it is really important.

 

[deathismyfriend]

DIMF, you should make a document with this sentence or put in your signature so that people can see that it is really important.

ik lol its getting kinda annoying typing it so much lol