Just Another Harvesting Template v0.01

[Reventhous]

Some in-game screenshot and trigger code should be included so the others can help you out if there is something that can be improved.
And don't worry about crappy code, you can learn to do better here .

 

[Su7VdeR]

I put the important triggers in the description for people to check out. I don't think there's a point to posting an in-game screenshot, as there is nothing really to see. It's just peons chopping away at a gold mine just like peons would chop away at trees.

The biggest problem with the triggers is probably the fact that I create dummies with a generic timer attached to them instead of timers per se to repeatedly add 1 gold to the amount peons are carrying.
This means that for every 1 gold that is gathered a dummy is created.
I just wouldn't know how to make it work with timers in GUI.

 

[Reventhous]

[No multiple reply please]

It's just peons chopping away at a gold mine just like peons would chop away at trees.

In-game, zoom in peons then find nice angle > Screenshot > Crop > Use as treat icon > Done.

The biggest problem with the triggers is probably the fact that I create dummies with a generic timer attached to them instead of timers per se to repeatedly add 1 gold to the amount peons are carrying.
This means that for every 1 gold that is gathered a dummy is created.
I just wouldn't know how to make it work with timers in GUI.

You can use that method, just clear the leak (remove the dummy from the game when it dies)
But for me, I will just create a new trigger with 0.10 or 0.03 timer interval then do the countdown in it.

Like this (I don't have Wc3 with me right now, so... hope you can understand )
Event
Every 0.10 second
Action
if delay[index] greater than 0.00 then
set delay[index] = delay[index] - 0.10
else
add Player(1) gold by 1
---- you can add actions here ---
set delay[index] = harvestDelay[index] <--- reset the delay
endif



About the code, I'll review when we done harvest delay issue.

 

[Daffa]

Promising, but Custom Unit Value aren't allowed in public submission. I recommend to maximize Hash usage instead.

 

[Tank-Commander]

The floating text can be seen by all the players
Store repeatedly used references (such as picked units) into a temporary variable
There should be a configuration to permit different harvesting speeds and harvesting capacities - hard coding data isn't generally good
In extension it would be good if the system could support multiple units types which also can each have different mining capabilities (think goblin shredder but for gold)
The system shouldn't rely on custom unit values as mentioned by Daffa - Linked lists, dynamic array or hashtable would be my recommended solution
place update old submissions instead of uploading duplicates (when things need to be moved, contacting a moderator is better than uploading it again)
Also please attach a version number to your submission or map so that we can keep track of what versions we're reviewing - makes the moderation process eaiser

 

[streetpunk]

Allright, so I'll post here what I posted on the other resource (double created?)

Really nice system, it has some issues but you probably can fix it!

Here are some things I noticed!

1 - The main thing I noticed is that you use dummy units with expiration timer to simulate countdown timers. I used to do it that way too, now I use countdown timers, which I recommend you do to improve performance of your map as of every dummy unit you create (doesn't matter if it dies or is removed) some memory is permanently leaked, you can use a dummy recycler too but I think countdown timers is more recommended.

2 - Another issue is that if I order the unit to harvest from the source it will immeadtly recieve the "Harvesting" buff and also starts the animation, this will happen even if I order the unit with something else in the process (like stop for example), they will begin to mine on the air, not to mention the gold source will be damaged in the process.

3 - If a unit is mining and is ordered to stop or hold position, it won't stop it's animation or the whole mining process.

4 - The value of gold returned vary if the unit is ordered to do something else in the process (sometimes I get 47 gold from a single peon, others I got 135).

5 - You should use a unit indexer to make unit's custom value unique.

I hope you see this as a constructive critic to help improve this project

 

[Su7VdeR]

My mistake for not removing the old thread, I thought I had deleted it.
I'll try and fix these issues once I have some time.