[JASS] Multiple events

[Kamulec]

Trigger "LeavingArea" is complexed. It compiles so I paste only the Init function because I want to ask about it.

function InitTrig_LeavingArea takes nothing returns nothing

    set gg_trg_LeavingArea = CreateTrigger(  )

    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 107
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        call TriggerRegisterLeaveRectSimple( gg_trg_LeavingArea, udg_Area_Region[GetForLoopIndexA()])
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
    call TriggerAddAction( gg_trg_LeavingArea, function Trig_LeavingArea_Actions )

endfunction

Problem:
Trigger doesn't run when one of events occurs. I have used

call DisplayTimedTextToForce( bj_FORCE_PLAYER[0], 120.00, [test string] )

to test it. It clearly shows Trig_LeavingArea_Actions is not executed.

Question:
Why it doesn't work/how to fix?

 

[gorillabull]

make sure the region variable is assigned to a region.
also if you are going to use jass you should use locals, replace forloopindexa and forloopaindexend with local integer something
also make sure test string has some text in it

 

[Kamulec]

also if you are going to use jass you should use locals, replace forloopindexa and forloopaindexend with local integer something

Can it cause errors in this case?


gg_trg_Group_Buildings include call TriggerExecute(gg_trg_Group_Buildings_Plus). These two triggers initialise variables. I have removed event from gg_trg_Group_Buildings and added TriggerExecute to the code (pasted below). The trigger is still not working.

function InitTrig_LeavingArea takes nothing returns nothing

    set gg_trg_LeavingArea = CreateTrigger(  )
    call TriggerExecute( gg_trg_Group_Buildings )
    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 107
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        call TriggerRegisterLeaveRectSimple( gg_trg_LeavingArea, udg_Area_Region[GetForLoopIndexA()])
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
    call TriggerAddAction( gg_trg_LeavingArea, function Trig_LeavingArea_Actions )
endfunction

 

[Kamulec]

Cease help, I have probably found the solution. Tests needed.

If you can please answer on question about the loop A.

 

[gorillabull]

no it cant cause errors unless you call another loop which reassigns those 2 integers different values, its just more convenient to use locals in this case

 

[Kamulec]

Not solved. The problem is gg_trg_Group_Buildings (variable initialization) is executed after the loop (DisplayTimedTextToForce displays zeros). How can I fix that?

function InitTrig_LeavingArea takes nothing returns nothing
    local integer i = 1
    set gg_trg_LeavingArea = CreateTrigger(  )
    call TriggerExecute( gg_trg_Group_Buildings )
    loop
        exitwhen i > udg_NumberOfTowns
        call TriggerRegisterLeaveRectSimple( gg_trg_LeavingArea, udg_Area_Region[i])
        call DisplayTimedTextToForce( bj_FORCE_PLAYER[0], 120.00, R2S(GetRectCenterX(udg_Area_Region[i])) )
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
    call TriggerAddAction( gg_trg_LeavingArea, function Trig_LeavingArea_Actions )
endfunction

NumberOfTowns has a default value = 107.

 

[Arhowk]

You use i in that trigger bu increment bj_forLoopIndexA

 

[PurgeandFire]

Another issue might be, as gorillabull said, that your rects haven't been defined yet. To fix this, change the code to:

function LeavingArea_onStart takes nothing returns nothing
    local integer i = 1
    call DestroyTimer(GetExpiredTimer())
    set gg_trg_LeavingArea = CreateTrigger(  )
    call TriggerExecute( gg_trg_Group_Buildings )
    loop
        exitwhen i > udg_NumberOfTowns
        call TriggerRegisterLeaveRectSimple( gg_trg_LeavingArea, udg_Area_Region[i])
        call DisplayTimedTextToForce( bj_FORCE_PLAYER[0], 120.00, R2S(GetRectCenterX(udg_Area_Region[i])) )
        set i = i + 1 // fixed it as Arhowk said
    endloop
    call TriggerAddAction( gg_trg_LeavingArea, function Trig_LeavingArea_Actions )
endfunction

function InitTrig_LeavingArea takes nothing returns nothing
    call TimerStart(CreateTimer(), 0, false, function LeavingArea_onStart)
endfunction

That way it will wait for the game to start before doing its actions instead of during initialization (where some things might not have been defined yet).

 

[Kamulec]

For now I run gg_trg_Group_Buildings at map initialization, and I do not call it from this function. With this modification, your solution works. Thanks to both of you.