Modify Code

[Parrothead]

Can someone modify these codes so that instead of making units slide on northrend ice to slide on lordaeron summer dirt?

function Trig_Slides_Actions takes nothing returns nothing
    local group g1
    local group g2
    local location p
    local location p2
    local unit u
    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 11
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        set g1 = GetUnitsOfPlayerAndTypeId(ConvertedPlayer(GetForLoopIndexA()), 'hpea')
        set u = GroupPickRandomUnit(g1)
        set p = GetUnitLoc(u)
        if ( IsUnitAliveBJ(u) == true ) then
            if ( GetTerrainTypeBJ(p) == 'Nice' ) then
                set p2 = PolarProjectionBJ(p,7, GetUnitFacing(u))
                call SetUnitPositionLoc( u, p2 )
                call RemoveLocation( p2 )
            endif
        endif
        call RemoveLocation( p )
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
endfunction
function InitTrig_Slides takes nothing returns nothing
    set gg_trg_Slides = CreateTrigger(  )

    call TriggerRegisterTimerEventPeriodic( gg_trg_Slides, 0.02 )
    call TriggerAddAction( gg_trg_Slides, function Trig_Slides_Actions )
endfunction

Can you please change this one to lordaeron summer dirt as well?

function Trig_Skate_Conditions takes nothing returns boolean
    if ( GetBooleanOr(  GetIssuedOrderIdBJ() == String2OrderIdBJ("smart") , GetIssuedOrderIdBJ() == String2OrderIdBJ("move") ) ) then
        return true
    endif
    return false
endfunction

function Trig_Skate_Actions takes nothing returns nothing
    local location p
    local location p2
    set p = GetUnitLoc(GetOrderedUnit())
    if ( GetTerrainTypeBJ(p) == 'Nice' ) then
        set p2 = GetOrderPointLoc()
        call SetUnitPositionLocFacingBJ( GetTriggerUnit(), PolarProjectionBJ(p, 1.00, DistanceBetweenPoints(p, p2)), AngleBetweenPoints(p, p2) )
        call RemoveLocation( p2 )
    endif
    call RemoveLocation( p )
endfunction

function InitTrig_Skate takes nothing returns nothing
    set gg_trg_Skate = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Skate, EVENT_PLAYER_UNIT_ISSUED_POINT_ORDER )
    call TriggerAddCondition( gg_trg_Skate, Condition( function Trig_Skate_Conditions ) )
    call TriggerAddAction( gg_trg_Skate, function Trig_Skate_Actions )
endfunction

 

[Dr Super Good]

Change

'Nice'

in both pieces to be the equivelent for the other terane.

To find this out make a GUI one that references that terane type and convert it into JASS and it will appear.

 

[Parrothead]

So that would be Ldrt!

Thank you!

Edit, how do you turn jass scripts on and off because I want to leave a code initially off but if a player chooses a certain dialog it turns on?

 

[overload119]

I think you want the Trigger - Turn Off action.

I guess in your case you'd make a separate trigger that would check to see if a dialogue button was clicked, then turn on the trigger with that JASS code in it, and if another one is clicked then it will turn it off

 

[Dr Super Good]

Yes, both jass scripts are run by the trigger they are in, and thus turning it on and off turns them on and off.

WARNING
The top script leaks 250 (50 runs per second leaking 5 each) non nulled locals a second and 550 (50 runs per second looping 11 times per run leaking 1 per loop) groups a second.

The bottom script leaks 2 non nulled locals a fire.

SOLUTION
Null all local handles at the end of the function to remove the non nulled local leaks.

Destroy all groups in the upper script after they have been used in the loop (before they are replaced with a new group).

If you do not want to fix this you run the risk of your map becomming unplayable with in a few minutes of playing due to too many leaks, the choice is yours to make and so I strongly recomend you remove all leaks in atleast the upper script atleast as that leaks a unbareable ammount.

 

[busterkomo]

To make it initially off use DisableTrigger. So it would be

call DisableTrigger(gg_trg_Skate)

 

[HINDYhat]

Null all local handles

Not all local handles must be nulled. Things like players and boolexpr (whose functions return constant values) do not need to be nulled.