[JASS] Jass help

[HellsAngel]

I dont understand what im doing wrong in this script if someone could take a look at it and help me out i would appreciate it

function Trig_Nuclear_strike_Conditions takes nothing returns boolean
    if ( not ( GetIssuedOrderIdBJ() == OrderId("clusterrockets") ) ) then
        return false
    endif
    return true
endfunction

function Trig_Nuclear_strike_Actions takes nothing returns nothing
    set effect Nuclear_Stike == AddSpecialEffect
    call PlayThematicMusicBJ( "war3mapImported\\Nuke.wav" )
    call DisplayTextToForce( GetPlayersAll(), "TRIGSTR_035" )
    call AddSpecialEffectLoc(effect "Abilities\\Spells\\NightElf\\TrueshotAura\\TrueshotAura.mdl" GetOrderPointLoc)
    call TriggerSleepAction( 2 )
    call DestroyEffect( Nuclear_Target )
    set effect Nuclear_Strike = null
endfunction

//===========================================================================
function InitTrig_Nuclear_strike takes nothing returns nothing
    set gg_trg_Nuclear_strike = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Nuclear_strike, EVENT_PLAYER_UNIT_ISSUED_POINT_ORDER )
    call TriggerAddCondition( gg_trg_Nuclear_strike, Condition( function Trig_Nuclear_strike_Conditions ) )
    call TriggerAddAction( gg_trg_Nuclear_strike, function Trig_Nuclear_strike_Actions )
endfunction

Thanks

 

[wyrmlord]

I dont understand what im doing wrong in this script if someone could take a look at it and help me out i would appreciate it

function Trig_Nuclear_strike_Conditions takes nothing returns boolean
    if ( not ( GetIssuedOrderIdBJ() == OrderId("clusterrockets") ) ) then
        return false
    endif
    return true
endfunction

function Trig_Nuclear_strike_Actions takes nothing returns nothing
 local effect Nuclear_Stike
    call PlayThematicMusicBJ( "war3mapImported\\Nuke.wav" )
    call DisplayTextToForce( GetPlayersAll(), "TRIGSTR_035" )
    set Nuclear_Strike = AddSpecialEffectLoc("Abilities\\Spells\\NightElf\\TrueshotAura\\TrueshotAura.mdl" GetOrderPointLoc)
    call TriggerSleepAction( 2 )
    call DestroyEffect( Nuclear_Target )
    set Nuclear_Strike = null
endfunction

//===========================================================================
function InitTrig_Nuclear_strike takes nothing returns nothing
    set gg_trg_Nuclear_strike = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Nuclear_strike, EVENT_PLAYER_UNIT_ISSUED_POINT_ORDER )
    call TriggerAddCondition( gg_trg_Nuclear_strike, Condition( function Trig_Nuclear_strike_Conditions ) )
    call TriggerAddAction( gg_trg_Nuclear_strike, function Trig_Nuclear_strike_Actions )
endfunction

Thanks

That should pretty much fix things up. You need to declare a local variable with the word 'local' then a type, then the name. You can then on the same line set it equal to something with a single equal sign or just set it to values later on.

 

[HellsAngel]

Hmm that fixed most things but It says it expected a name

call DestroyEffect( Nuclear_Target )

here and it expected a variable name

set Nuclear_Strike = null

 

[HellsAngel]

Ok i got it working but how would i go about making it so if multiple units cast the same spell it will corectly destroy all the effects from the trigger and not leave them there and no way to destroy them? here is the code i have now

function Trig_Nuclear_strike_Conditions takes nothing returns boolean
    if ( not ( GetIssuedOrderIdBJ() == OrderId("clusterrockets") ) ) then
        return false
    endif
    return true
endfunction

function Trig_Nuclear_strike_Actions takes nothing returns nothing
    local effect udg_Nuclear_Stike
    call PlayThematicMusicBJ( "war3mapImported\\Nuke.wav" )
    call DisplayTextToForce( GetPlayersAll(), "TRIGSTR_035" )
    call AddSpecialEffectLoc( "Abilities\\Spells\\NightElf\\TrueshotAura\\TrueshotAura.mdl", GetOrderPointLoc())
    call TriggerSleepAction( 2 )
    call DestroyEffect( udg_Nuclear_Strike )
    call TriggerSleepAction( 0.20 )
    set udg_Nuclear_Strike = null
endfunction

//===========================================================================
function InitTrig_Nuclear_strike takes nothing returns nothing
    set gg_trg_Nuclear_strike = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Nuclear_strike, EVENT_PLAYER_UNIT_ISSUED_POINT_ORDER )
    call TriggerAddCondition( gg_trg_Nuclear_strike, Condition( function Trig_Nuclear_strike_Conditions ) )
    call TriggerAddAction( gg_trg_Nuclear_strike, function Trig_Nuclear_strike_Actions )
endfunction

 

[Diablo-dk]

why do you call them udg_?
Anyways, the effect will be destroyed no matter how many times you cast it, as you are using a local variable.
Why are you using the event Issued order instead of spell effect?
Also, your condition should look like this instead:

function Trig_Nuclear_strike_Conditions takes nothing returns boolean
    return GetIssuedOrderId() == OrderId("clusterrockets")
endfunction

 

[paskovich]

Here you go:
-You didn't store the effect to the variable
-Less efficient condition (as Diablo wrote)
-It leaked

function Trig_Nuclear_strike_Conditions takes nothing returns boolean
    return GetIssuedOrderId() == OrderId("clusterrockets")
endfunction
function Trig_Nuclear_strike_Actions takes nothing returns nothing
    local effect Nuclear_Stike
    local location l = GetOrderPointLoc()
    call PlayThematicMusicBJ("war3mapImported\\Nuke.wav")
    call DisplayTextToForce(GetPlayersAll(), "TRIGSTR_035")
    set Nuclear_Stike = AddSpecialEffectLoc( "Abilities\\Spells\\NightElf\\TrueshotAura\\TrueshotAura.mdl", l)
    call TriggerSleepAction(2)
    call DestroyEffect(Nuclear_Strike)
    call RemoveLocation(l)
    set l = null
    set Nuclear_Strike = null
endfunction
//===========================================================================
function InitTrig_Nuclear_strike takes nothing returns nothing
    set gg_trg_Nuclear_strike = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Nuclear_strike, EVENT_PLAYER_UNIT_ISSUED_POINT_ORDER )
    call TriggerAddCondition( gg_trg_Nuclear_strike, Condition( function Trig_Nuclear_strike_Conditions ) )
    call TriggerAddAction( gg_trg_Nuclear_strike, function Trig_Nuclear_strike_Actions )
endfunction

 

[HellsAngel]

Thanks alot but it still wont work in the trigger editor it says it wants names for nuclear_strike

call DestroyEffect(Nuclear_Strike)

Comes up with the error "Expected a name"

and

set Nuclear_Strike = null

"Expected a variable name"


Alright nevermind i figured it out looked at my script and realized i spelt Nuclear-strike wrong XD thx for the help