[JASS] Explosive shoot & Five Sword

[Moderator]

6 April 2012
Bribe: Looks pretty good for plain JASS. I recommend using "local trigger t" instead of these global triggers.

I recommend making importing instructions. Yes it is pretty simple but things like making sure the hashtable is there are very important.

 

[Arhowk]

Totally un-configurable. Make it MUCH more configurable. the only thing thats configurable is the ability to trigger! Ex.

1) Distance (based on hero level)
2) Damage (based on hero level)
3) Projectiles

 

[gorillabull]

what else do you need to configure -___-'

 

[shadowvzs]

Totally un-configurable. Make it MUCH more configurable. the only thing thats configurable is the ability to trigger! Ex.

1) Distance (based on hero level)
2) Damage (based on hero level)
3) Projectiles

1. its configurable in object editor the casting range but make it hero level depend is useless, sorry but really no point in that
2. it is based on agility, agility increased by items/levels -> more configurable than hero level
(also i make every damage based on unit level on my map, so no point in make ability damage to level depend, stat depency is better)
3. u can change projectile model in object editor

Seriously i agree if u say "more configurable special effect", "curve" ....

 

[Arhowk]

1. its configurable in object editor the casting range but make it hero level depend is useless, sorry but really no point in that
2. it is based on agility, agility increased by items/levels -> more configurable than hero level
(also i make every damage based on unit level on my map, so no point in make ability damage to level depend, stat depency is better)
3. u can change projectile model in object editor

Seriously i agree if u say "more configurable special effect", "curve" ....

1) Whatever...... Stretching to unit is ugly
2) This is the only UnitDamageTarget in the entire code

call UnitDamageTarget(u, pu, 100.00, true, false, ATTACK_TYPE_HERO, DAMAGE_TYPE_NORMAL, WEAPON_TYPE_WHOKNOWS)
endif

and that deals 100damage. All other damage is object editor, and is ugly. And if you say that agility is more configurable than hero level, its not at all. Make a function that gets called when your about to deal damage and use the unit caster as a parameter. Than its 100% confiurable

 

[zv27]

I do not understand how the damage here is based on agility

Here you set the damage and it's ok

local real dmg = 100 * alv + alv * GetHeroAgi(u,true)

but then you put here only the value of 100

call UnitDamageTarget(u, pu, 100.00, true, false, ATTACK_TYPE_HERO, DAMAGE_TYPE_NORMAL, WEAPON_TYPE_WHOKNOWS)

seems you missed something here
perhaps this

call SaveReal(udg_Spell_Table, id, some value, dmg)

local real dmg=LoadReal(udg_Spell_Table, id, some value)

call UnitDamageTarget(u, pu, [dmg], true, false, ATTACK_TYPE_HERO, DAMAGE_TYPE_NORMAL, WEAPON_TYPE_WHOKNOWS)

 

[shadowvzs]

that right, i have no ideea how i missed that

And if you say that agility is more configurable than hero level, its not at all.

sorry but i dont agree with this, example in my map (like in alot rpg map) i use stating, and could be funny when a lv100 archer deal same damage with abilities even he stated to HP, than other archer who also lv 100 but he put all point to agility...

damage is fixed here, whatever i think setting damage in 1st trigger enough because then every configurable thing could be place there.

Stretching to unit is ugly

i dont got what u mean with this, it isnt streched

 

[AlienAtSystem]

sorry but i dont agree with this, example in my map (like in alot rpg map) i use stating, and could be funny when a lv100 archer deal same damage with abilities even he stated to HP, than other archer who also lv 100 but he put all point to agility...

That's besided the point. Configurability means that I can easily adjust the spell to the needs of my map, where I for example want it to be depending on the ability level and with blue effects. If I have to go through the code, searching for the point where the damage is dealt and where effects are attached is annoying and difficult if the code is not well written. If I can, on the other hand, easily see all relevant data in the gloabals block and be sure that I only have to write what I want there to change what the spell does, then it is easily configurable.

 

[shadowvzs]

That's besided the point. Configurability means that I can easily adjust the spell to the needs of my map, where I for example want it to be depending on the ability level and with blue effects. If I have to go through the code, searching for the point where the damage is dealt and where effects are attached is annoying and difficult if the code is not well written. If I can, on the other hand, easily see all relevant data in the gloabals block and be sure that I only have to write what I want there to change what the spell does, then it is easily configurable.

ok but this isnt vjass where u can use globals, exclude the ugly gui variables (udg_ things), also all thing allways configurable in action part, everything is in action fuction local parts

 

[Arhowk]

you dont need vjass to initialize globals... just do a function sorta like this

function ObtainData takes integer index returns real
if index = 0 then
return 500.00 (range)
endif
if index = 1 then
return 50 x GetHeroLevel(TriggeringUnit) // damage
endif
endfunction

 

[shadowvzs]

@update
- fixed the leak at sword
- removed condition function, i use action only
- used vjass lang. aligner

you dont need vjass to initialize globals... just do a function sorta like this

function ObtainData takes integer index returns real
if index = 0 then
return 500.00 (range)
endif
if index = 1 then
return 50 x GetHeroLevel(TriggeringUnit) // damage
endif
endfunction

1. its point target spell, so dont have a fixed distance for it
2. why i already mentioned the i dont like the hero level part also i dont got why need for this a function call when condition was also a useless function call?