JAS Syntax Errors

[Jak-The-Ripper]

So, I`m currently working on a project called romaen. Romaen searches the string for numbers, removes them, and only displays the letters. In the future, when I`m completely done, you will be able to pick to remove all numbers, certain letters, etx c. But, right now, I`m having trouble with the basic code, before I`ve added anything advanced. Currently, nothing is displayed with the BJDebugMsg.

             /////////////////////////////////////////////////////////////
             //                                                         //
             //                         ROMAEN                          //
             //                                                         //
             /////////////////////////////////////////////////////////////

 function romaen takes string s returns string
   local integer d = 0
   local integer q = 0
   local integer w = 1
   local string n = ""
 loop
     if SubString(s,q,w) == "0" then
       set d = 1
       set s = n
     else
       set n = n + SubString(s,q,w)
     endif
 exitwhen d == 1
     set q = q + 1
     set w = w + 1
 endloop
//     set s = n
     return s
 endfunction

function Trig_test_Actions takes nothing returns nothing
  local string s = "lol"
  call BJDebugMsg(romaen(s))
endfunction

function InitTrig_test takes nothing returns nothing
    set gg_trg_test = CreateTrigger(  )
    call TriggerRegisterPlayerEventEndCinematic( gg_trg_test, Player(0) )
    call TriggerAddAction( gg_trg_test, function Trig_test_Actions )
endfunction

I fixed the above code > > But any constructive criticism and comments are wanted.

 

[PurplePoot]

Your loop never exits unless you find a 0 (and thus set d to 1), and there are no 0s in "lol".

 

[Jak-The-Ripper]

Found that, but now I`m just looking for suggestions for the snippet in general.

 

[Mooglefrooglian]

I would highly recommend expanding this into something like regular expressions.

http://www.webcheatsheet.com/php/regular_expressions.php

This is for PHP but explains the concept perfectly without requiring php knowledge.

But that's only if you want something to do. I can't see very many people using this sort of function in WC3.

 

[PurplePoot]

Not only would it be essentially useless but it's quite hard to do, especially with JASS's excessive limitations in many areas.

 

[Jak-The-Ripper]

Heh.

This is the base function for the three commands I`m creating.

1) Removes all numbers from a string
2) Removes all letters from a string
3) Removes a selected character from a string

This would be helpful for debugging, codes, string manipulation, and just sifting through things.

0t1h4i9s 3i4s5 4a6 s3e0c1r2t5 m87e0s1s1a5g0e

 

[The Reborn Devil]

0t1h4i9s 3i4s5 4a6 s3e0c1r2t5 m87e0s1s1a5g0e

It's not that secret
I saw it immediately ^^

This however is something different: 2BCÃÒCÃÒÂÒÃ@>I@JÒF@ÃÃÂA@! (it says "This is a secret message.")
Encrypted using my cryptor which can be found here: Hives Essential Tools.
Awesome title huh?