[JASS] Item drop issue

[Rugarus]

The below function runs when an item is dropped, I'm trying to check if the last dropped item is inside the rect "Grave_Site"

'1' message runs but not the 2nd message. I'm droping an item right inside the rect though, is this not how you detect a dropped item using 'GetLastRemovedItem()' ?

Thanks.

function onDrop takes nothing returns nothing

local item lastItem = GetLastRemovedItem()

  call DisplayTextToForce(GetPlayersAll(),"1")
   if (RectContainsItem(lastItem, gg_rct_Grave_Site) == true ) then
   call DisplayTextToForce(GetPlayersAll(),"2")
  endif


endfunction
 

function InitTrig_unitDropsItem takes nothing returns nothing
   
    set gg_trg_unitDropsItem = CreateTrigger()
     call TriggerRegisterAnyUnitEventBJ( gg_trg_unitDropsItem, EVENT_PLAYER_UNIT_DROP_ITEM )
      call TriggerAddAction(gg_trg_unitDropsItem ,  function onDrop  )
endfunction

 

[Pyrogasm]

is this not how you detect a dropped item using 'GetLastRemovedItem()' ?

No, it's not. That BJ returns bj_lastRemovedItem which is only set by this function:

function UnitRemoveItemSwapped takes item whichItem, unit whichHero returns nothing
    set bj_lastRemovedItem = whichItem
    call UnitRemoveItem(whichHero, whichItem)
endfunction

so if you're not using that function it won't be the right item. You're not using that function, it's in response to the drop event which does not set that variable. What you want to use is GetManipulatedItem().

 

[Rugarus]

No, it's not. That BJ returns bj_lastRemovedItem which is only set by this function:

function UnitRemoveItemSwapped takes item whichItem, unit whichHero returns nothing
    set bj_lastRemovedItem = whichItem
    call UnitRemoveItem(whichHero, whichItem)
endfunction

so if you're not using that function it won't be the right item. You're not using that function, it's in response to the drop event which does not set that variable. What you want to use is GetManipulatedItem().

I'm trying to detect if an item is dropped inside a rect, but even though the item is dropped inside it doesn't seem to fire off the rest of the function.
This part never fires, or something is wrong. Any ideas what I'm doing wrong? Thanks.

   if (RectContainsItem(lastItem, gg_rct_Grave_Site) == true ) then

function onDrop takes nothing returns nothing

local integer ID_GRAVE = 'I017'
local integer ID_MASSIVE_GRAVE = 'I00O'
local integer ID_UNHOLY_GRAVE = 'I028'
local integer ID_DUMMY = 'h01V'


local item lastItem = GetManipulatedItem()
local unit u = GetTriggerUnit()
local unit dummy

   if (RectContainsItem(lastItem, gg_rct_Grave_Site) == true ) then
   if (GetItemTypeId(lastItem) == (ID_GRAVE)) then
   call CreateNUnitsAtLoc(GetItemCharges(lastItem) , (ID_DUMMY), GetOwningPlayer(u), GetRectCenter(gg_rct_Grave_Spit), bj_UNIT_FACING)
     call IssueBuildOrderByIdLocBJ( GetLastCreatedUnit(), 'u005', GetRandomLocInRect(gg_rct_Grave_Spit) )
   endif
  endif
endfunction
   

function InitTrig_unitDropsItem takes nothing returns nothing
   
    set gg_trg_unitDropsItem = CreateTrigger()
     call TriggerRegisterAnyUnitEventBJ( gg_trg_unitDropsItem, EVENT_PLAYER_UNIT_DROP_ITEM )
      call TriggerAddAction(gg_trg_unitDropsItem ,  function onDrop  )
endfunction

 

[Pyrogasm]

As I see it all is right and it should work. Perhaps you've set the rawcode of the ID_GRAVE variable wrong and it's failing the next if block. Other than that my best guess is that rect isn't the rect you think it is or it isn't in the place you think it is or you're not actually dropping the item in the rect.

You can use BJDebugMsg() in conjunction with I2S() and GetHandleId() to see some information about the variables being used by the function when it runs. I would suggest that.

Also you're leaking two locations: center of the rect and the random point in the rect.

 

[BloodSoul]

If I recall correctly, that event fires before the actual item drop. So, you are probably getting different coordinates from GetItemX/Y functions. Check it out by adding a simple TriggerSleepAction function before getting the item position.

 

[Rugarus]

If I recall correctly, that event fires before the actual item drop. So, you are probably getting different coordinates from GetItemX/Y functions. Check it out by adding a simple TriggerSleepAction function before getting the item position.

Yep that's it. Thanks guys.