[Trigger] Is this trigger fine?

reason 3 · Oct 2, 2009

Is trigger fine?Any way to improve it?Or any leaks?

AddArtifact
- Events
  - Map initialization
- Conditions
- Actions
  - Set ArtifactInteger = (Random integer number between 1 and 11)
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - ArtifactInteger Less than or equal to 1
    - Then - Actions
      - Item - Create Ancient Skull at (Random point in ArtifactRegion <gen>)
    - Else - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Less than or equal to 3
        
        ArtifactInteger Not equal to 0
        
        ArtifactInteger Not equal to 1
        
        Then - Actions
        
        Item - Create Ancient Skull at (Random point in ArtifactRegion1 <gen>)
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Less than or equal to 5
        
        ArtifactInteger Not equal to 0
        
        ArtifactInteger Not equal to 1
        
        ArtifactInteger Not equal to 2
        
        ArtifactInteger Not equal to 3
        
        Then - Actions
        
        Item - Create Ancient Skull at (Random point in ArtifactRegion2 <gen>)
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Less than or equal to 7
        
        ArtifactInteger Not equal to 0
        
        ArtifactInteger Not equal to 1
        
        ArtifactInteger Not equal to 2
        
        ArtifactInteger Not equal to 3
        
        ArtifactInteger Not equal to 4
        
        ArtifactInteger Not equal to 5
        
        Then - Actions
        
        Item - Create Ancient Skull at (Random point in ArtifactRegion3 <gen>)
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Less than or equal to 9
        
        ArtifactInteger Not equal to 0
        
        ArtifactInteger Not equal to 1
        
        ArtifactInteger Not equal to 2
        
        ArtifactInteger Not equal to 3
        
        ArtifactInteger Not equal to 4
        
        ArtifactInteger Not equal to 5
        
        ArtifactInteger Not equal to 6
        
        ArtifactInteger Not equal to 7
        
        Then - Actions
        
        Item - Create Ancient Skull at (Random point in ArtifactRegion4 <gen>)
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Less than or equal to 11
        
        ArtifactInteger Not equal to 0
        
        ArtifactInteger Not equal to 1
        
        ArtifactInteger Not equal to 2
        
        ArtifactInteger Not equal to 3
        
        ArtifactInteger Not equal to 4
        
        ArtifactInteger Not equal to 5
        
        ArtifactInteger Not equal to 6
        
        ArtifactInteger Not equal to 7
        
        ArtifactInteger Not equal to 8
        
        ArtifactInteger Not equal to 9
        
        Then - Actions
        
        Item - Create Ancient Skull at (Random point in ArtifactRegion5 <gen>)
        
        Else - Actions

tagg1080 · Oct 2, 2009

Not equal to 1
Not equal to 2
Not equal to 3
Not equal to 4
Not equal to 5
Not equal to 6
Not equal to 7
Not equal to 8
Not equal to 9
Not equal to 11

Is the same as:

equal to 10

???

reason 3 · Oct 2, 2009

actually no it is equal to 0 and 10

EDIT:Nice signature...if you can read this you really need to get aid?

tagg1080 · Oct 2, 2009

Then:

If int equal to 0 AND int equal to 10

would be a better way?

Just seems to me that all those conditions could be cut out, :eekani:

reason 3 · Oct 2, 2009

ok,thx i will update it in a sec.
EDIT

k is this one better?

AddArtifact
- Events
  - Map initialization
- Conditions
- Actions
  - Set ArtifactInteger = (Random integer number between 1 and 6)
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - ArtifactInteger Equal to 1
    - Then - Actions
      - Item - Create Ancient Skull at (Random point in ArtifactRegion <gen>)
    - Else - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 2
        
        Then - Actions
        
        Item - Create Ancient Skull at (Random point in ArtifactRegion1 <gen>)
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 3
        
        Then - Actions
        
        Item - Create Ancient Skull at (Random point in ArtifactRegion2 <gen>)
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 4
        
        Then - Actions
        
        Item - Create Ancient Skull at (Random point in ArtifactRegion3 <gen>)
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 5
        
        Then - Actions
        
        Item - Create Ancient Skull at (Random point in ArtifactRegion4 <gen>)
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 6
        
        Then - Actions
        
        Item - Create Ancient Skull at (Random point in ArtifactRegion5 <gen>)
        
        Else - Actions

Kercyn · Oct 2, 2009

reason 3 said:
actually no it is equal to 0 and 10
EDIT:Nice signature...if you can read this you really need to get aid?

You don't need to get aid, you need to get laid :xxd:

Plus, locations leak. You should store them in a variable and destroy them at the end of the trigger.

Actions
- set ItemSpawn = (Random point in (ArtifactRegionX))
- Custom script: call RemoveLocation(udg_ItemSpawn)

bReathl3sS · Oct 2, 2009

it is better, but you could still improve it by making it this way:

AddArtifact
- Events
  - Map initialization
- Conditions
- Actions
  - Set Integer = (Random integer number between 1 and 6)
  - For each (Integer A) from 1 to 6, do (Actions)
    - Loop - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        'IF'-Bedingungen
        
        Integer equalto (Integer A)
        
        'THEN'-Aktionen
        
        Set Location = (Random point in Gebiet_Array[(Integer A)])
        
        Item - Create ITEM at Location
        
        Custom script: call RemoveLocation(udg_Location)
        
        'ELSE'-Aktionen

Gebiet_Array would be set (maybe in the same trigger at the top) to all areas.
e.g.
gebiet_array[1]=ArtifactRegion
gebiet_array[2]=ArtifactRegion1

etc.

greetings

reason 3 · Oct 2, 2009

Kercyn said:
You don't need to get aid, you need to get laid

Plus, locations leak. You should store them in a variable and destroy them at the end of the trigger.

Actions

set ItemSpawn = (Random point in (ArtifactRegionX))

Custom script: call RemoveLocation(udg_ItemSpawn)

and what is laid supposed to mean?I'm grom greece :/
and bReathl3sS thx about your time but i don't want it this way.
is this trigger now ok?

AddArtifact
- Events
  - Map initialization
- Conditions
- Actions
  - Set ArtifactInteger = (Random integer number between 1 and 6)
  - Set ArtifactPoint = (Center of ArtifactRegion <gen>)
  - Set ArtifactPoint1 = (Center of ArtifactRegion1 <gen>)
  - Set ArtifactPoint2 = (Center of ArtifactRegion2 <gen>)
  - Set ArtifactPoint3 = (Center of ArtifactRegion3 <gen>)
  - Set ArtifactPoint4 = (Center of ArtifactRegion4 <gen>)
  - Set ArtifactPoint5 = (Center of ArtifactRegion5 <gen>)
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - ArtifactInteger Equal to 1
    - Then - Actions
      - Item - Create Ancient Skull at ArtifactPoint
      - Custom script: call RemoveLocation(udg_ArtifactPoint)
    - Else - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 2
        
        Then - Actions
        
        Item - Create Ancient Skull at ArtifactPoint1
        
        Custom script: call RemoveLocation(udg_ArtifactPoint1)
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 3
        
        Then - Actions
        
        Item - Create Ancient Skull at ArtifactPoint2
        
        Custom script: call RemoveLocation(udg_ArtifactPoint2)
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 4
        
        Then - Actions
        
        Item - Create Ancient Skull at ArtifactPoint3
        
        Custom script: call RemoveLocation(udg_ArtifactPoint3)
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 5
        
        Then - Actions
        
        Item - Create Ancient Skull at ArtifactPoint4
        
        Custom script: call RemoveLocation(udg_ArtifactPoint4)
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 6
        
        Then - Actions
        
        Item - Create Ancient Skull at ArtifactPoint5
        
        Custom script: call RemoveLocation(udg_ArtifactPoint5)
        
        Else - Actions

+rep to all.

tagg1080 · Oct 2, 2009

and what is laid supposed to mean?I'm from greece :/

Get some action, as some would put it... :wink:

reason 3 · Oct 3, 2009

ok,thx i got it now

Coolty44 · Oct 3, 2009

You can easy up your locations by only making 1 and setting it when the conditon is meet in the then part. Destroy it at the very end of the script, and you'll save tons of time too

reason 3 · Oct 3, 2009

Coolty44 said:
You can easy up your locations by only making 1 and setting it when the conditon is meet in the then part. Destroy it at the very end of the script, and you'll save tons of time too

Didn't get that :eekani:

,can you explain more?

Coolty44 · Oct 3, 2009

Well, looking at what you have above, you still leak a location 5 times too.

So basicly, instead of 6 variables for the locations, you copy pasta setting ONE into all the Then - Action parts, changing the region. Then, at the end of your trigger, destroy it, not in the Then - Actions part.

reason 3 · Oct 3, 2009

ok...now how about this?

AddArtifact
- Events
  - Map initialization
- Conditions
- Actions
  - Set ArtifactInteger = (Random integer number between 1 and 6)
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - ArtifactInteger Equal to 1
    - Then - Actions
      - Set ArtifactPoint = (Center of ArtifactRegion <gen>)
      - Item - Create Ancient Skull at ArtifactPoint
    - Else - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 2
        
        Then - Actions
        
        Set ArtifactPoint = (Center of ArtifactRegion1 <gen>)
        
        Item - Create Ancient Skull at ArtifactPoint
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 3
        
        Then - Actions
        
        Set ArtifactPoint = (Center of ArtifactRegion2 <gen>)
        
        Item - Create Ancient Skull at ArtifactPoint
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 4
        
        Then - Actions
        
        Set ArtifactPoint = (Center of ArtifactRegion3 <gen>)
        
        Item - Create Ancient Skull at ArtifactPoint
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 5
        
        Then - Actions
        
        Set ArtifactPoint = (Center of ArtifactRegion4 <gen>)
        
        Item - Create Ancient Skull at ArtifactPoint
        
        Else - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ArtifactInteger Equal to 6
        
        Then - Actions
        
        Set ArtifactPoint = (Center of ArtifactRegion5 <gen>)
        
        Item - Create Ancient Skull at ArtifactPoint
        
        Else - Actions
  - Custom script: call RemoveLocation(udg_ArtifactPoint)

Coolty44 · Oct 3, 2009

Acually it is destroyed. Its just one location, and its only used once. See, he sets it in all of them, then, when the conditions is met in game, it sets the location then. This saves time and room in the variables area. You have to kinda think a little harder and look it over as a whole to understand

reason 3 · Oct 3, 2009

so its fine now?

Coolty44 · Oct 3, 2009

ja ja, looks fine now

reason 3 · Oct 3, 2009

Thx+rep.

[Trigger] Is this trigger fine?

Similar threads