Is this proper use of UnitGroup?

[matisko666]

So I've read over the tutorial about leaks and finally got myself into reworking my leaky triggers...
As the tutorial stated there are black-listed functions that should be avoided at all costs, what I mean is storing the group of units of type.

• UnitGroup
  • Events
  • Conditions
  • Actions
    • Set TempUnitGroup = (Units of type Wandering Merchants)
    • Unit Group - Pick every unit in TempUnitGroup and do (Actions)
      • Loop - Actions
        • Neutral Building - Add |c00959697Ring of |cffff0000Strength|r to (Picked unit) with 1 in stock and a max stock of 1
        • Neutral Building - Add |c00959697Ring of |cff18be00Agility|r to (Picked unit) with 1 in stock and a max stock of 1
        • Neutral Building - Add |c00959697Ring of |cff0000ffIntelligence|r to (Picked unit) with 1 in stock and a max stock of 1
        • Neutral Building - Add |c00959697Ring of |cffffcc00Power|r to (Picked unit) with 1 in stock and a max stock of 1
        • Neutral Building - Add Random_Recipe_Common[(Random integer number between 1 and 8)] to (Picked unit) with 1 in stock and a max stock of 1
        • Neutral Building - Add Random_Recipe_Epic[(Random integer number between 1 and 5)] to (Picked unit) with 1 in stock and a max stock of 1
        • Neutral Building - Add Random_Recipe_Legendary[(Random integer number between 1 and 10)] to (Picked unit) with 1 in stock and a max stock of 1
        • Neutral Building - Add Random_Orb[(Random integer number between 1 and 5)] to (Picked unit) with 1 in stock and a max stock of 1
        • Neutral Building - Add Random_LQ_Armor_Weapon[(Random integer number between 1 and 5)] to (Picked unit) with 1 in stock and a max stock of 1
        • Neutral Building - Add Random_LQ_Armor_Weapon[(Random integer number between 6 and 10)] to (Picked unit) with 1 in stock and a max stock of 1
        • Neutral Building - Add Random_HQ_Armor_Weapon[(Random integer number between 1 and 10)] to (Picked unit) with 1 in stock and a max stock of 1
    • Custom script: call DestroyGroup(udg_TempUnitGroup)

- so storing the units of type is a No-no... then I was wondering how can I do this without use of units of type...

• UnitGroup
  • Events
  • Conditions
  • Actions
    • Set TempUnitGroup = (Units owned by Neutral Passive)
    • Unit Group - Pick every unit in TempUnitGroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Unit-type of (Picked unit)) Equal to Wandering Merchants
          • Then - Actions
            • Neutral Building - Add |c00959697Ring of |cffff0000Strength|r to (Picked unit) with 1 in stock and a max stock of 1
            • Neutral Building - Add |c00959697Ring of |cff18be00Agility|r to (Picked unit) with 1 in stock and a max stock of 1
            • Neutral Building - Add |c00959697Ring of |cff0000ffIntelligence|r to (Picked unit) with 1 in stock and a max stock of 1
            • Neutral Building - Add |c00959697Ring of |cffffcc00Power|r to (Picked unit) with 1 in stock and a max stock of 1
            • Neutral Building - Add Random_Recipe_Common[(Random integer number between 1 and 8)] to (Picked unit) with 1 in stock and a max stock of 1
            • Neutral Building - Add Random_Recipe_Epic[(Random integer number between 1 and 5)] to (Picked unit) with 1 in stock and a max stock of 1
            • Neutral Building - Add Random_Recipe_Legendary[(Random integer number between 1 and 10)] to (Picked unit) with 1 in stock and a max stock of 1
            • Neutral Building - Add Random_Orb[(Random integer number between 1 and 5)] to (Picked unit) with 1 in stock and a max stock of 1
            • Neutral Building - Add Random_LQ_Armor_Weapon[(Random integer number between 1 and 5)] to (Picked unit) with 1 in stock and a max stock of 1
            • Neutral Building - Add Random_LQ_Armor_Weapon[(Random integer number between 6 and 10)] to (Picked unit) with 1 in stock and a max stock of 1
            • Neutral Building - Add Random_HQ_Armor_Weapon[(Random integer number between 1 and 10)] to (Picked unit) with 1 in stock and a max stock of 1
          • Else - Actions
    • Custom script: call DestroyGroup(udg_TempUnitGroup)

- can I use it like this? Storing the units of player and THEN filtering the type via conditions in the loop???

 

[deathismyfriend]

yes that works. Leaks are not the only thing to improve on tho.
U should store anything used twice or more into a variable and use that.
example: store picked unit into a unit variable and use that.

u should take a look at my tutorial things a guier should know

 

[matisko666]

Where exactly do I store the picked unit? Before the loop or inside it and above all functions reffering to the picked unit?

 

[deathismyfriend]

inside and above all the actions that use it. then change picked unit in all those actions to the variable.

 

[matisko666]

One last question sir, does stuff leak when I use position of unit that is already in the map? I mean I have Circles of Power put in the map, do I have to store locations of their positions and then do all the procedure of removing the leak? Because as I understand it the location of something is another created region underneath it...

 

[deathismyfriend]

position / center / offset always leak unless properly taken care of.

u only have to remove the location if ur done with it.
example: if u have player start locations for players 1 to 12 and u store them in an array with the players number then u use that throughout the whole map it wont leak.
A leak is caused by overwriting the variable u use to point to the data.
This leaks because u overwrite the data b4 removing the leak

• Set tempPoint = (Position of ( unit))
• Set tempPoint = (Position of ( unit2))
• Custom script call RemoveLocation( udg_tempPoint)

This doesnt leak because u remove the data b4 changing the variable.

• Set tempPoint = (Position of ( unit))
• Custom script call RemoveLocation( udg_tempPoint)
  • Set tempPoint = (Position of ( unit2))
• Custom script call RemoveLocation( udg_tempPoint)

This doesnt leak because u arent creating a new point and u arent overwriting the variable.

• Set tempPoint = (Position of ( unit))
• move unit to tempPoint
• create unit at tempPoint
• // and so on
• Custom script call RemoveLocation( udg_tempPoint)

 

[matisko666]

Thank you very much, you helped me a lot! +rep

 

[deathismyfriend]

Thank you very much, you helped me a lot! +rep

np and thanks

 

[matisko666]

Oh I forgot, these two are about to be the last time
1.) If I have regions placed in the map and I use periodic spawning of units at center of one region, does the part "at the center of region" create new location point aswell? So it basically means I can store that point one time at initialization and use just the refference to it?
2.) I noticed that there are functions that revive Hero or move unit or anything else but the location doesn't have to be center of anything it's just Player Start Location, does PSL cause leaks even there doesn't seem to be any position (center, offset, point) of something just PSL?

 

[deathismyfriend]

1) yes it creates a new location any and every time u use center / position / offset
yes u can store it and use it just dont overwrite it again.

2) player start location creates a location that leaks. It returns a location. which means it creates a location.

 

[T. D. W.]

1) like dimf said :

position / center / offset always leak unless properly taken care of.

so you will have to store it and then clean it
2) it will leak, and again, like dimf said:

example: if u have player start locations for players 1 to 12 and u store them in an array with the players number then u use that throughout the whole map it wont leak.

EDIT: Yay, Death, you were faster

 

[deathismyfriend]

EDIT: Yay, Death, you were faster

lol thanks haha