"Is this MUI" Part II

[kazenokage]

heya again there is another trigger i want to know if it is MUI, and if not can you help and point out whats wrong.

>

• Protection Learn
  • Events
    • Unit - A unit Learns a skill
  • Conditions
    • (Learned Hero Skill) Equal to Protection (Warrior)
  • Actions
    • Trigger - Add to Protection Run <gen> the event (Unit - ProtectionCaster[Index] Takes damage)

• Protection
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Protection (Warrior)
  • Actions
    • Set Index = (Player number of (Owner of (Casting unit)))
    • Set ProtectionCaster[Index] = (Casting unit)
    • Set ProtectionPercentage[Index] = (ProtectionPercentage[Index] + 0.15)
    • Trigger - Turn on Protection Run <gen>
    • Trigger - Turn on Protection Timer <gen>

• Protection Run
  • Events
  • Conditions
  • Actions
    • Set ProtectionDamageTaken[Index] = (Damage taken)
    • Countdown Timer - Start ProtectionHealthRestore as a One-shot timer that will expire in 0.00 seconds

• Protection Restore
  • Events
    • Time - ProtectionHealthRestore expires
  • Conditions
  • Actions
    • Unit - Set life of ProtectionCaster[Index] to ((Life of ProtectionCaster[Index]) + (ProtectionDamageTaken[Index] x ProtectionPercentage[Index]))

• Protection Timer
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Set ProtectionTimer[Index] = (ProtectionTimer[Index] + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ProtectionTimer[Index] Greater than or equal to 15
      • Then - Actions
        • Trigger - Turn off Protection Run <gen>
      • Else - Actions
        • Trigger - Turn off (This trigger)
        • Set ProtectionPercentage[Index] = 0.00

 

[pick-a-chew]

The way you've triggered this ability is very bizarre... why not just use a DDS?

The easiest way to test if a spell is MUI yourself is to test with bots with shared control.

Triggering looks like it's MUI up until Protection Timer because that trigger literally makes no sense to me. It looks like if you have two or three casts going off, Protection Timer may cut off Protection Run whilst other casts are still running.

 

[kazenokage]

I want to make a spell when activated it will reduce all incoming damage by 15% for 15 seconds.

hmm so Protection Timer is not MUI so maybe i need to further index it.

other than Protection Timer is there other problems might occur?

 

[Maker]

You can take damage multiple times between the 0.00 second timer starting and expiring. So this method does not work correctly for even one unit.

Any well coded damage detection system will make things much easier for you.

 

[kazenokage]

oh , thank you for all the help I am gonna test it this weekend and re-upload if I need help again +rep