[General] Is there a tree nearby?

[scourge069]

Hello hivers, Is there a way to know if there's a nearby tree around a unit?

 

[rulerofiron99]

Use "pick every destructible in range of point" and check if they are trees.

 

[jonhysone]

^ Just Detailing the idea, I am not sure whether from this works but it's worth to try :

Trigger 1 ( Low Chance it works )

• Actions
  • Set YourUnit_Point = (Position of (Triggering unit))
  • Destructible - Pick every destructible within 256.00 of YourUnit_Point and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Picked destructible) Equal to No destructible
        • Then - Actions
          • - Your Trigger -
        • Else - Actions

Trigger 2 - Also low chance

• Actions
  • Set YourUnit_Point = (Position of (Triggering unit))
  • Destructible - Pick every destructible within 256.00 of YourUnit_Point and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • ((Picked destructible) is alive) Equal to True
        • Then - Actions
        • Else - Actions

Trigger 3 - Regular Chance :D

• Actions
  • Set YourUnit_Point = (Position of (Triggering unit))
  • Destructible - Pick every destructible within 256.00 of YourUnit_Point and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Distance between YourUnit_Point and (Position of (Picked destructible))) Less than or equal to 256.00
        • Then - Actions
        • Else - Actions

Trigger 4 - I believe it has a high chance to work :D

• Actions
  • Set TreeType = Ashenvale Tree Wall
  • Set YourUnit = (Triggering unit)
  • Set YourUnitPoint = (Position of YourUnit)
  • Set DestructibleCounter = 0
  • Destructible - Pick every destructible within 256.00 of YourUnitPoint and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Destructible-type of (Picked destructible)) Equal to TreeType
        • Then - Actions
          • Set DestructibleCounter = (DestructibleCounter + 1)
        • Else - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • DestructibleCounter Greater than 0
    • Then - Actions
      • - Setting Boolean that you found a tree -
    • Else - Actions
      • - Setting Boolean that you didn't find a tree -

 

[Bannar]

You could make use of GetClosestWidget with destructable-module on. With such, it's much easier for you:

// where x, y mark coords while filter being a filter function - check for "trees-only"
set tree = GetClosestDestructable(x, y, Filter(function filter))

IsDestructable tree (from wc3c or the one from hive) might also be usefull for you.

 

[sethmachine]

I believe jonhysone's GUI will work for your need (I think the fourth one works correctly).

You could make use of GetClosestWidget with destructable-module on.

This is a useful library, but AFAIK it just finds the example gets the closest widget, or in the OP's case, the closest tree / destructable. The meaning of "nearby," however, is tied to a quantity, namely, how close is nearby? If the closest tree is 10000.0 units away, then that definitely is not nearby (unless the map involves Godzilla-esque giants).

Use "pick every destructible in range of point" and check if they are trees.

This is what you should do. For the location / point, use GetUnitLoc(ation) of the unit in question, and then for range, define how far away is nearby. Is it super close (100-200) or perhaps can be a bit further away (500-1000)?

 

[scourge069]

thanks everyone for your ideas.. +REP to you all..
@jonhysone: I'm gonna try your fourth trigger when I get home, it seems the most legitimate one..

 

[Dr Super Good]

I do recall there being some limit to the number of destructibles picked by the enumeration. As such there is a chance such simple approaches will malfunction if ever run with a large search area or in areas with a high destructible density. The error will manifest as choosing a destructible that is not the closest to the point tested.

 

[scourge069]

limit of how many boss? I don't think that would occur if my radius is only as big as 350 right?

 

[Dr Super Good]

limit of how many boss?

32 or something. I forget.

I don't think that would occur if my radius is only as big as 350 right?

Depends. Nothing stops you stacking 1,000 Destructible objects into that tiny area next to common sense. If you are sure that your map does not have a high density and if it does not really mater if results are not 100% perfect (who cares if in 1-2 spots it picks something that is not the closest in a tiny area?) then it is certainly not a problem. However if you were doing something like finding the nearest trees to harvest from a building out of all trees on the map then this limit is a huge problem.

 

[scourge069]

hmm.. maybe you have a way with this boss? can you show me?

 

[sethmachine]

32 or something. I forget.

What? Are you saying if the enumeration picks out more than 32, it doesn't work right?!

 

[Daffa]

64 is Max amount of Dest Enum AFAIR. Rest are dismissed.
Now that I think about it, I intend to plan a big IDS with super wide range support.

 

[sethmachine]

64 is Max amount of Dest Enum AFAIR. Rest are dismissed.

Thanks for confirming this daffa.

I was worried but it's not a big deal if you want to know if at least one destructable is in range of a point, since only need to count one.

 

[scourge069]

well 64 is already a lot of number.. I guess it'll be fine ..thanks again

 

[Bannar]

It is not true. The limit is none. Limit exists only if you use TriggerRegisterDestDeathInRegionEvent:

function RegisterDestDeathInRegionEnum takes nothing returns nothing
    set bj_destInRegionDiesCount = bj_destInRegionDiesCount + 1
    if (bj_destInRegionDiesCount <= bj_MAX_DEST_IN_REGION_EVENTS) then
        call TriggerRegisterDeathEvent(bj_destInRegionDiesTrig, GetEnumDestructable())
    endif
endfunction

function TriggerRegisterDestDeathInRegionEvent takes trigger trig, rect r returns event
    set bj_destInRegionDiesTrig = trig
    set bj_destInRegionDiesCount = 0
    call EnumDestructablesInRect(r, null, function RegisterDestDeathInRegionEnum)
    return trig
endfunction

And the most important part:constant integer bj_MAX_DEST_IN_REGION_EVENTS = 64If such limit would restrict all of enum functions, then all of my dest-related resources were trash.

This is a useful library, but AFAIK it just finds the closest widget, or in the OP's case, the closest tree / destructable. The meaning of "nearby," however, is tied to a quantity, namely, how close is nearby? If the closest tree is 10000.0 units away, then that definitely is not nearby (unless the map involves Godzilla-esque giants).

Have you even read the lib's description? You can choose varienty of function (related to dest, item, unit and group), thus you could call for example: GetClosestDestructableInRange. By specifing radius value, you can check if a e.g tree exists within circle 10000.0 units away from point "p". Read before posting false opinions.

 

[edo494]

^ Just Detailing the idea, I am not sure whether from this works but it's worth to try :

Trigger 1 ( Low Chance it works )

• Actions
  • Set YourUnit_Point = (Position of (Triggering unit))
  • Destructible - Pick every destructible within 256.00 of YourUnit_Point and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Picked destructible) Equal to No destructible
        • Then - Actions
          • - Your Trigger -
        • Else - Actions

Trigger 2 - Also low chance

• Actions
  • Set YourUnit_Point = (Position of (Triggering unit))
  • Destructible - Pick every destructible within 256.00 of YourUnit_Point and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • ((Picked destructible) is alive) Equal to True
        • Then - Actions
        • Else - Actions

Trigger 3 - Regular Chance :D

• Actions
  • Set YourUnit_Point = (Position of (Triggering unit))
  • Destructible - Pick every destructible within 256.00 of YourUnit_Point and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Distance between YourUnit_Point and (Position of (Picked destructible))) Less than or equal to 256.00
        • Then - Actions
        • Else - Actions

Trigger 4 - I believe it has a high chance to work :D

• Actions
  • Set TreeType = Ashenvale Tree Wall
  • Set YourUnit = (Triggering unit)
  • Set YourUnitPoint = (Position of YourUnit)
  • Set DestructibleCounter = 0
  • Destructible - Pick every destructible within 256.00 of YourUnitPoint and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Destructible-type of (Picked destructible)) Equal to TreeType
        • Then - Actions
          • Set DestructibleCounter = (DestructibleCounter + 1)
        • Else - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • DestructibleCounter Greater than 0
    • Then - Actions
      • - Setting Boolean that you found a tree -
    • Else - Actions
      • - Setting Boolean that you didn't find a tree -

only the last one will work afaik, because if you try to enumerate trees, there is no way you will get "No destructable" in enumeration, if you dont pick any trees, it will not run the loop body even once, so the last approach is the only correct one

Alternativelly, if you have/are willign to use vJass, you can use Bannar's solution

 

[Deleted member 219079]

Gcw is not useful in this case. Just make a global variable true on the enum event. Before it, set it to false. This way if a single dest is picked, it returns true.

I think there's a GUI method of is destructable tree, try googling it.

 

[edo494]

you know you can check the distance from the x, y points and the tree, and also check if the tree is not null, so I see no problem why it wouldnt work

 

[Bannar]

People forgot about one of the most usefull things.. reading comprehension.

There is no difference between IsDestructableTree method for GUI or Jass because both are connected to war3 environment :< We just check if harvest order returns true, end of story.
"GUI solution" differs from jass in being written via custom scripts.

 

[Dr Super Good]

It is not true. The limit is none. Limit exists only if you use TriggerRegisterDestDeathInRegionEvent:

Gah this is why I hate WC3 GUI so much... At least in SC2 they give you the raw natives not wrapped in transparent wrappers that do stuff you clearly do not want them to.

 

[edo494]

BJs also leak like shit(handleids, as well as some objects, like the pan cammera if necessary which causes desync)

 

[Bannar]

WE lost support too quickly for them to fix major issues. War3 lost support quickly in general.

 

[Daffa]

It is not true. The limit is none. Limit exists only if you use TriggerRegisterDestDeathInRegionEvent:

function RegisterDestDeathInRegionEnum takes nothing returns nothing
    set bj_destInRegionDiesCount = bj_destInRegionDiesCount + 1
    if (bj_destInRegionDiesCount <= bj_MAX_DEST_IN_REGION_EVENTS) then
        call TriggerRegisterDeathEvent(bj_destInRegionDiesTrig, GetEnumDestructable())
    endif
endfunction

function TriggerRegisterDestDeathInRegionEvent takes trigger trig, rect r returns event
    set bj_destInRegionDiesTrig = trig
    set bj_destInRegionDiesCount = 0
    call EnumDestructablesInRect(r, null, function RegisterDestDeathInRegionEnum)
    return trig
endfunction

And the most important part:constant integer bj_MAX_DEST_IN_REGION_EVENTS = 64If such limit would restrict all of enum functions, then all of my dest-related resources were trash.

Have you even read the lib's description? You can choose varienty of function (related to dest, item, unit and group), thus you could call for example: GetClosestDestructableInRange. By specifing radius value, you can check if a e.g tree exists within circle 10000.0 units away from point "p". Read before posting false opinions.

I see I mistaken my memories somehow. Thanks for correction.

 

[Dr Super Good]

War3 lost support quickly in general.

Yeh it is only 10 years old... How many 10 year old games are still supported?

 

[edo494]

13 years old

 

[Bannar]

If you consider the balance changes, you would notice that after 1-2 support was lost. WE lost support even quicker. The "surprising" Blade Master nerf years later was more of a holiday present than actual patch.
There was a lot of to improve, yet Blizzard basically ignored wc3, moved to wow and other projects.

 

[sethmachine]

Have you even read the lib's description? You can choose varienty of function (related to dest, item, unit and group), thus you could call for example: GetClosestDestructableInRange. By specifing radius value, you can check if a e.g tree exists within circle 10000.0 units away from point "p". Read before posting false opinions.

I didn't read the full API which is my fault. I should have addressed only the example and not the library, which I'll fix now. But I am not the only one of this opinion, that GCW may be shooting a sparrow with a cannon with regards to the OP (that is a Russian idiom for overkill).

Gcw is not useful in this case.

// where x, y mark coords while filter being a filter function - check for "trees-only"
set tree = GetClosestDestructable(x, y, Filter(function filter))

you know you can check the distance from the x, y points and the tree,

As I pointed out, this just returns the closest tree, but the OP wants to tell whether a tree is nearby, which is different from finding the closest tree. Of course this can be used to do determine it (get the distance between the closest tree and the unit), but then it would have been easier to just have used GetClosestDestructableInRange which was unfortunately absent from the example you gave .

johnysone's solution (the fourth GUI sample) seems more than adequate for the OP's needs. Also I think the OP would benefit more from understanding how it's done before using a high level interface that GCW provides.

I believe jonhysone's GUI will work for your need (I think the fourth one works correctly).

only the last one will work afaik, because if you try to enumerate trees, there is no way you will get "No destructable" in enumeration, if you dont pick any trees, it will not run the loop body even once, so the last approach is the only correct one

 

[edo494]

no, if you know what is nearby(lets say 350 units), you just do

function IsTree_impl takes nothing returns boolean
    return IsTree(GetEnumDestructable())
    //I imagine you pass in enum destructable
    //there is resource for this
endfunction

function IsTreeNearby takes real x, real y, real nearby returns boolean
    local destructable d = GetClosestDestructable(x, y, Filter(function IsTree))
    local real xDist = 0
    local real yDist = 0
    
    if (d == null) then
        return false
    endif

    set xDist = GetDestructableX(d) - x
    set yDist = GetDestructableY(d) - y

    return nearby * nearby < (xDist * xDist + yDist * yDist)
endfunction

As I pointed out, this just returns the closest tree, but the OP wants to tell whether a tree is nearby

So what? a bit of math, and a null check, and you know if tree is nearby. While this is less effective(it has to perform some kind of sort, or check at least to see which tree is closest), it is quite clean one.

On the other node, I wonder Bannar, what happens when I pass in filter for trees, but the closest destructable is not a tree but lets say, a bridge or something?

 

[Bannar]

Nothing strange really. GWC uses Enum Items/Destructables InRect which are declared as:
native EnumDestructablesInRect takes rect r, boolexpr filter, code actionFunc returns nothingYou can provide both, filter and code function.

If you call GetClosestDestructableInRange(x, y, null), script will provide you closest dest, regardless of it's kind. However, if you do:

static method istree takes nothing returns boolean
	return IsDestructableTree(GetFilterDestructable())
endmethod

// some random print function
call print("closest tree: ", GetClosestDestructable(x, y, Filter(function thistype.istree)))

it will only retrieve a tree or null if none has been found.

 

[scourge069]

I'm not really familiar with jass or vjass whatever it's called and so if jonhysone's GUI would work, then that would be my only option. A lot of thanks to you guys for trying to help this dummy here..