[Trigger] Inefficient System Needs Pimped

[RiotZ]

• Weapon
  • Events
    • Unit - A unit Acquires an item
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Item-type of (Item being manipulated)) Equal to Woodcutter's Axe
        • (Item-type of (Item being manipulated)) Equal to Witch Staff
        • (Item-type of (Item being manipulated)) Equal to Great Axe
        • (Item-type of (Item being manipulated)) Equal to Silver Axe
        • (Item-type of (Item being manipulated)) Equal to Hunting Spears
        • (Item-type of (Item being manipulated)) Equal to Steel-tipped Spears
        • (Item-type of (Item being manipulated)) Equal to Heavy Javelins
  • Actions
    • For each (Integer A) from 1 to 6, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • (Item-type of (Item carried by (Hero manipulating item) in slot (Integer A))) Equal to Woodcutter's Axe
                • (Item-type of (Item carried by (Hero manipulating item) in slot (Integer A))) Equal to Witch Staff
                • (Item-type of (Item carried by (Hero manipulating item) in slot (Integer A))) Equal to Great Axe
                • (Item-type of (Item carried by (Hero manipulating item) in slot (Integer A))) Equal to Silver Axe
                • (Item-type of (Item carried by (Hero manipulating item) in slot (Integer A))) Equal to Hunting Spears
                • (Item-type of (Item carried by (Hero manipulating item) in slot (Integer A))) Equal to Steel-tipped Spears
                • (Item-type of (Item carried by (Hero manipulating item) in slot (Integer A))) Equal to Heavy Javelins
          • Then - Actions
            • Set AlreadyHasWeapon[(Custom value of (Triggering unit))] = (AlreadyHasWeapon[(Custom value of (Triggering unit))] + 1)
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • AlreadyHasWeapon[(Custom value of (Triggering unit))] Greater than 1
              • Then - Actions
                • Hero - Drop (Item being manipulated) from (Triggering unit)
                • Set AlreadyHasWeapon[(Custom value of (Triggering unit))] = 0
              • Else - Actions
          • Else - Actions

I have 4 triggers like this, they all do the same thing, which is to restrict you from carrying multiple items, problem is, it's very inefficient, as you can see. And it has a small glitch, where sometimes unit won't pick up an item, even if they don't have an item of that type on them, it has to do with some kind of delay in the actions, or some inefficient way I'm doing it... So help me out, show me what could be improved, and how to fix this glitch.

 

[Wrda]

which is to restrict you from carrying multiple items

Uh? It restricts you from carrying a type of item that you already have? I'm not sure on what you mean though you should store "Hero manipulated unit" into a variable then use it, which makes more efficient and faster, just move the first "Or-Any conditions" to actions by creating a new ITE (if then else) block and putting all stuff there.

 

[deathismyfriend]

u can use doomlords item restriction system as it is pretty efficient.

if not then to make this more efficient anything u use twice or more store into a variable and use the variable. also get rid of integer A / B they are slow and inefficient. instead make ur own variable and use that.

 

[Maker]

Like DIMF said, use this system: https://www.hiveworkshop.com/forums/spells-569/jass-item-restriction-system-irs-v1-0d-232064/

 

[RiotZ]

I can't use Jass. Further suggestions...

 

[Daffa]

There's a manual Guideline in The Description

 

[deathismyfriend]

its a simple system. yes its in jass but the parts u need are custom scripts which are showed how to use them. also if u need help and get stuck just ask and someone will help

 

[RiotZ]

I really hate using Jass though. xD

I would really just prefer to make mine more efficient than use someone else's.