Impale Shock v1.0

[Moderator]

Impale Shock v1.0 | Reviewed by Maker | 23th Oct 2013 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] It is Impale on steroids, and Impale is a cool ability As the ability is derived from Impale, it lacks originality Triggers[/COLOR]] Solid and organized triggering. Good importing istructions You leak two unit groups, indexes 0 and 1 are automatically created at map initialization and you overwrite them. This really a non-issue but keep that in mind You can't pick units with unit type id 0, remove that condition Think of ways to reduce the amount of variables you use. For example, you don't need seven point variables You don't need to locals in the looping trigger, include GetLocationX/Y in SetUnitX/Y You only need one dummy impale caster per cast Objects[/COLOR]] No unneeded objects The death type of the dummy should be can't raise, does not decay so it doesn't decay for 90 seconds The dummy could be configured to be able to cast abilities instantly on targets so you only would need only one dummy unit per cast The dummy ability should deal no damage. The hero who casted the main ability should deal all the damage so it gets the credit from kills The ability uses "attack, slam" animation, but the hero doesn't have that animation The ability description is not very good, the language used could be shaped to suit the Warcarft world a bit better Effects[/COLOR]] The spikes look great The knockback/impale looks smooth Thunderclap is overused, try something different The avenger missile's death effect is a bit out of place Rating[/COLOR]] CONCEPT TRIGGERS OBJECTS EFFECTS RATING STATUS APPROVED

 

[msongyboi]

I haven't really checked the code, but from the test map I think this spell is excellent and sexi as fuq. Good stuff

 

[Maker]

The triggers look good but how can you pick a unit that has no unit type?

 

[Rheiko]

as maker said
and nice, you make the triggers easy to read
good work

 

[nhocklanhox6]

Nice Spell.

 

[FUJI]

The triggers look good but how can you pick a unit that has no unit type?

It is Not Equal to means if the unit's ID != 0 or == false then. It is efficient and safety than checking the unit if it is alive.

as maker said
and nice, you make the triggers easy to read
good work

Nice Spell.

Thanks both of you ^^.

 

[Rheiko]

you are welcome

 

[T. D. W.]

1.0 Review

Personal Words

Review

Suggestions

Rating

Judgement

Note

Yay ^^ the first Spell to benefit from KB3D

Note for the KB3D:

• You MUST leave the variable creator trigger, what if the user doesn't have the implemented KB3D? the WE will pop up missing variables!
• The System is Updated to 1.5.1

-------- ^ xD. Set this to false to not allow the knockbacked unit throughout in the map playable bounds or borders --------

Please remove this! ^
Look:

-------- Allow going outside playable bounds, Allows the KBed unit to go out of the Playable Bounds, SAFETY notice: this will not crash the game -------- Set KB3D_AllowOutSiding = False

The Spell is really cool, and there isn't any trigger problems, maybe and "MAYBE" you may change the Thunder Clap Fx to something else
Anyway, great spell! and Good Job, +rep [even if you disabled it]

None, great job

If You want me to review an Update of This Spell, Please Notifiy me this by VM or PM

 

[Maker]

It is Not Equal to means if the unit's ID != 0 or == false then. It is efficient and safety than checking the unit if it is alive.

That is irrelevant. Let me ask you again, how can you (instantly) pick a unit that has no unit type, a unit that has unit type id of 0?

 

[Bloody Wolf]

5/5 nuff said

 

[FUJI]

^ Thanks