[JASS] I'm new at it and...

[Serbianbeast]

I don't get it what's wrong:

public function DamageCalc takes unit DSource, unit DTarget, string DType, real Dwd, real Dstrd, real Dagid, real Dintd returns real
   local real dmg = 0
   set dmg = Dwd * GetRandomReal(udg_CombatDamageMin[GetUnitUserData(DSource)], udg_CombatDamageMax[GetUnitUserData(DSource)])
   set dmg = dmg + ( Dstrd * I2R(GetHeroStatBJ(bj_HEROSTAT_STR, DSource, true)) ) + ( Dagid * I2R(GetHeroStatBJ(bj_HEROSTAT_AGI, DSource, true)) ) + ( Dintd * I2R(GetHeroStatBJ(bj_HEROSTAT_INT, DSource, true)) )
   return dmg
endfunction

It's a function that calculates damage based on weapon damage (CombatDamageMin and CombatDamageMax, two reals that are linked to unit's custom value) and unit's strength, agility and intelligence, but since I'm new to JASS, and this is my first attempt at making my own function, I don't know what's wrong.
I want to make it possible for every other function to call this one so I guess it has to be public.

 

[Pharaoh_]

Public functions are only used in libraries = vJass. For normal Jass, use the simple keyword "function" and call it as "call DamageCalc (...)". Remember, this function must be in the top of your triggers.

 

[Serbianbeast]

Oh, I've made it
Tnx man, JASS <3

 

[Berb]

GetHeroStatBJ(bj_HEROSTAT_STR, DSource, true)

Whyyyyy.

GetHeroStr(DSource, true)

 

[Serbianbeast]

Now I know why not XD

 

[Serbianbeast]

can any1 tell me where's that bloody endless loop because I can't find it -.-

        set s2 = ""
        set i = 1
        set n = StringLength( s )
        loop
            exitwhen i == n + 1
            set d = f642dec( SubStringBJ(s, i, i) )
            set s2 = s2 + dec2bin ( d, 6 )
            set i = i + 1
        endloop
        set s = s2

function f642dec takes string s returns integer
    local integer i
    local integer x = 0
    set i = 1
    loop
        exitwhen i == 65
        if SubStringBJ( udg_SaveTempString_Copy, i, i ) == s then
            set x = i - 1
        endif
        set i = i + 1
    endloop
    return x
endfunction

function dec2bin takes integer n, integer b returns string
    local string s = ""
    loop
        exitwhen n == 0
        if mod(n, 2) == 1 then
            set s = "1" + s
        else
            set s = "0" + s
        endif
        set b = b - 1
        set n = n / 2
    endloop
    loop
        exitwhen b == 0
            set s = "0" + s
        set b = b - 1
    endloop
    return s
endfunction

and udg_SaveTempString is

udg_SaveTempString_Copy = 03CFG$KL1#M2NZa49de@fP&UIJ8EXYopVWbcqrsQRSTDAB5Htuvghijk6mn7wxyz

 

[Berb]

Wait, what's the problem? There's an infinite loop here somewhere?

 

[Serbianbeast]

Exactly, and I can't figure out where, but don't bother. I managed to work this around.

 

[Serbianbeast]

if GetLocalPlayer() == GetOwningPlayer(GetOrderedUnit()) then
    SomeCodeOfMine(whatever)
endif

Shouldn't this function SomeCodeOfMine(whatever) be executed for owner of event response - ordered unit's owner only? I can't get it to work... It keeps executing that function to all players. To be precise SomeCodeOfMine actually displays certain Multiboard containing some info about items.
So please people, give me a hint...

 

[MortAr]

You can display the multiboard without the local player.

Using GetLocalPlayer() causes a desync, so first you need to execute the action globally and then only for the specific player.

More about local variables, read this.

 

[Serbianbeast]

I need it to be displayed to that one player only...

 

[MortAr]

Then first hide it for all players, and show it to a single player.

 

[Serbianbeast]

You know that it can't be displayed to single player only? That's the reason I'm using that system I showed in example.

 

[MortAr]

That's the reason why I told you about desync in GetLocalPlayer.

As I stated above, hide the multiboard, THEN show it to the player via GetLocalPlayer.

 

[Serbianbeast]

Nope, the problem remains but in a different shape:
This table still appears to all players, then gets hidden for all players (so all other players lose their current tables), and then it appears for local player. -.-
I used the code mentioned above in 2 more places but the only difference is that it's not the GetOwningPlayer(GetOrderedUnit()) but GetTriggerPlayer() or using loop and comparing indexes, and it worked perfectly... Until now. -.-

 

[Anachron]

local multiboard b = null //: Actually create a new one or use any.

call MultiboardDisplay(b, false)

if GetLocalPlayer() == YourPlayer then
    call MultiboardDisplay(b, true)
endif

This works.
Please be more specific.

 

[Serbianbeast]

That's the same thing I did... But it seems that the problem is in that comparison:
if GetLocalPlayer() == GetOwningPlayer(GetOrderedUnit()) then...
It seems not to work properly and execute "then" expressions no matter what player it's about...
I'll work this around somehow...

 

[Anachron]

Yes, thats because GetOrderedUnit() can be null, thus being for all players.
Use GetTriggerUnit() instead.

 

[Serbianbeast]

Finally got it working:
Made this multiboard at a same time when I made the other ones (at map init), hid the table (just like others) and instead of making new one in trigger, I changed number of rows and columns, changed its content and displayed it to GetOwningPlayer(GetTriggerUnit()) only, and it works flawlessly. Tnx for help guys.

 

[Anachron]

If you still have questions about GetLocalPlayer, just continue posting here.

 

[Serbianbeast]

I'll keep posting any JASS questions here instead of making new threads.

 

[Anachron]

Awesome, that decreases the amount of questions in t&s.