How to Lock cameras to units for observers?

[bowser499]

How to Lock cameras to units for observers?
I've done something like this:

function Trig_Lock_Conditions takes nothing returns boolean
    return SubString(GetEventPlayerChatString(),0,5) == "-lock"
endfunction

function Trig_Lock_Actions takes nothing returns nothing
    local string s = GetEventPlayerChatString()
    local integer length = StringLength(s)
    local player p = GetTriggerPlayer()
    local integer id = S2I(SubString(s,6,length))
    if IsPlayerObserver(p) == true then
        if length < 7 or length > 7 then
            call DisplayTextToPlayer(p,0,0,"Enter the command again. Wrong request.")    
            return
        elseif length == 7 then
            if GetLocalPlayer() == p then
                call SetCameraTargetController(udg_PickedHero[id],0,0,false)
            endif
        endif
    endif
    set p = null    
endfunction

//===========================================================================
function InitTrig_Lock takes nothing returns nothing
    set gg_trg_Lock = CreateTrigger()
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(0),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(1),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(2),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(3),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(4),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(5),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(6),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(7),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(8),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(9),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(10),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(11),"-lock",false)
    call TriggerAddCondition(gg_trg_Lock,Condition(function Trig_Lock_Conditions))
    call TriggerAddAction(gg_trg_Lock,function Trig_Lock_Actions)
endfunction

 

[Pharaoh_]

Use "SetCameraTargetControllerNoZForPlayer()"; you don't need GetLocalPlayer() function, when there already is a native that has internal local player.

 

[bowser499]

function Trig_Lock_Conditions takes nothing returns boolean
    return SubString(GetEventPlayerChatString(),0,5) == "-lock"
endfunction

function Trig_Lock_Actions takes nothing returns nothing
    local string s = GetEventPlayerChatString()
    local integer length = StringLength(s)
    local player p = GetTriggerPlayer()
    local integer id = S2I(SubString(s,6,length))
    if IsPlayerObserver(p) == true then
        if length < 7 or length > 7 then
            call DisplayTextToPlayer(p,0,0,"Enter the command again. Wrong request.")    
            return
        elseif length == 7 then
            call SetCameraTargetControllerNoZForPlayer(p,udg_PickedHero[id],0,0,false)
        endif
    endif
    set p = null    
endfunction

//===========================================================================
function InitTrig_Lock takes nothing returns nothing
    set gg_trg_Lock = CreateTrigger()
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(0),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(1),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(2),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(3),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(4),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(5),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(6),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(7),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(8),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(9),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(10),"-lock",false)
    call TriggerRegisterPlayerChatEvent(gg_trg_Lock,Player(11),"-lock",false)
    call TriggerAddCondition(gg_trg_Lock,Condition(function Trig_Lock_Conditions))
    call TriggerAddAction(gg_trg_Lock,function Trig_Lock_Actions)
endfunction

Will this work only for observers?

 

[bowser499]

This don't worked...

 

[Pharaoh_]

So wait, your actual question was the code to be applied for observers only? Well, you need to detect what player is an observer. Normally, observers have no units or the map is visible to them. You can make two checks; let's say that you have a time limit of when the players can choose their heroes. After that timer expires, you can check which players don't own units (Number of units owned by (Picked player) [from (All players)] Equal to 0). I presume you already give units to players that haven't picked any units, before the timer expires.
Another check you can do is whether the Fog of War or Black mask is disabled for the (EnumPlayer()). You will need GetLocalPlayer() for that.

Additionally, you can rename a race to be "Observer"; then, you can make a check of what the race of the player is. If it's "Observer", make your stuff, e.g. Enable visibility across the map, etc.

You can also make an additional player force. If the player belongs to the third force, he is an observer (you will use a player indexing to restore the position of the player in the (All players) structure); for player numbers higher than 9 for example (= 10, 11, 12), those players will be considered as observers. There are many ways to do that.

 

[bowser499]

I've done all the options for observers and tried to code some stuff for them.
Maybe the problem is the text messages typed by observers are ignored by wc3 engine...