Help with trigger

[mogulkhan1Axe]

Hey just quick question about 1 trigger.
Should i do it like this

trigger

• Bush Picked up
  • Events
    • Unit - A unit Acquires an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to DroppedItems_Branch
    • (Unit-type of (Triggering unit)) Equal to Survivor_Type
  • Actions
    • Set tempItem = (Item being manipulated)
    • For each (Integer tempInt) from 1 to 12, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Owner of (Triggering unit)) Equal to Players[tempInt]
          • Then - Actions
            • Set Item_Branch[tempInt] = (Item_Branch[tempInt] + (Charges remaining in tempItem))
          • Else - Actions
    • Set tempItem = No item
    • Trigger - Run Update MB <gen> (ignoring conditions)

or should i have unit also saved into a variable because i have like 6 of alike triggers.

 

[axleion]

tell us what are you trying to achieve?
we can't tell what your trigger want to do hence we won't be able to help you with that

 

[Shadow Fury]

Where's the problem with that and, as Dark_Axl asked, what are you trying to achieve?

 

[Arad MNK]

Could you add Update MB Too?

 

[mogulkhan1Axe]

Yeah guys sorry im trying to achieve an item pickup like when u pick up the item with 3 charges it adds it into a ''variable'' and updates multiboard (updateMB)
So for example i pick up some 3 planks adds it into a specific player variable and updates it on the multiboard so. MY question here is do i have to put a player into a variable also the triggering unit so i wont have leaks. To be more specific this line of code

• (Owner of (Triggering unit)) Equal to Players[tempInt]

it has Owner of triggering unit (player) and triggering unit(unit) and neither of them arent put in variables for deindexing at the end of the code. (im hoping its called deindexing)

tell us what are you trying to achieve?
we can't tell what your trigger want to do hence we won't be able to help you with that

Where's the problem with that and, as Dark_Axl asked, what are you trying to achieve?

Could you add Update MB Too?

also Arad update mb isnt needed cuz it only updates multiboard numbers.
But just for you

UpdateMB

• Update MB
  • Events
  • Conditions
  • Actions
    • For each (Integer tempInt) from 1 to 12, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Player(tempInt)) slot status) Equal to Is playing
            • ((Player(tempInt)) controller) Equal to User
          • Then - Actions
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 1 to Player_Names[tempInt]
            • -------- ==================================================== --------
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 3 to (String(Item_Branch[tempInt]))
            • -------- ==================================================== --------
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 4 to (String(Item_Coal[tempInt]))
            • -------- ==================================================== --------
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 5 to (String(Item_Eatable_Meat[tempInt]))
            • -------- ==================================================== --------
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 6 to (String(Item_Hay[tempInt]))
            • -------- ==================================================== --------
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 7 to (String(Item_Iron[tempInt]))
            • -------- ==================================================== --------
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 8 to (String(Item_Planks[tempInt]))
            • -------- ==================================================== --------
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 9 to (String(Item_Poisonous_Meat[tempInt]))
            • -------- ==================================================== --------
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 10 to (String(Item_Sticks[tempInt]))
            • -------- ==================================================== --------
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 11 to (String(Item_Water[tempInt]))
            • -------- ==================================================== --------
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 12 to (String(Item_Wool[tempInt]))
            • -------- ==================================================== --------
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 14 to (String(Stats_Starvation[tempInt]))
            • -------- ==================================================== --------
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 15 to (String(Stats_Thirst[tempInt]))
            • -------- ==================================================== --------
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 16 to (String(Stats_Warmth[tempInt]))
            • -------- ==================================================== --------
            • Multiboard - Set the text for Multiboards[tempInt] item in column 2, row 17 to (String(Stats_Time_Alive[tempInt]))
          • Else - Actions
    • Set tempInt = 0

 

[Maker]

There is are no leaks.

You could do it like this

set integer = player number of triggering player
set ItemBranch[tempInteger] = ...
Update MB

 

[mogulkhan1Axe]

There is are no leaks.

You could do it like this

set integer = player number of triggering player
set ItemBranch[tempInteger] = ...
Update MB

Thank you but one last thing i dont have to do that right and it will still be leakless ?

 

[Arad MNK]

What I understood:
You want to store The Owner of triggering unit into A Variable ??
Use player Variables and then Clean it up.

 

[mogulkhan1Axe]

What I understood:
You want to store The Owner of triggering unit into A Variable ??
Use player Variables and then Clean it up.

yes but idk how to cleanup player variables.

 

[Maker]

You don't have to clean up player variables.

 

[mogulkhan1Axe]

You don't have to clean up player variables.

oh alright thanks