[Trigger] GUI trigger drops me to desktop

[Deon]

Hello, I was trying to make a simple "stacking" system without different "items for inventory" and "items for ground" (rune system) so I've written this.
However when I try to pick up "fruit" I am dropped to desktop without ANY error.

• Events
  • Unit - A unit Acquires an item
• Conditions
  • (Item-type of (Item being manipulated)) Equal to Fruit
• Actions
  • Set pickedItemGround[(Player number of (Owner of (Triggering unit)))] = (Item being manipulated)
  • Hero - Drop pickedItemGround[(Player number of (Owner of (Triggering unit)))] from (Triggering unit)
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • ((Triggering unit) has an item of type Fruit) Equal to True
    • Then - Actions
      • Set pickedItemcarried[(Player number of (Owner of (Triggering unit)))] = (Item carried by (Triggering unit) of type Fruit)
      • Item - Set charges remaining in pickedItemcarried[(Player number of (Owner of (Triggering unit)))] to ((Charges remaining in pickedItemcarried[(Player number of (Owner of (Triggering unit)))]) + (Charges remaining in pickedItemGround[(Player number of (Owner of (Triggering unit)))]))
      • Item - Remove pickedItemGround[(Player number of (Owner of (Triggering unit)))]
    • Else - Actions
      • Hero - Create Fruit and give it to (Triggering unit)
      • Item - Remove pickedItemGround[(Player number of (Owner of (Triggering unit)))]

Any help please?

 

[peq]

Your Trigger triggers itself.

 

[Dr Super Good]

What you are doing makes no sense.

Your hero picks up fruit.
Your hero drops the fruit.
Your hero does not have fruit.
You create a fruit and give it to the hero.
Your hero picks up fruit.
Your hero drops the fruit.
Your hero does not have fruit.
You create a fruit and give it to the hero.
Your hero picks um fruit.
....

The aquires item event triggers with all item additions to a hero, even items added via triggers (atleast for GUI).

 

[Deon]

I've already fixed it, so there's a small wait there (before check).
I don't like the only thing: I have to instantly switch the trigger off while I give the item and then back on, but it works ok for now.

 

[Eleandor]

Don't use any waits, just turn trigger off at start and turn back on at the end. Since triggers without waits run instantly, that would be the best solution.

 

[Deon]

If I don't use wait it can't check if the unit carries the same item to add charges, because when I pick the item up it's already considered as carried.

 

[Eleandor]

- Don't drop the item you've picked up
- Loop through all items in your inventory and merge items that have duplicates

A rune system would be better anyway because you need to have 1 free inventory slot with this trigger.