[Solved] GUI error made by WE itself

[Marcell]

Hi all,

I don't understand why GUI gives me an error with a script itself created:

function Trig_Lay_Mines_Conditions takes nothing returns boolean
if ( not ( GetSpellAbilityId() == 'A005' ) ) then
return false
endif
return true
endfunction

function Trig_Lay_Mines_Actions takes nothing returns nothing
set udg_Miner = GetUnitLoc(GetSpellAbilityUnit())
set bj_forLoopAIndex = 1
set bj_forLoopAIndexEnd = 5
loop
exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
set udg_Miner2 = OffsetRectBJ(udg_Miner2, GetRandomReal(0, 250.00), GetRandomReal(0, 250.00))
call CreateNUnitsAtLoc( 1, 'nglm', GetOwningPlayer(GetSpellAbilityUnit()), GetRectCenter(udg_Miner2), bj_UNIT_FACING )
call RemoveLocation(udg_Miner2)
set bj_forLoopAIndex = bj_forLoopAIndex + 1
endloop
endfunction

The "set bj_forLoopAIndex = bj_forLoopAIndex + 1" is not in my script so it's auto generated by the GUI, but it tells me "Invalid argument type (rect)

What does this mean?

 

[KILLCIDE]

It generated because you used a for loop. This is what for loops look like behind the scenes:

function ForLoop takes nothing returns nothing
    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 10
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
endfunction

Regardless, the loop isn't what is causing the error, it's this one: set udg_Miner2 = OffsetRectBJ(udg_Miner2, GetRandomReal(0, 250.00), GetRandomReal(0, 250.00)). OffsetRect expects the first argument to be a rect, not a location.

 

[Dr Super Good]

set udg_Miner2 = OffsetRectBJ(udg_Miner2, GetRandomReal(0, 250.00), GetRandomReal(0, 250.00))
call CreateNUnitsAtLoc( 1, 'nglm', GetOwningPlayer(GetSpellAbilityUnit()), GetRectCenter(udg_Miner2), bj_UNIT_FACING )
call RemoveLocation(udg_Miner2)

Caused by inconsistent variable type of udg_Miner2. In one place you use it as a rect, and in the other as a location. Rect and location are different types.

Make sure the GUI variable Miner2 is being used correctly. You might find that in one or more of the actions it is no longer able to be selected.

 

[Marcell]

Caused by inconsistent variable type of udg_Miner2. In one place you use it as a rect, and in the other as a location. Rect and location are different types.

Make sure the GUI variable Miner2 is being used correctly. You might find that in one or more of the actions it is no longer able to be selected.

Err, I don't understand this French you speak xD. So here's the Trigger, I THINK I know what you mean:

• Lay Mines
  • Events
    • Unit - A unit Finishes casting an ability
  • Conditions
    • (Ability being cast) Equal to Lay mines
  • Actions
    • Set Miner = (Position of (Casting unit))
    • For each (Integer A) from 1 to 5, do (Actions)
      • Loop - Actions
        • Set Miner2 = (Miner offset by ((Random real number between 0.00 and 250.00), (Random real number between 0.00 and 250.00)))
        • Unit - Create 1 Goblin Land Mine for (Owner of (Casting unit)) at (Center of Miner2) facing Default building facing degrees
        • Custom script: call RemoveLocation(udg_Miner2)

Is it the random real number used twice?

EDIT:
Never mind, I fixed it:

• Lay Mines
  • Events
    • Unit - A unit Finishes casting an ability
  • Conditions
    • (Ability being cast) Equal to Lay mines
  • Actions
    • Set Miner = (Position of (Casting unit))
    • For each (Integer A) from 1 to 5, do (Actions)
      • Loop - Actions
        • Unit - Create 5 Goblin Land Mine for (Owner of (Casting unit)) at (Miner offset by ((Random real number between 0.00 and 200.00), (Random real number between 0.00 and 200.00))) facing Default building facing degrees
    • Custom script: call RemoveLocation(udg_Miner)

 

[Dr Super Good]

Never mind, I fixed it:

Your "fix" leaks 5 locations per execution.

 

[Marcell]

Your "fix" leaks 5 locations per execution.

So my custom script needs to be in the loop or is the "RemoveLocation" incorrect for a point integer?

 

[pOke]

Not exactly, you need to save the Miner Offset by .... into a variable and clear it each loop.

It will look this

set someLocation
loop
set someLocation2 = someLocation offset by X toward Y
Create Unit at someLocation2
RemoveLocation(udg_someLocation2)
endloop
RemoveLocation(udg_someLocation)

sorry for formatting,mobile.

 

[Hotwer]

• Lay Mines
  • Events
    • Unit - A unit Finishes casting an ability
  • Conditions
    • (Ability being cast) Equal to Lay mines
  • Actions
    • Set Miner = (Position of (Casting unit))
    • For each (Integer A) from 1 to 5, do (Actions)
    • Loop - Actions
      • Set Miner2 = (Center of (Miner offset by ((Random real number between 0.00 and 250.00), (Random real number between 0.00 and 250.00))))
      • Unit - Create 1 Goblin Land Mine for (Owner of (Casting unit)) at Miner2) facing Default building facing degrees
      • Custom script: call RemoveLocation(udg_Miner2)
    • Custom script: call RemoveLocation(udg_Miner)

This is what @Dr Super Good was talking about:

• Set Miner2 = Miner offset by ((Random real number between 0.00 and 250.00), (Random real number between 0.00 and 250.00)))

This returns a Rect, therefore why RemoveLocation doesn't work.
Also you need to remove the first region you saved (udg_Miner)