[JASS] Spell - Grease, stops when running "TimerStart", why?

[xXMephistoXx]

As in the headline, why does the function stop running at "TimerStart"? The actions in the callback-function are not yet complete, and doesn't currently work, will this stop the function from continuing..?

The functions:

function GreaseActionFunction takes nothing returns nothing
    call CreateNUnitsAtLoc(1, 'h001', GetOwningPlayer(GetTriggerUnit()), GetSpellTargetLoc(), bj_UNIT_FACING)
    call UnitApplyTimedLifeBJ(10.00, 'BTLF', GetLastCreatedUnit())
    call UnitAddAbilityBJ('Aslo', GetLastCreatedUnit())
    call IssueTargetOrderBJ(GetLastCreatedUnit(), "slow", GetEnumUnit())
endfunction

function GreaseTimerFunction takes nothing returns nothing
    call ForGroupBJ(GetUnitsInRectAll(RectFromCenterSizeBJ(GetSpellTargetLoc(), 300.00, 300.00)), function GreaseActionFunction)
endfunction

function GreaseFunction takes nothing returns nothing
    local unit c = GetTriggerUnit()
    local location t = GetSpellTargetLoc()
    local effect array effect1
    local timer timer1
    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 20
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        call AddSpecialEffectLocBJ(GetRandomLocInRect(RectFromCenterSizeBJ(t, 300.00, 300.00)), "Abilities\\Spells\\Undead\\PlagueCloud\\PlagueCloudCaster.mdl")
        set effect1[GetForLoopIndexA()] = GetLastCreatedEffectBJ()
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
    call TimerStart(timer1, 1.00, true, function GreaseTimerFunction)
    set timer1 = null
    call TriggerSleepAction((6.00 + (2.00 * I2R(GetUnitLevel(c)))))
    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 20
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        call DestroyEffectBJ(effect1[GetForLoopIndexA()])
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
    call DestroyTimer(timer1)
    call RemoveLocation(t)
endfunction

 

[Xarwin]

Did you know you're using BJ's?
And you nullify your timer after you run it? Appears to be a smart move ^^.

 

[xXMephistoXx]

Thanks for replying, but I really have no idea what you're talking about :S I'm in the process of learning jass (still).

 

[Xarwin]

Me too, but listen up you're using BJ's, those are not good and are also used by the GUI part.
You'll need to get rid of them, Get the Warcraft 3 NewGen, it will help you a lot.

And for the second part,
your timer.

    call TimerStart(timer1, 1.00, true, function GreaseTimerFunction)
    set timer1 = null

You instantly nullify it, which means you're deleting all of the data it should use (if I'm correct).

 

[xXMephistoXx]

I am using NewGen, just not it's functions :S

 

[Xarwin]

Let me give it a try, hold on some minuts
Edit I am sorry, I need to help on something else.
But this is an example you can use for your functions above:

function GreaseActionFunction takes nothing returns nothing
    local unit dum = GetTriggerUnit()
    local unit dummy
    local unit enemy = GetSpellTargetUnit()
    local real x = GetUnitX(dum)
    local real y = GetUnitY(dum)
    local player owner = GetOwningPlayer(dum)
    set dummy = CreateUnit(owner,'h001',x,y,0.)
    call UnitApplyTimedLife(dummy,'BTLF',10.)
    call UnitAddAbility(dummy,'Aslo')
    call IssueTargetOrder(dummy,"slow",enemy)
    set dum = null
    set dummy = null
    set enemy = null
    set owner = null
endfunction

Your loops should be like this :

loop
set i = i+1
    exitwhen  i > 10 // your number
    actions
endloop

try placing

set timer1 = null

below your wait.

Your group and some few other BJ functions should be converted into non-bj.

 

[Viikuna]

The reason why we null local handle variables, is that when some object is removed its hande id cant be recycled if there is some local pointing to it.

set owner = null

This is not needed, because players are never removed.

Nulling a local timer variable has no effect to timers functionality ( you are only modifying a pointer, not the object itself ), so you can null it as soon as you have started your timer.

edit. But if you do this, you end up trying to destroy null.

call DestroyTimer(timer1) // timer1 == null

Also, CreaseActionFunction is not gonna work, because you can only use functions like GetTriggerUnit() and GetSpellTargetLoc() in triggeractions and conditions.

You have not posted your whole trigger, but I can guess that your triggeraction is function GreaseFunction.

You have a line like this in your InitTrig:

call TriggerAddAction(yourtrigger, function GreaseFunction)

?

 

[Shadow Daemon]

You instantly nullify it, which means you're deleting all of the data it should use (if I'm correct).

False.

set timer1 = null

will only nullify the reference to the object.

The real problem is in that he hasn't even created that damn timer

// . . .
function GreaseFunction takes nothing returns nothing
    local unit c = GetTriggerUnit()
    local location t = GetSpellTargetLoc()
    local effect array effect1
    // --->>
    local timer timer1 = CreateTimer()
    // <<---
    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 20
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        call AddSpecialEffectLocBJ(GetRandomLocInRect(RectFromCenterSizeBJ(t, 300.00, 300.00)), "Abilities\\Spells\\Undead\\PlagueCloud\\PlagueCloudCaster.mdl")
        set effect1[GetForLoopIndexA()] = GetLastCreatedEffectBJ()
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
    call TimerStart(timer1, 1.00, true, function GreaseTimerFunction)
    // >> no need to have that thing here
    //set timer1 = null
    call TriggerSleepAction((6.00 + (2.00 * I2R(GetUnitLevel(c)))))
    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 20
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        call DestroyEffectBJ(effect1[GetForLoopIndexA()])
        // cleaning up handle references
        set effect1[GetForLoopIndexA()] = null
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
    call DestroyTimer(timer1)
    call RemoveLocation(t)
    // cleaning up all handle references
    set timer1 = null
    set t = null
    set c = null
endfunction

By the way, there are a bunch of leaks.

 

[Viikuna]

The real problem is in that he hasn't even created that damn timer

Oh yea, I didnt even notice that one.

 

[xXMephistoXx]

Auch Didn't know you had to put "CreateTimer() there :S Thansk =) +rep

Well, it still doesn't work :S But now it's a different issue, since it now takes the functions after the timer
It's like this:

function GreaseActionFunction takes nothing returns nothing
    local unit d
    local group g = CreateGroup()
    call GroupAddGroup(GetUnitsInRectAll(RectFromCenterSizeBJ(GetSpellTargetLoc(), 300.00, 300.00)), g)
    call CreateNUnitsAtLoc(1, 'h001', GetOwningPlayer(GetTriggerUnit()), GetSpellTargetLoc(), bj_UNIT_FACING)
    set d = GetLastCreatedUnit()
    call UnitApplyTimedLifeBJ(10.00, 'BTLF', d)
    call UnitAddAbilityBJ('A017', d)
    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = CountUnitsInGroup(g)
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        call IssueTargetOrderBJ(d, "slow", FirstOfGroup(g))
        call GroupRemoveUnit(g, FirstOfGroup(g))
        call DisplayTextToForce(GetPlayersAll(), "TRIGSTR_194")
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
endfunction

function GreaseFunction takes nothing returns nothing
    local unit c = GetTriggerUnit()
    local location t = GetSpellTargetLoc()
    local effect array effect1
    local timer timer1 = CreateTimer()
    local rect rect1 = RectFromCenterSizeBJ(t, 300.00, 300.00)
    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 20
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        call AddSpecialEffectLocBJ(GetRandomLocInRect(rect1), "Abilities\\Spells\\Undead\\PlagueCloud\\PlagueCloudCaster.mdl")
        set effect1[GetForLoopIndexA()] = GetLastCreatedEffectBJ()
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
    call TimerStart(timer1, 1.00, true, function GreaseActionFunction)
    set timer1 = null
    call TriggerSleepAction((6.00 + (2.00 * I2R(GetUnitLevel(c)))))
    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 20
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        call DestroyEffectBJ(effect1[GetForLoopIndexA()])
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
    call DestroyTimer(timer1)
    call RemoveLocation(t)
endfunction

and the init-trigger:

• Grease Copy 2
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Grease
  • Actions
    • Custom script: call GreaseFunction()

Why doesn't this work..? It's pissing me off :S
It creates the special effects and destroys them, but it doesn't cast the spell on units

 

[Ciebron]

this looks like converted GUI(with locals) not jass

 

[xXMephistoXx]

Some of it is, yes. As said, I'm in the learning process and i'm trying to make it MUI (in jass).

 

[Element of Water]

I think you should properly learn Jass before trying to create MUI spells with it. Besides, that spell isn't MUI yet anyway. For that you'd need to use Local Handle Vars or some more modern vJass attachment system.

 

[xXMephistoXx]

Why is this not MUI..? And one doesn't learn if he doesn't practice.

 

[Element of Water]

Oh sorry, my mistake, I didn't read it through. I just assumed it wouldn't be MUI since you use a timer and no attachment system. Does GetSpellTargetLoc work in timer callbacks anyway?

It's best to practice on more simple things, and get them right.

 

[xXMephistoXx]

Yeah, might be a point. But that was a thing I also was wondering about. Can I use it in a callback, if not, what else could I use..?

 

[Element of Water]

What you could do is attach the point (or better, the x/y) to your timer using an attachment system, and then get the values from your timer in the callback.

 

[Viikuna]

Does GetSpellTargetLoc work in timer callbacks anyway?

Can I use it in a callback, if not, what else could I use..?

I already answered this:

Also, CreaseActionFunction is not gonna work, because you can only use functions like GetTriggerUnit() and GetSpellTargetLoc() in triggeractions and conditions.

You need to use globals. If you want it MUI, you should use global arrays ( or structs ).

 

[xXMephistoXx]

Ah crap.
Thanks for your help guys, +rep

 

[Element of Water]

Is this spell gonna be for the s&s contest? You trying to learn Jass to get an edge over the competition?

 

[xXMephistoXx]

Nope I'm making all the BGII spells in Wc3
Nothing to do with the S&S contest.