Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
18:56, 3rd Dec 2012
Magtheridon96:
IcemanBo: Too long as NeedsFix. Rejected.
18:56, 3rd Dec 2012
Magtheridon96:
- I really wouldn't recommend storing groups or locations into hashtables. It becomes counter-intuitive when deciding whether a certain variable should be manipulated to remove a leak or not.
- I would highly recommend making the special effects and all the other constants you're using inside your spell configurable in that Init trigger so the user wouldn't have to go through all your triggers in order to change one itty-bitty thing.
- In addition to that, currently, it seems that this is hard-coded to function only for a set of unit-types. I'd recommend using a hashtable to allow the user to store data for a new unit-type.
- Check out the Save/Load triggers in this resource. He allows users to set system variables to whatever they want, and then they run a trigger to register their data to the system. (You wouldn't allow them to tamper with your hashtables directly because they could mess it up)
- In your Demonic Duo Condition trigger, you don't need to use location arrays. You can use temporary location variables. In fact, you can make that trigger share the same temporary location variables as your other triggers because Warcraft III is Single threaded, so 2 triggers will never run at the same time. The only time a trigger is interrupted is when you call a Wait action, a TriggerSyncReady()/TriggerSyncStart() action, if you run a trigger, or if you fire an event (like, if you kill a unit, you will interrupt the current trigger, and attempt to run all triggers that have the Death event, then you would continue the execution of your first trigger).