[Trigger] GDD Problem

GangSpear · Sep 3, 2011

I have a problem with GDD(I copied and pasted to my map)
Why this trigger doesn't work?

HA Attack
- Events
  - Game - GDD_Event becomes Equal to 0.00
- Conditions
  - (Level of Haunting Assault for GDD_DamagedUnit) Greater than or equal to 1
- Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - GDD_Damage Greater than or equal to 250.00
    - Then - Actions
      - Set HA_Point = (Position of GDD_DamagedUnit)
      - Unit - Create 1 Dummies for (Owner of GDD_DamagedUnit) at HA_Point facing Default building facing degrees
      - Set HA_Dummy = (Last created unit)
      - Unit - Add BloodLust to (Last created unit)
      - Unit - Add Critical to GDD_DamagedUnit
      - Unit - Set level of BloodLust for (Last created unit) to (Level of Haunting Assault for GDD_DamagedUnit)
      - Unit - Set level of Critical for GDD_DamagedUnit to (Level of Haunting Assault for GDD_DamagedUnit)
      - Unit - Order (Last created unit) to Orc Shaman - Bloodlust GDD_DamagedUnit
      - Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
      - Custom script: call RemoveLocation(udg_HA_Point)
    - Else - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (HA_Dummy is dead) Equal to True
        
        Then - Actions
        
        Unit - Remove Critical from GDD_DamagedUnit
        
        Else - Actions

It just like DotA - Abaddon's Atotic Shield,after taken 250 damage then release somethings,but this is passive skill,after create the dummy then set the GDD_Damage into 0?

Status: Unsolved

Bribe · Sep 3, 2011

It's not MUI. HA_Dummy is just one variable, so it will always point to the
dummy from the very last attack.

GangSpear · Sep 3, 2011

Oh,so i need make an indexing system again?

Bribe · Sep 3, 2011

For almost everything you need an indexing system. I recommend
using Unit Indexer and using DamageEvent if you want the coup de
grace.

GangSpear · Sep 3, 2011

Hmm,i will take a look of your system(Sometimes it error?I can't find out the reason)
Also,this spell doesn't work,what is the problem of it?

Bribe · Sep 3, 2011

What do you mean by "Sometimes it error", are you talking about
my system? What's the error?

GangSpear · Sep 3, 2011

It no more error now,last time i think is me add 1 more words but i forget lol.
Ok,i changed it into this,i copied your unit indexer and damage event.
But it isn't work also,what the...

HA Attack
- Events
  - Game - DamageEvent becomes Equal to 1.00
- Conditions
  - (Level of Haunting Assault for DamageEventTarget) Greater than or equal to 1
- Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - DamageEventAmount Greater than or equal to 250.00
    - Then - Actions
      - Set HA_Point = (Position of DamageEventTarget)
      - Unit - Create 1 Dummies for (Owner of DamageEventTarget) at HA_Point facing Default building facing degrees
      - Set HA_Dummy = (Last created unit)
      - Unit - Add BloodLust to (Last created unit)
      - Unit - Add Critical to DamageEventTarget
      - Unit - Set level of BloodLust for (Last created unit) to (Level of Haunting Assault for DamageEventTarget)
      - Unit - Set level of Critical for DamageEventTarget to (Level of Haunting Assault for DamageEventTarget)
      - Unit - Order (Last created unit) to Orc Shaman - Bloodlust DamageEventTarget
      - Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
      - Custom script: call RemoveLocation(udg_HA_Point)
    - Else - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (HA_Dummy is dead) Equal to True
        
        Then - Actions
        
        Unit - Remove Critical from DamageEventTarget
        
        Else - Actions

How to do MUI O.O

Bannar · Sep 3, 2011

Trigger is good untill it comes to 'Else' then it completely.. yeah ;P

So you want to time the critical strike yes?
In this situation you can either use locals or loop combined with unit group.
>> Level of ability > 0 is enough ;d

Egzample:

HA Attack
- Events
  - Game - DamageEvent becomes Equal to 1.00
- Conditions
  - (Level of Haunting Assault for DamageEventTarget) Greater than 0
- Actions
  - Custom script: local unit u = udg_DamageEventTarget
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - DamageEventAmount Greater than or equal to 250.00
    - Then - Actions
      - Set HA_Point = (Position of DamageEventTarget)
      - Unit - Create 1 Dummies for (Owner of DamageEventTarget) at HA_Point facing Default building facing degrees
      - Unit - Add BloodLust to (Last created unit)
      - Unit - Add Critical to DamageEventTarget
      - Unit - Set level of BloodLust for (Last created unit) to (Level of Haunting Assault for DamageEventTarget)
      - Unit - Set level of Critical for DamageEventTarget to (Level of Haunting Assault for DamageEventTarget)
      - Unit - Order (Last created unit) to Orc Shaman - Bloodlust DamageEventTarget
      - Unit - Add a 0.50 second Generic expiration timer to (Last created unit)
      - Custom script: call RemoveLocation(udg_HA_Point)
      - Wait 2.00 seconds
      - Custom script: call UnitRemoveAbility(u, 'rawdata')
  - Custom script: set u = null

Where 'rawdata' is the id of your critical strike.

Bribe · Sep 3, 2011

HA_Dummy should be an array and indexed.

I advise rather than removing the dummy when HA_Dummy is dead,
just use a periodic trigger that removes the dummy unit/the buff when
the remaining time reaches 0 (to see how this method works in real
time, see the Unit Indexer demo how I use a constantly decreasing
remaining time in the loop trigger and then remove the dummy when
the time is less than or equal to 0: https://www.hiveworkshop.com/forums/spells-569/unit-indexer-spell-template-202003/)

Edit:

Custom script: local unit u = udg_DamageEventTarget

Spinnaker, that's a syntax error, you need to declare locals at the very
top.

Bannar · Sep 3, 2011

Fixed, thanks. Sometimes I forgot that if/then/else in GUI doesn't move into next function. Only the 'if' comparison does.

mckill2009 · Sep 3, 2011

indexing can do this...

after this line >>> Unit - Create 1 Dummies >>> do your normal indexing & remove the
critical strike in another trigger, it shouldnt be so hard...

GangSpear · Sep 3, 2011

Spinnaker said:
Trigger is good untill it comes to 'Else' then it completely.. yeah ;P

So you want to time the critical strike yes?
In this situation you can either use locals or loop combined with unit group.
>> Level of ability > 0 is enough ;d

Egzample:

HA Attack

Events

Game - DamageEvent becomes Equal to 1.00

Conditions

(Level of Haunting Assault for DamageEventTarget) Greater than 0

Actions

Custom script: local unit u = udg_DamageEventTarget

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

DamageEventAmount Greater than or equal to 250.00

Then - Actions

Set HA_Point = (Position of DamageEventTarget)

Unit - Create 1 Dummies for (Owner of DamageEventTarget) at HA_Point facing Default building facing degrees

Unit - Add BloodLust to (Last created unit)

Unit - Add Critical to DamageEventTarget

Unit - Set level of BloodLust for (Last created unit) to (Level of Haunting Assault for DamageEventTarget)

Unit - Set level of Critical for DamageEventTarget to (Level of Haunting Assault for DamageEventTarget)

Unit - Order (Last created unit) to Orc Shaman - Bloodlust DamageEventTarget

Unit - Add a 0.50 second Generic expiration timer to (Last created unit)

Custom script: call RemoveLocation(udg_HA_Point)

Wait 2.00 seconds

Custom script: call UnitRemoveAbility(u, 'rawdata')

Custom script: set u = null

Where 'rawdata' is the id of your critical strike.

Thanks,is that MUI?
and
u = null what is the meaning of it?
EDIT: It still doesn't work.
It doesn't work again wtf?

HA Attack
- Events
  - Game - DamageEvent becomes Equal to 1.00
- Conditions
  - (Level of Haunting Assault for DamageEventTarget) Greater than 0
- Actions
  - Custom script: local unit u = udg_DamageEventTarget
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - DamageEventAmount Greater than or equal to 250.00
    - Then - Actions
      - Set HA_Point = (Position of DamageEventTarget)
      - Unit - Create 1 Dummies for (Owner of DamageEventTarget) at HA_Point facing Default building facing degrees
      - Unit - Add BloodLust to (Last created unit)
      - Unit - Add Critical to DamageEventTarget
      - Unit - Set level of BloodLust for (Last created unit) to (Level of Haunting Assault for DamageEventTarget)
      - Unit - Set level of Critical for DamageEventTarget to (Level of Haunting Assault for DamageEventTarget)
      - Unit - Order (Last created unit) to Orc Shaman - Bloodlust DamageEventTarget
      - Unit - Add a 0.50 second Generic expiration timer to (Last created unit)
      - Custom script: call RemoveLocation(udg_HA_Point)
      - Wait 2.00 seconds
      - Custom script: call UnitRemoveAbility(u,'AOcr')
      - Custom script: set u = null
    - Else - Actions

Bannar · Sep 3, 2011

Locals usage makes it MUI.
Post map, it much be issue within abilities you are using.

GangSpear · Sep 3, 2011

Here you are.
Haunting Assault

Bannar · Sep 3, 2011

You have to learn which data is needed to properly manipulate custom spells.

Custom script: call UnitRemoveAbility(u,'A002')

As you can see I wrote 'A002' instead of 'AOcr'.

Custom ability rawdata usually sticks to same model:
<custom ability id> : <the id of base ability>

Now just note that performing actions with your custom spell is done only if you're refering to the <custom ability id> - the first number.

GangSpear · Sep 3, 2011

Not that problem,is the trigger doesn't work,if taken 250 damage,nothings come out?
(Also,i want it like DotA - Abaddon - Atotic Shield,if many unit attacking storing damage)

GangSpear · Sep 4, 2011

Bump?Someone help please?

Adiktuz · Sep 4, 2011

don't DP...

1)be sure to read the last post of Spinnaker

2)We're not psychics here, if you just say it doesn't work we will have no idea of what exactly doesn't work so please be more specific... Also try to learn to do initial debugging to pinpoint the problematic part...

GangSpear · Sep 4, 2011

This is how the trigger look like...

HA Attack
- Events
  - Game - DamageEvent becomes Equal to 1.00
- Conditions
  - (Level of Haunting Assault for DamageEventTarget) Greater than 0
- Actions
  - Custom script: local unit u = udg_DamageEventTarget
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - DamageEventAmount Greater than or equal to 25.00
    - Then - Actions
      - Set HA_Point = (Position of DamageEventTarget)
      - Unit - Create 1 Dummies for (Owner of DamageEventTarget) at HA_Point facing Default building facing degrees
      - Unit - Add BloodLust to (Last created unit)
      - Unit - Add Critical to DamageEventTarget
      - Unit - Set level of BloodLust for (Last created unit) to (Level of Haunting Assault for DamageEventTarget)
      - Unit - Set level of Critical for DamageEventTarget to (Level of Haunting Assault for DamageEventTarget)
      - Unit - Order (Last created unit) to Orc Shaman - Bloodlust DamageEventTarget
      - Unit - Add a 0.50 second Generic expiration timer to (Last created unit)
      - Custom script: call RemoveLocation(udg_HA_Point)
      - Wait 2.00 seconds
      - Custom script: call UnitRemoveAbility(u,'A002')
      - Custom script: set u = null
    - Else - Actions

Adiktuz · Sep 5, 2011

instead of using an if-then just add that condition to the conditions part, that would also prevent the leak of the unit variable since right now it would cause some leak if that if-then is false...

Now, What exactly does not work? I believe I told you to specify what actually happens...

mckill2009 · Sep 5, 2011

also ifyou dont know spins suggestion, do your normal indexing style...

GangSpear · Sep 5, 2011

Ok,i add some integer into it,this is the trigger,but it won't remove the critical.
Also,if the DamageEventAmount Greater than or equal to 100.00++,it won't work.
Because it need somethings that just 1 hit can deals 100++ damage then it will work...

HA Attack
- Events
  - Game - DamageEvent becomes Equal to 1.00
- Conditions
- Actions
  - Custom script: local unit u = udg_DamageEventTarget
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - DamageEventAmount Greater than or equal to 20.00
      - (Level of Haunting Assault for DamageEventTarget) Greater than 0
    - Then - Actions
      - Set HA_Integer = (HA_Integer + 1)
      - Set HA_Time[HA_Integer] = 0.00
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        HA_Integer Equal to 0
        
        Then - Actions
        
        Trigger - Turn on HA Time <gen>
        
        Else - Actions
      - Set HA_Point = (Position of DamageEventTarget)
      - Unit - Create 1 Dummies for (Owner of DamageEventTarget) at HA_Point facing Default building facing degrees
      - Unit - Add BloodLust to (Last created unit)
      - Unit - Add Critical to DamageEventTarget
      - Unit - Set level of BloodLust for (Last created unit) to (Level of Haunting Assault for DamageEventTarget)
      - Unit - Set level of Critical for DamageEventTarget to (Level of Haunting Assault for DamageEventTarget)
      - Unit - Order (Last created unit) to Orc Shaman - Bloodlust DamageEventTarget
      - Unit - Add a 0.50 second Generic expiration timer to (Last created unit)
      - Custom script: call RemoveLocation(udg_HA_Point)
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        HA_Time[HA_Integer] Greater than or equal to 2.00
        
        Then - Actions
        
        Set HA_Integer = (HA_Integer - 1)
        
        Custom script: call UnitRemoveAbility(u,'A002')
        
        Custom script: set u = null
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        HA_Integer Equal to 0
        
        Then - Actions
        
        Trigger - Turn off HA Time <gen>
        
        Else - Actions
        
        Else - Actions
    - Else - Actions

HA Time
- Events
  - Time - Every 1.00 seconds of game time
- Conditions
- Actions
  - Set HA_Time[HA_Integer] = (HA_Time[HA_Integer] + 1.00)

Adiktuz · Sep 6, 2011

NOOOO, you dont it the other way.... I said remove the if then and just put the conditions on the conditions tab of the trigger...

and put set u = null at the end of the trigger and not inside any if-then...

I still don't understand what part doesn't work... Please specify which part... if you cannot, I suggest putting debug messages to pinpoint the problematic part... If you don't know how to do that, learn...

For the 100++ damage part, if you want it to take effect once the total damage for the last few seconds becomes 100, you need to store the damage already taken by the unit then use the condition

LoadTheSavedDamageAlreadyTakenForTheUnit + DamageEventAmount Greater than or equal to 100.00

Also, your trigger is still not MUI because of that shitty 1 second loop... y? because you only iterate the latest HA_INTEGER on the 1 second loop and not all of them... Also it won't work correctly as it will only remove the ability if ever the unit takes damage because that's the only way that the trigger would fire... so you should put the ability removal into the 1 second timed loop....

Also, you can remove the variable u, its pointless now...

GangSpear · Sep 6, 2011

I don't know how to say,still confusing,can u fix the spell? Here the map ==
Problem Map

mckill2009 · Sep 6, 2011

>>> https://www.hiveworkshop.com/forums/pastebin.php?id=zxesni

GangSpear · Sep 6, 2011

mckill2009 said:
>>> https://www.hiveworkshop.com/forums/pastebin.php?id=zxesni

mckill2009,it really work for u?Why it doesn't work for me?Maybe my world editor have problem?

mckill2009 · Sep 6, 2011

it really works, the critical strike has been removed...idk why it wont work in your end...

GangSpear · Sep 6, 2011

Is that MUI?I tried it,the damage must 1 hit and higher than 50 then it will work,must higher lol...
Many unit attacking caster,the critical keep will remove and add and remove?

[Trigger] GDD Problem

Similar threads