[JASS] Function Redeclared?

[Destroyer95]

When i try to save my map, it reports an error : Function Redeclared.
Here's my script:

globals
      real rangeA
      unit casterA
      location locA
      real damageA
      player ownerA
      string missleA
      real angleA
endglobals

function Missle takes nothing returns nothing
    local unit caster = casterA
    local location loc = locA
    local real damage = damageA
    local real range = rangeA
    local player owner = ownerA
    local real angle = angleA
    local string missle = missleA
    call AddSpecialEffectLoc( missle, loc)
    call DamageUnits( loc, damage, range, owner, caster )
    set loc = PolarProjectionBJ(loc, 10, angle)
endfunction

function Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'zxcv'
endfunction

function Trig_Wave_Actions takes nothing returns nothing
    local timer t = CreateTimer()
    local unit caster = GetSpellAbilityUnit()
    local location casterLoc = GetUnitLoc(caster)
    local real angle = GetUnitFacing(caster)
    local real radius = 50
    local real damage = 25
    local player owner = GetOwningPlayer(caster)
    local string missle = "Abilities\\Spells\\Other\\Doom\\DoomDeath.mdl"
    local location place = GetUnitLoc( GetSpellAbilityUnit() )
    set casterA = caster
    set missleA = missle
    set angleA = angle
    set rangeA = radius
    set damageA = damage
    set ownerA = owner
    set locA = place
    call TimerStart( t, 0.04, true, function Missle)
    call TriggerSleepAction(3)
    call DestroyTimer(t)
    set t = null
    set caster = null
    set casterA = null
    set owner = null
    set ownerA = null
    set casterLoc = null
    set place = null
    set locA = null
endfunction

//===========================================================================
function InitTrig_Wave takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerAddCondition( t, Condition ( function Conditions ) )
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddAction( t, function Trig_Wave_Actions )
endfunction

I know its messy and noobish, and can be done in a much better way but i started jass not a long time ago, so im still learning.
It says that function Conditions is redeclared.

Can someone help me?

 

[Element of Water]

Try renaming it to Trig_Wave_Conditions.

 

[Destroyer95]

Thx it works now...forgot i made another trigger with Conditions xD
Wow, i made a monster! It just spawns 1000 effects at one place and laggs like hell xD

 

[Element of Water]

Thx it works now...forgot i made another trigger with Conditions xD
Wow, i made a monster! It just spawns 1000 effects at one place and laggs like hell xD

Yeah... you seriously need to read some Jass spellmaking tutorials.

 

[Ciebron]

scope it

like this

scope NAME initializer init //(initializer is better then init_trig)

globals
      private real rangeA
      private  unit casterA
      private location locA
      private real damageA
      private player ownerA
      private string missleA
      private real angleA
endglobals

private function Missle takes nothing returns nothing
    local unit caster = casterA
    local location loc = locA
    local real damage = damageA
    local real range = rangeA
    local player owner = ownerA
    local real angle = angleA
    local string missle = missleA
    call AddSpecialEffectLoc( missle, loc)
    call DamageUnits( loc, damage, range, owner, caster )
    set loc = PolarProjectionBJ(loc, 10, angle)
endfunction

private function Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'zxcv'
endfunction

private function Trig_Wave_Actions takes nothing returns nothing
    local timer t = CreateTimer()
    local unit caster = GetSpellAbilityUnit()
    local location casterLoc = GetUnitLoc(caster)
    local real angle = GetUnitFacing(caster)
    local real radius = 50
    local real damage = 25
    local player owner = GetOwningPlayer(caster)
    local string missle = "Abilities\\Spells\\Other\\Doom\\DoomDeath.mdl"
    local location place = GetUnitLoc( GetSpellAbilityUnit() )
    set casterA = caster
    set missleA = missle
    set angleA = angle
    set rangeA = radius
    set damageA = damage
    set ownerA = owner
    set locA = place
    call TimerStart( t, 0.04, true, function Missle)
    call TriggerSleepAction(3)
call DestroyTimer(t)
    set t = null
    set caster = null
    set casterA = null
    set owner = null
    set ownerA = null
    set casterLoc = null
    set place = null
    set locA = null
endfunction

//===========================================================================
private function init takes nothing returns nothing
    local trigger t = CreateTrigger( )
    call TriggerAddCondition( t, Condition ( function Conditions ) )
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddAction( t, function Trig_Wave_Actions )
endfunction

endscope

Using private members inside a scope/library will add the scopes/librarys name infront of the name of the member

eg.

private real REAL will be real _s_"SCOPE_NAME"_REAL and public real REAL will be real "SCOPE_NAME"_REAL
this means u dont have too worry about names outside the scope/library

also why dont you use structs? it can make any spell MUI easy

 

[Element of Water]

I think the reason he doesn't use structs is he doesn't know how. Let him learn. And BTW you are wrong about the private thing. private real REAL will become real SCOPE_NAME<Random number of underscores>REAL. The s_NAME thing is with struct member arrays.

 

[Ciebron]

your right _s_ is struct members and private globals is SCOPE_NAME___NAME

 

[Element of Water]

Except it has a random number of underscores between the sope name and the variable name.