First hero being free (no gold)

[Bond009]

So as we all know im sure, this trigger line creates starting units depending on race..

• Melee Game - Create starting units (for all players)

but it also sets it so that the first hero you train OR get from the tavern is free.
I need that feature but i do not want it to auto create starting units based on the race along with it..
Any ideas

 

[Drazhar]

Maybe

• Remove Peons
  • Events
    • Map initialization
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Race of Player 1 (Red)) Equal to Undead
      • Then - Actions
        • Unit Group - Pick every unit in (Units owned by Player 1 (Red) matching ((Unit-type of (Picked unit)) Equal to Acolyte)) and do (Unit - Remove (Picked unit) from the game)
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Race of Player 1 (Red)) Equal to Night Elf
          • Then - Actions
            • Unit Group - Pick every unit in (Units owned by Player 1 (Red) matching ((Unit-type of (Picked unit)) Equal to Wisp)) and do (Unit - Remove (Picked unit) from the game)
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Race of Player 1 (Red)) Equal to Human
              • Then - Actions
                • Unit Group - Pick every unit in (Units owned by Player 1 (Red) matching ((Unit-type of (Picked unit)) Equal to Peasant)) and do (Unit - Remove (Picked unit) from the game)
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Race of Player 1 (Red)) Equal to Orc
                  • Then - Actions
                    • Unit Group - Pick every unit in (Units owned by Player 1 (Red) matching ((Unit-type of (Picked unit)) Equal to Peon)) and do (Unit - Remove (Picked unit) from the game)
                  • Else - Actions

Probably not the most graceful method but could be refined or improved to fit your needs? Not sure if you wanted the townhall gone too, but you could just add that in

 

[Pharaoh_]

• Test
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (Playable map area) matching ((((Matching unit) is A town-hall-type unit) Equal to True) or (((Matching unit) is A peon-type unit) Equal to True))) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Owner of (Picked unit)) controller) Equal to User
          • Then - Actions
            • Unit - Kill (Picked unit)
            • Unit - Remove (Picked unit) from the game
          • Else - Actions

 

[Bond009]

cool Pharaoh_ i've been meaning to ask you this anyway, why is it that you kill the unit before removing it? i remember hearing somewhere that it can cause leak or errors of some sort? but no idea what, or if thats even true?

 

[Pharaoh_]

Yes, it is true. It's known for some years now :]
Triggers can't refer to removed units, but the leak of that unit's existence will be there.

 

[Bond009]

but what if that unit that was removed is never refereed to by a trigger ever again, is it still a bad thing? or no
also is it that case for every situation? a unit must always be killed before being removed no matter what?
do you know what it does exactly, if its not done that way?

 

[Pharaoh_]

Hm, it doesn't have to be a trigger's reference to leak or not. A unit is an object, it will leak upon creation. This is why 400 units on the map will create lag, even if no trigger refers to them; because one unit's creation won't make a noticeable difference, but a mass of them will eventually create that lag.

 

[Bond009]

is there a way to create units without making that lag? theres no way to remove unit creation leaks is there..
so does it leak upon unit removal also then? is that why it needs to be killed first, i assume blizzard takes care of units when killed but not when just removed while still alive via triggers..? which doesnt make much sense lol

guess ill have to go through all my stuff now and make sure i dont ever remove a unit before killing it.. :/

 

[Pharaoh_]

Dr Super Good says it's a bug, I do not know what's really wrong with it, so I'll trust his opinion.

 

[Dr Super Good]

Apparently someone did some research and found that the remove unit native does not properly free up memory resulting in a permant leak. Making the unit explode and then killing it however does seem to free up memory as the automatic unit death removal seems to work fine.

I did not find this out, I am purly going by the findings of what someone else posted.

 

[Bond009]

So doesnt making the unit explode auto make it 'killed' then right.

so after making it explode then insta remove it after and in turn there would then be no memory leaking?

also would there be a leak with removing heros from the game also? would u need to kill the hero then remove it?

 

[Dr Super Good]

Removing heroes leaks and there is no fix for that as far as I know.

Exploding a unit (set explode flag and then killing it) instantly removes it. Killing it alone should suffice but there would be a delay. Removing it is not nescescary this way.

 

[Bond009]

i assume your not talking about

• Unit - Explode (Triggering unit)
• Unit - Kill (Triggering unit)

im not sure of what this 'setting explode flag' and then killing is via trigger

 

[Pharaoh_]

Dr Super Good talks in Jass, so "flag" is the boolean part of the

call SetUnitExploded (GetTriggerUnit(), true)

the true/false is the flag.

 

[Bond009]

so would need to do something like this?

• Custom script: call SetUnitExploded (GetTriggerUnit(), true)
• Unit - Kill (Triggering unit)

then no leaks? lol

 

[Pharaoh_]

You don't specifically need jass for this, if you are not using scripts in the trigger. Unit - Explode (Triggering unit) is fine (it's Jass counterpart is a BJ, which automatically uses the KillUnit() function). Use Unit - Remove (Triggering unit) after this line.

 

[Bond009]

k so then give an example so im perfectly clear lol then this is what u mean

• Unit - Explode (Triggering unit)
• Unit - remove (Triggering unit) from game

 

[defskull]

Or you can hide it first, THEN kill the unit, works the same way (only, it hides the death animation of that unit)