Fire of fenix 02

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

This actually looks like a decent spell.

But:

• Requires an in-game screenshot
• Requires proper description
• Use English
• Requires importing instructions
• Get rid of the bj's that call a native function. These include but are not limited to UnitApplyTimedLifeBJ, StartTimerBJ and CreateNUnitsAtLoc.
• The coding needs improvements here and there.
• Abilities must support levels

 

[The_beast_of_doom]

I tested it and it seems to work well and is mui however the test map seems a little chaotic and the spells do not upgrade, also please post your triggers and post the translation.

A fire burming of only 3 lines
dur = 9 sec
damage = 15.5. per sec
lvl 1
Effects of fire

 

[Bio BlizarD]

sorry do not speak English

 

[The_beast_of_doom]

Lo he comprobado y parece que funciona bien y es mui sin embargo, el mapa de la prueba parece un poco caótico y los hechizos no se actualiza, también por favor deja tu mensaje y activa la traducción.

 

[Bio BlizarD]

ah ok ,In my next post I Translates in English

 

[xIceShotx]

A fire burning in only 3 lines
dur = 9 sec
damage = 15.5. per sec
lvl 1
Effects of fire.
Is that what you meant to say in your description? btw, please post triggers in description

 

[Bio BlizarD]

say GG http://www.hiveworkshop.com/forums/images_all/editor/color.gif

 

[mateuspv]

*** correct me if I'm wrong ***
Tip for translations:
http://www.reverso.net
use: [ jass] [ /jass] to post codes

-if you converted GUI for Jass without transforming functionsBJ in native knows that that doesn't change in anything

Look:

function Trig_init_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A000' ) ) then
        return false
    endif
    return true
endfunction

can be replaced by

function Trig_init_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'A000'
endfunction

-
Look

call UnitApplyTimedLifeBJ( udg_clawduration, 'BTLF', GetLastCreatedUnit() )

Bj that refers to:

call UnitApplyTimedLife(whichUnit, buffId, duration)

getting:

call UnitApplyTimedLife(bj_lastCreatedUnit, 'BTLF', udg_clawduration)

-

function InitTrig_init takes nothing returns nothing
    set gg_trg_init = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_init, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_init, Condition( function Trig_init_Conditions ) )
    call TriggerAddAction( gg_trg_init, function Trig_init_Actions )
endfunction

function InitTrig_init takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( t, Condition( function Trig_init_Conditions ) )
    call TriggerAddAction( t, function Trig_init_Actions )
    set t = null
endfunction

-

GetLastCreatedUnit

instead use

bj_lastCreatedUnit

and have more things, I'll look for some tutorials if you want I leave to you

 

[Magtheridon96]

^ If he isn't using the CreateNUnits BJ, using bj_lastCreatedUnit won't work.
bj_lastCreatedUnit only works if you're using that BJ because that BJ creates the unit and sets bj_lastCreatedUnit to it.

Use a local unit variable to store the unit you're going to create.

Or better yet, just leave this in GUI.

edit

And for future reference:
fenix -> phoenix

 

[SpectreD]

it seems to me that u have spelt phoenix wrong ^^, or was this done on purpose...