[JASS] Filters leak?

[Ciebron]

im petty sure it do but ill ask just to be sure

do this leak?

function MPick_Conds takes nothing returns boolean
    local timer Mtimer
    local unit c
    set Mtimer = GetExpiredTimer()
    set c = GetHandleUnit(Mtimer,"c")
    return GetWidgetLife(GetFilterUnit()) > .405 and not IsUnitType(GetFilterUnit(),UNIT_TYPE_STRUCTURE) and IsUnitEnemy(GetFilterUnit(),GetOwningPlayer(c))
endfunction

and the "caller"

call GroupEnumUnitsInRange(g,nx,ny,300,Filter(function MPick_Conds))

its a bitch since a cant

set c = null

 

[Drone]

im petty sure it do but ill ask just to be sure

do this leak?

function MPick_Conds takes nothing returns boolean
    local timer Mtimer
    local unit c
    set Mtimer = GetExpiredTimer()
    set c = GetHandleUnit(Mtimer,"c")
    return GetWidgetLife(GetFilterUnit()) > .405 and not IsUnitType(GetFilterUnit(),UNIT_TYPE_STRUCTURE) and IsUnitEnemy(GetFilterUnit(),GetOwningPlayer(c))
endfunction

and the "caller"

call GroupEnumUnitsInRange(g,nx,ny,300,Filter(function MPick_Conds))

its a bitch since a cant

set c = null

function MPick_Conds takes nothing returns boolean
    return GetWidgetLife(GetFilterUnit()) > .405 and not IsUnitType(GetFilterUnit(),UNIT_TYPE_STRUCTURE) and IsUnitEnemy(GetFilterUnit(),GetOwningPlayer(GetHandleUnit(GetExpiredTimer(),"c")))
endfunction

The filter doesn't need to be destroyed if you use it more than once. Everytime you call Filter with the same func, it'll return a handle to the same filter object. If however you use a local filter type handle, then you need to null the filter type handle at the end of the function. It's not logical, but that's because of a stupid programming error, where references are not decremented when a local goes out of scope. The nulling though is only important if you have to destroy the filter at one point where it isn't needed anymore.

The reason this does not leak is because you're passing the arguments by value and not by reference.

 

[Ciebron]

oh didnt think of that thanks alot! <3

 

[DiscipleOfLife]

Your local timer and unit leak, but there is an easy fix:

function MPick_Conds takes nothing returns boolean
    return GetWidgetLife(GetFilterUnit()) > .405 and not IsUnitType(GetFilterUnit(),UNIT_TYPE_STRUCTURE) and IsUnitEnemy(GetFilterUnit(),GetOwningPlayer(GetHandleUnit(GetExpiredTimer(),"c")))
endfunction

Though I don't know if GetExpiredTimer works in a filter function

 

[Need_O2]

globals
filterfunc f

function blabla_InitTrig ....
set f = Filter(function halelelujah)

and use f in your triggers

 

[PurplePoot]

Unless you desperately need speed, there's really no reason to use a global, Need_O2.

---

And(), Or(), and Not() boolexprs apparently leak, but not Filter() or Condition() ones.

 

[Drone]

Though I don't know if GetExpiredTimer works in a filter function

Works fine, provided you do the enumeration with a filter in the timer callback function, or in the actions of a timer expire event.

 

[Need_O2]

Vexorian said null as filter leaks I always use a global due to speed and make sure
but I trust Poot more than Vexorian, his words are truths for me

 

[Troll-Brain]

Vexorian said null as filter leaks I always use a global due to speed and make sure
but I trust Poot more than Vexorian, his words are truths for me

you can test yourself if you doubt about something, especially about leaks.
you only need to do it on a short timer and check the memory using for the process war3, if it increase, then it leak

 

[Need_O2]

I know but Im too lazy for that :/

 

[PurplePoot]

The null filter leak with global groups was actually discovered by grim001, if my memory serves .