Filter just # unit...

[mckill2009]

Hi, Just like in GUI...I would like to pick random # unit in range of unit...

how to do that in JASS properly?...coz I've used this one...

call GroupEnumUnitsInRange(GetRandomSubGroup(1, bj_lastCreatedGroup), GetUnitX(udg_LC_Cloud), GetUnitY(udg_LC_Cloud), 700, Filter(function Filterthem))

 

[Garfield1337]

You can use

local unit u
local group g = GroupEnumUnitsInRange(g,x,y,radius,filter)
set u = FirstOfGroup(g)
call DestroyGroup(g)

If you don't think FirstOfGroup() is reliable, you can make your own randomizer:
-Add all units from a group to a unit array, set an integer's value to a random value between 1 and number of units in group and return the unit from unit array with random integer as index.
-Filter through units in range, if filter unit's type equals to wanted type then give it a chance to be the randomized unit. If unit amount hits 1, return the last unit.

 

[mckill2009]

well actually, the example I've given works...but is there another way of doing it?...
I tried FirstOfGroup but it seems its not working well...

I think GetRandomSubGroup is some sort of a formula which contains CreateGroup already...

 

[Garfield1337]

GetRandomUnitFromGroup action in GUI is pretty much overcomplicated version of FirstOfGroup.
The GetRandomSubGroup is based off my second suggestion for a randomizer

-Filter through units in range, if filter unit's type equals to wanted type then give it a chance to be the randomized unit. If unit amount hits 1, return the last unit.

You can see this if you open JASSCraft and look for that BJ.

 

[mckill2009]

Yes I already done that GetRandomSubGroup thing, look post #1 and it worked, what
Im asking is is there other ways to get random units (maybe 1 or 2 etc..., or just 1)in a group without using that method?...

Actually the GetRandomUnitFromGroup is ForGroupBJ which is too complicated...

 

[Adiktuz]

//udg_GroupMax is an integer and should always start with the value zero

function Filterthem takes nothing returns boolean
   if udg_GroupMax <= max number of units for the group then
      set udg_GroupMax = udg_GroupMax + 1
      return true
  endif
  //Now it will only add the units into the group if the group hasn't reached the
  //amount that you want
  return false
endfunction

function Main takes nothing returns nothing
    set udg_GroupMax = 0
    call GroupEnumUnitsInRange(udg_TempGroup, GetUnitX(udg_LC_Cloud), GetUnitY(udg_LC_Cloud), 700, Filter(function Filterthem))
endfunction

 

[mckill2009]

So GroupEnumUnitsInRange takes dummy group which is udg_TempGroup and filters them...now since the Enum will pick all units within 700 of XY, then that's why there is GroupMax coz the first unit it picked will be the one who will get lightning cast...hmmm...interesting...

Im testing it with this...and it worked!

function Filterthem takes nothing returns boolean
    local unit u = GetFilterUnit()
    if udg_LC_GroupMax <=0 then
      set udg_LC_GroupMax = udg_LC_GroupMax + 1
      //call IssueTargetOrder(udg_LC_Cloud, "chainlightning", u) 
      call KillUnit(u)
    endif
    set u = null
endfunction

 

[Garfield1337]

That's what FirstOfGroup is doing; getting the first unit in group.

 

[Adiktuz]

yeah, but 1 less FC...

you could also add a randomization filter (GetRandomInt(1,100) < something) to the function if you want to really randomize the units (meaning the group could have anything berween 0 to the max number of members)

remove the local, it actually makes it less optimized since you only used the unit once (since the other one is commented)