[Trigger] Editor or Triggers fucked up?

[doom_sheep]

I tried to make some simple spells but they just dont seem to work. when i try to pick units in an area i just get one, the rest are unaffected. I have checked the triggers and they seem fine.

• Actions
  • Unit Group - Pick every unit in (Units within 225.00 of (Target point of ability being cast)) and do (Actions)
    • Loop - Actions
      • Unit - Cause (Casting unit) to damage (Picked unit), dealing 30.00 damage of attack type Spells and damage type Normal
      • Unit - Create 1 Dummy Water Elemental for (Owner of (Casting unit)) at (Position of (Casting unit)) facing (Position of (Picked unit))
      • Unit - Add Pushback Dummyspel to (Last created unit)
      • Unit - Order (Last created unit) to Human Blood Mage - Banish (Picked unit)
      • Set Spell__Number = (Spell__Number + 1)
      • Set Pushback_Target[Spell__Number] = (Picked unit)
      • Unit - Set the custom value of (Last created unit) to Spell__Number
      • Unit Group - Add (Last created unit) to PushGroup
      • Unit - Add a 1.10 second Generic expiration timer to (Last created unit)

(theres another trigger that moves the units. it moves the banished one successfully.)

theres another spell that randomly fails to pick units. this has happened before aswell with other maps. it seems to have something to do with large arrays, or maybe not.

i have never heard of anyone else having this problem. is it possible that my editor is somehow fucked? how to fix that?

i attached the map. hopefully some of you can be arsed to look at it.

 

[reason 3]

No,its not your editor...your trigger is in-accurate.My advice would be to use more variables and fix leaks.

 

[doom_sheep]

as far as i know, triggers should work fine whether i have fixed leaks or not.

 

[reason 3]

Give me some time,i will send you a better version of your spell...

 

[doom_sheep]

i don't need a better version of the spell, i need to know what the problem is. or if the problem is in the triggers at all.

 

[VergilThazaar]

No,its not your editor...your trigger is in-accurate.My advice would be to use more variables and fix leaks.

I agree with reason, I had a similar case myself and by setting the "Casting Unit" into a variable fixed it!

 

[reason 3]

Something like this would be better...i'm too tired at the moment to test and fix the whole spell but i think you will get my point...

• Pushback 1
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to XX
  • Actions
    • Set Caster = (Casting unit)
    • Set CasterPoint = (Position of Caster)
    • Set Target = (Target unit of ability being cast)
    • Set TargetPoint = (Position of Target)
    • Set Temp_Group_1 = (Units within 225.00 of TargetPoint)
    • Unit Group - Pick every unit in Temp_Group_1 and do (Actions)
      • Loop - Actions
        • Unit - Cause Caster to damage (Picked unit), dealing 30.00 damage of attack type Spells and damage type Normal
        • Unit - Create 1 for (Owner of Caster) at (Position of Caster) facing (Position of (Picked unit))
        • Unit - Add Released Sword to (Last created unit)
        • Unit - Order (Last created unit) to Human Blood Mage - Banish (Picked unit)
        • Set Spell__Number = (Spell__Number + 1)
        • Set Pushback_Target[Spell__Number] = (Picked unit)
        • Unit - Set the custom value of (Last created unit) to Spell__Number
        • Unit Group - Add (Last created unit) to PushGroup
        • Unit - Add a 1.10 second Generic expiration timer to (Last created unit)

Also,i didn't change the last part cause i didn't know the reason you used the last variables.
P.S. Fix leaks...i didn't.

 

[doom_sheep]

i dont think thats gonna help. last time the bug happened i was using variables and fixing leaks. its something else.

 

[reason 3]

Trust me and give it a try...

 

[doom_sheep]

ill try it tomorrow.

 

[En_Fuego]

Don't use 'Casting Unit' when making spells target multiples. Use 'Triggering Unit' or a variable.

 

[Maker]

Are you modifying the custom value of last created unit on purpose? And you add last created unit to pushback group?

I did some modifications to your ability:

EDIT: Link removed.

(The cooldown of the ability is 3 seconds, and HP regeneration of the unit has been modified also)

I changed the "last created unit" to picked unit. I set the time interval on the pushback trigger from 0.06 to 0.03 so it looks smoother. I set the pushback trigger to be initially off, it turns on/off when needed so it's not running all the time. I gave the unit a maximum range of 300 to get pushed back. That's easy to change. I removed leaks.

Still there's some weird things going on. The caster can damage himself and allies, structures can be pushed back. Using facing angle of a unit as the pushback direction isn't the best idea.

 

[doom_sheep]

thanks but thats not exactly what the spell was supposed to do. because i don't know how paladons leet systems work i make stuff MUI by creating a dummy unit group and storing all values with their custom value. (or hit points and facing angle if im lazy)

then i pick them, find the unit the spell is supposed to affect and do the effects on him. your spell moves the units to his own facing angle instead of the dummy unit's.

whatever, have a rep.

 

[Maker]

then i pick them, find the unit the spell is supposed to affect and do the effects on him. your spell moves the units to his own facing angle instead of the dummy unit's.

Well, that was easy to fix:

http://www.hiveworkshop.com/forums/pastebin.php?id=jevqn7

 

[doom_sheep]

thanks. could you also take a look at the freeze spell? changing the casting unit to triggering unit didnt work.

http://www.hiveworkshop.com/forums/pastebin.php?id=hcobvk

i edited it a bit so it doesnt affect allies and stuff.

 

[VergilThazaar]

No,its not your editor...your trigger is in-accurate.My advice would be to use more variables and fix leaks.

I agree with reason, I had a similar case myself and by setting the "Casting Unit" into a variable fixed it!

So, reason 3 and I helped you, revealed the solution but you wanted to get the solution from Maker? We answered your question and you ignored us... suspicious... or just too damn lazy?

 

[Maker]

No offence, but there was a lot more to it than what you or reason 3 suggested.

 

[VergilThazaar]

True, but these things were NOT the request, since we DID answer the request first and correct, that's just one of the things that make me give up "helping"...

 

[Maker]

I tried your solution and it didn't fix the issue.

 

[VergilThazaar]

...and what was the problem? How did you fix it?

 

[doom_sheep]

can u help with the other spell? i will give +rep ofc but i really need help on that.

 

[Maker]

thanks. could you also take a look at the freeze spell? changing the casting unit to triggering unit didnt work.

It should work now. I also removed the leaks

BTW, why did you include that indexing stuff in the Repel ability's pushback trigger? It isn't needed, since hahtables are used.

http://www.hiveworkshop.com/forums/pastebin.php?id=jevqn7

Also, where does the name of the map come from? It sounds like it's Finnish

 

[doom_sheep]

It should work now. I also removed the leaks

BTW, why did you include that indexing stuff in the Repel ability's pushback trigger? It isn't needed, since hahtables are used.

because i have no idea how hashtables work o_o

Also, where does the name of the map come from? It sounds like it's Finnish

correct. its a finnish meme.

http://www.youtube.com/watch?v=VRCy1vPLAYw

 

[Maker]

Well, I took out the indexing stuff.

http://www.youtube.com/watch?v=VRCy1vPLAYw

"Taneli on appelsiini"

 

[Yixx]

So, reason 3 and I helped you, revealed the solution but you wanted to get the solution from Maker? We answered your question and you ignored us... suspicious... or just too damn lazy?

Oh boo hoo,, you want a special thanks for your BIG help? You want everybody to clap for you? You want credits in the map or whatever?
Damn let a guy choose for himself, that you got A solution doesnt mean it is the solution HE wants.
He is the guy that chooses who he wants him to help, so dont be such a crybaby for a compliment.

Ignore this post please, i just hate crybabys.

 

[Maker]

...and what was the problem? How did you fix it?

He used some weird way of adding the dummy to the group. I changed the system to use a hashtable.