Does trigger with Experience can create leaks

[Banti]

Does this trigger can create memory leaks

Hero - Add 1500 experience to Necromancer 0470 <gen>, Hide level-up graphics

Hero - Add 1500 experience to Paladin 0470 <gen>, Hide level-up graphics

Hero - Add 1500 experience to Archer 0470 <gen>, Hide level-up graphics

 

[Doomlord]

Nah. They don't leak

http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/

 

[jonhysone]

Since they create no Special Effect , No location , No Unit group , then they don't leak

 

[Banti]

I think that something leak but I don't know what. I think that that something have to do with the quests because when I do them it create memory leaks. Does that trigger can leak

• Elder Tree reward
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
    • ((Triggering unit) is A Hero) Equal to True
    • (elder tree quest <gen> contains (Triggering unit)) Equal to True
    • (Ability being cast) Equal to Action
    • (ElderTreeQuest[20] is enabled) Equal to True
    • ((Triggering unit) has an item of type |cffffcc00Stone of Live) Equal to True
    • ((Triggering unit) has an item of type Healing Salve) Equal to True
    • ((Triggering unit) has an item of type Clarity Potion) Equal to True
    • ((Triggering unit) has an item of type |cffffcc00Thunder Lizard Egg) Equal to True
  • Actions
    • Environment - Set sky to Generic Sky
    • Camera - Apply ElderTree ritual <gen> for Player 7 (Green) over 0.00 seconds
    • Cinematic - Turn cinematic mode On for (All players)
    • Cinematic - Send transmission to (All players) from (Triggering unit) named The Hero: Play No sound and display I have all of the i.... Modify duration: Add 5.00 seconds and Don't wait
    • Wait 5.00 seconds
    • Cinematic - Send transmission to (All players) from Elder Druid (Night Elf Form) 0130 <gen> named Elder Druid: Play No sound and display Thank you. Now I ca.... Modify duration: Add 5.00 seconds and Don't wait
    • Wait 5.00 seconds
    • Cinematic - Send transmission to (All players) from Elder Druid (Night Elf Form) 0130 <gen> named Elder Druid: Play No sound and display I summon you Mother.... Modify duration: Add 5.00 seconds and Don't wait
    • Wait 5.00 seconds
    • Camera - Apply ElderTree ritual <gen> for Player 7 (Green) over 0.00 seconds
    • Unit - Make Elder Druid (Night Elf Form) 0130 <gen> face (Center of Elder Tree <gen>) over 0.10 seconds
    • Wait 1.00 seconds
    • Animation - Play Elder Druid (Night Elf Form) 0130 <gen>'s spell animation
    • Environment - Create at Elder Tree Copy <gen> the weather effect Dalaran Shield
    • Set Elder_Tree_Restore = (Last created weather effect)
    • Environment - Turn Elder_Tree_Restore On
    • Animation - Play Resurrection Stone 2 0587 <gen>'s stand alternate animation
    • Animation - Play Resurrection Stone 1 0511 <gen>'s stand alternate animation
    • Animation - Play Resurrection Stone 1 1050 <gen>'s stand alternate animation
    • Animation - Play Resurrection Stone 2 1064 <gen>'s stand alternate animation
    • Wait 2.50 seconds
    • Environment - Remove Elder_Tree_Restore
    • Animation - Play Elder Druid (Night Elf Form) 0130 <gen>'s stand animation
    • Unit - Make Elder Druid (Night Elf Form) 0130 <gen> face (Center of po rytuale <gen>) over 0.10 seconds
    • Wait 0.10 seconds
    • Cinematic - Send transmission to (All players) from Elder Druid (Night Elf Form) 0130 <gen> named Elder Druid: Play No sound and display Elder Tree has been.... Modify duration: Add 8.00 seconds and Don't wait
    • Wait 2.00 seconds
    • Animation - Play Elder Druid (Night Elf Form) 0130 <gen>'s spell animation
    • Hero - Create Druids Blessings and give it to Berserker 0470 <gen>
    • Hero - Create Druids Blessings and give it to Sentry 0653 <gen>
    • Hero - Create Druids Blessings and give it to Sylvanas 1397 <gen>
    • Wait 2.00 seconds
    • Animation - Play Elder Druid (Night Elf Form) 0130 <gen>'s stand animation
    • Wait 4.00 seconds
    • Cinematic - Send transmission to (All players) from Elder Druid (Night Elf Form) 0130 <gen> named Elder Druid: Play No sound and display From now you will b.... Modify duration: Add 7.00 seconds and Don't wait
    • Wait 7.00 seconds
    • Cinematic - Turn cinematic mode Off for (All players)
    • Camera - Reset camera for Player 7 (Green) to standard game-view over 0.05 seconds
    • Sound - Stop the currently playing music theme
    • Sound - Play Sound\Music\mp3Music\War2IntroMusic.mp3
    • Item - Remove (Item carried by (Triggering unit) of type Healing Salve)
    • Item - Remove (Item carried by (Triggering unit) of type Clarity Potion)
    • Item - Remove (Item carried by (Triggering unit) of type |cffffcc00Stone of Live)
    • Item - Remove (Item carried by (Triggering unit) of type |cffffcc00Thunder Lizard Egg)
    • Sound - Play ItemReceived <gen>
    • Hero - Add 2000 experience to Berserker 0470 <gen>, Hide level-up graphics
    • Hero - Add 2000 experience to Sentry 0653 <gen>, Hide level-up graphics
    • Hero - Add 2000 experience to Sylvanas 1397 <gen>, Hide level-up graphics
    • Game - Display to Player Group - Player 7 (Green) the text: |cffffcc00Hit point...
    • Special Effect - Destroy ElderDruidEffect[50]
    • Quest - Change the description of ElderTreeQuest[20] to Elder Tree is resto...
    • Quest - Mark ElderTreeQuest[20] as Completed
    • Sound - Play QuestCompleted <gen>
    • Quest - Flash the quest dialog button
    • Environment - Set sky to None
    • Wait 2.00 seconds
    • Floating Text - Destroy (Last created floating text)
    • Sound - Stop ItemReceived <gen> Immediately
    • Sound - Stop QuestCompleted <gen> Immediately
    • Custom script: call DestroyTrigger(GetTriggeringTrigger())

 

[Kusanagi Kuro]

Dont use wait. Instead, disable the permanent of the floating text. Then set it life span to the value u want.
And yes, there is Location Leaks in ur trigger.
Also, anything u use twice or more should be placed into an variable (thks deathismyfriend cuz he always remind me about this ).

 

[deathismyfriend]

Also use trigger tags to post triggers. It's very hard to read the triggers like that.

You should look at my tutorial things a GUIer should know.
Look at the chapter on waits. A lot of the other stuff in there can help you also.

 

[Banti]

In that case I think I have some triggers that leaks. Does is any chance that someone can check my map and correct my triggers. I am sorry about trigger tags I don't know how to post them properly

 

[deathismyfriend]

Clickthe go advanced button then Click the trigger tags option. Then post your triggers between the trigger tags here are trigger tags. [trigger]post text here[/trigger]

If you post your map I will try to check it later. It will be a while till I can check it.

 

[Banti]

Does that trigger can create leaks as well (with trigger tags looks much better thank you for help with posting them)

• Rain
  • Events
    • Time - Every 2600.00 seconds of game time
  • Conditions
  • Actions
    • Environment - Remove (Last created weather effect)
    • Environment - Create at (Playable map area) the weather effect Ashenvale Rain (Light)
    • Environment - Turn (Last created weather effect) On
    • Wait 520.00 seconds
    • Environment - Remove (Last created weather effect)

 

[deathismyfriend]

Neither of them look like they leak but I am on my phone so I'm not sure if I missed anything. Also waits are a bad idea. Look at my tutorial for more info on waits.

 

[Banti]

In which part of that trigger is location leak

 

[Daffa]

• Unit - Make Elder Druid (Night Elf Form) 0130 <gen> face (Center of Elder Tree <gen>) over 0.10 seconds

• Unit - Make Elder Druid (Night Elf Form) 0130 <gen> face (Center of po rytuale <gen>) over 0.10 seconds

Both Locations Leaks

 

[Banti]

Thank you for pointing those leaks. I need to correct them and deal with waits

 

[Banti]

Does this trigger might leak

• Spider Eggs
  • Events
    • Destructible - Egg Sack 6986 <gen> dies
  • Conditions
  • Actions
    • Set Temp_Point = (Position of Egg Sack 6986 <gen>)
    • Unit - Create 1 Spider for Neutral Hostile at Temp_Point facing (Position of (Triggering unit))
    • Custom script: call RemoveLocation (udg_Temp_Point)
    • Custom script: call DestroyTrigger(GetTriggeringTrigger())

 

[Rheiko]

yes it is

• Unit - Create 1 Spider for Neutral Hostile at Temp_Point facing (Position of (Triggering unit))

it should be facing Temp_Point
and also, why you want to destroy the trigger anyway?

 

[Banti]

Thank you now I know what is wrong. I destroyed it because is used just once

 

[Rheiko]

i see, good then