[Trigger] Does this trigger make sense?

[HelloFlighty]

• Selecting strafing unit
  • Events
    • Player - Player 1 (Red) Selects a unit
    • Player - Player 2 (Blue) Selects a unit
    • Player - Player 3 (Teal) Selects a unit
    • Player - Player 4 (Purple) Selects a unit
    • Player - Player 5 (Yellow) Selects a unit
    • Player - Player 6 (Orange) Selects a unit
    • Player - Player 7 (Green) Selects a unit
    • Player - Player 8 (Pink) Selects a unit
    • Player - Player 9 (Gray) Selects a unit
    • Player - Player 10 (Light Blue) Selects a unit
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Owner of (Triggering unit)) Equal to (Owner of (Triggering unit))
      • Then - Actions
        • Set GroupSelect = (Units currently selected by (Owner of (Triggering unit)))
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • (Number of units in GroupSelect) Equal to 1
            • Then - Actions
              • Set StrafingUnit = (Triggering unit)
            • Else - Actions
              • Set StrafingUnit = No unit
              • Custom script: call DestroyGroup( udg_GroupSelect )
      • Else - Actions
        • Set StrafingUnit = No unit

 

[TwoVenomous]

• If - Conditions
  • (Owner of (Triggering unit)) Equal to (Owner of (Triggering unit))

this is useless since it will always be true. drop this, and just do the

• If - Conditions
  • (Number of units in GroupSelect) Equal to 1

also this wouldn't work with all the players.

if a Player 1 Red selects one unit, then this unit will be the StrafingUnit.
Once another player selects one unit, then StrafingUnit will be replaced with a new one.

In order to counter this, you need to make the StrafingUnit an array and make the index to (Player Number of (Triggering Player).

P.S (Owner of (Triggering Unit)) can be replaced by (Triggering Player)

 

[HelloFlighty]

• If - Conditions
  • (Owner of (Triggering unit)) Equal to (Owner of (Triggering unit))

this is useless since it will always be true. drop this, and just do the

• If - Conditions
  • (Number of units in GroupSelect) Equal to 1

also this wouldn't work with all the players.

if a Player 1 Red selects one unit, then this unit will be the StrafingUnit.
Once another player selects one unit, then StrafingUnit will be replaced with a new one.

In order to counter this, you need to make the StrafingUnit an array and make the index to (Player Number of (Triggering Player).

okay, thank you

EDIT:
is this correct?

• Selecting strafing unit
  • Events
    • Player - Player 1 (Red) Selects a unit
    • Player - Player 2 (Blue) Selects a unit
    • Player - Player 3 (Teal) Selects a unit
    • Player - Player 4 (Purple) Selects a unit
    • Player - Player 5 (Yellow) Selects a unit
    • Player - Player 6 (Orange) Selects a unit
    • Player - Player 7 (Green) Selects a unit
    • Player - Player 8 (Pink) Selects a unit
    • Player - Player 9 (Gray) Selects a unit
    • Player - Player 10 (Light Blue) Selects a unit
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
      • Then - Actions
        • Set GroupSelect = (Units currently selected by (Owner of (Triggering unit)))
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Number of units in GroupSelect) Equal to 1
          • Then - Actions
            • Set StrafingUnit[(Player number of (Triggering player))] = (Triggering unit)
          • Else - Actions
            • Set StrafingUnit[(Player number of (Triggering player))] = No unit
            • Custom script: call DestroyGroup( udg_GroupSelect )
      • Else - Actions
        • Set StrafingUnit[(Player number of (Triggering player))] = No unit

 

[TwoVenomous]

This should be what your trigger looks like now.

• Selecting strafing unit
  • Events
    • Player - Player 1 (Red) Selects a unit
    • Player - ... Selects a unit
    • Player - Player 10 (Light Blue) Selects a nit
  • Conditions
  • Actions
    • Set GroupSelect = (Units currently selected by (Triggering player))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in GroupSelect) Equal to 1
      • Then - Actions
        • Set StrafingUnit[(Player number of (Triggering player))] = (Triggering unit)
      • Else - Actions
        • Set StrafingUnit[(Player number of (Triggering player))] = No unit
    • Custom script: call DestroyGroup(udg_GroupSelect)

You could check if the right unit is stored in the variable and once the player selects more than one unit, the StrafingUnit will be empty. like this

• Just for debug purpose
  • Events
    • Time - Every 5.00 seconds of game time
  • Conditions
  • Actions
    • For each (Integer int) from 1 to 10, do (Actions)
      • Loop - Actions
        • Game - Display to (Player group((Player(int)))) the text: (Name of StrafingUnit[int])

 

[HelloFlighty]

This should be what your trigger looks like now.


You could check if the right unit is stored in the variable and once the player selects more than one unit, the StrafingUnit will be empty. like this

• Just for debug purpose
  • Events
    • Time - Every 5.00 seconds of game time
  • Conditions
  • Actions
    • For each (Integer int) from 1 to 10, do (Actions)
      • Loop - Actions
        • Game - Display to (Player group((Player(int)))) the text: (Name of StrafingUnit[int])

Thank you, the trigger works but oddly enough

• Just for debug purpose
  • Events
    • Time - Every 5.00 seconds of game time
  • Conditions
  • Actions
    • For each (Integer int) from 1 to 10, do (Actions)
      • Loop - Actions
        • Game - Display to (Player group((Player(int)))) the text: (Name of StrafingUnit[int])

This trigger doesn't display anything, but no matter i suppose since the first trigger works, thank you, i also have another question, in this map how do i destroy the dummy unit when it hits elevated terrain,

 

[TwoVenomous]

I added this into the loop trigger

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Terrain cliff level at point[1]) Greater than terrainLevel
  • Then - Actions
    • Unit - Add a 0.01 second Generic expiration timer to (Picked unit)
    • Unit Group - Remove (Picked unit) from dummygroup
  • Else - Actions
• Set terrainLevel = (Terrain cliff level at point[1])

 

[HelloFlighty]

I added this into the loop trigger

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Terrain cliff level at point[1]) Greater than terrainLevel
  • Then - Actions
    • Unit - Add a 0.01 second Generic expiration timer to (Picked unit)
    • Unit Group - Remove (Picked unit) from dummygroup
  • Else - Actions
• Set terrainLevel = (Terrain cliff level at point[1])

Thank you, as you could probably tell i didn't make that, fruit forest made it for me but i've asked him so many questions over the past 3 days i didn't want to annoy him hahaha

EDIT: is it possible to stop the projectile from going over raised terrain and not just cliffs?

 

[TwoVenomous]

I think terrain level only has integer value so only when it reach level 1 it will disappear.

You could probably use a missile system that is provided here in hive, but only if you intend to use it to any other spells you have (which is a lot of work to do). I'd rather leave it like that since there isn't really anything on the edge of the cliff that can be hit.

 

[HelloFlighty]

I think terrain level only has integer value so only when it reach level 1 it will disappear.

You could probably use a missile system that is provided here in hive, but only if you intend to use it to any other spells you have (which is a lot of work to do). I'd rather leave it like that since there isn't really anything on the edge of the cliff that can be hit.

yeah i may have to leave it, it's just my map is very hilly because it's a forest map :/ and my players control 1 unit in third person mode so you can see the projectiles moving up and down with the terrain and it looks a little silly, what's the missile system?

EDIT: i found the missile system, i have no knowledge of jass so i think i'll leave it alone

 

[TwoVenomous]

Try this and see if it looked better.

I changed the conditions to check if the pathability is off, if yes then remove the missile

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Terrain pathing at point[1] of type Walkability is off) Equal to True
  • Then - Actions
    • Unit Group - Remove (Picked unit) from dummygroup
    • Unit - Add a 0.01 second Generic expiration timer to (Picked unit)
    • Custom script: call RemoveLocation( udg_point[0] )
    • Custom script: call RemoveLocation( udg_point[1] )
    • Skip remaining actions
  • Else - Actions

 

[HelloFlighty]

Try this and see if it looked better.

I changed the conditions to check if the pathability is off, if yes then remove the missile

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Terrain pathing at point[1] of type Walkability is off) Equal to True
  • Then - Actions
    • Unit Group - Remove (Picked unit) from dummygroup
    • Unit - Add a 0.01 second Generic expiration timer to (Picked unit)
    • Custom script: call RemoveLocation( udg_point[0] )
    • Custom script: call RemoveLocation( udg_point[1] )
    • Skip remaining actions
  • Else - Actions

i'll do that now

EDIT: won't this trigger only remove the dummy unit if the terrain it's on isn't pathable, if so then it can still move up extreme hills, i'm just worried about this because it's a star wars map, so my units fire blaster bots instead of arrows, it looks pretty silly when you shoot at someone a few hills over and your projectile follows the ground moving up and down until it reaches it's max distance, i'm wondering why blizzard has flying units attached to the ground anyway, instead of just having them at a set height and ignoring the terrain below, allowing them to fly in a straight line

 

[TwoVenomous]

do you mean that the arrow will go as in the picture ?

if yes, then it won't go up and down to reach there, instead it will vanish as soon as it hits a cliff edge.

unless you mean the hill that you make with raise and lower tool.. then it is indeed will do that.

 

[HelloFlighty]

do you mean that the arrow will go as in the picture ?

if yes, then it won't go up and down to reach there, instead it will vanish as soon as it hits a cliff edge.

unless you mean the hill that you make with raise and lower tool.. then it is indeed will do that.

i meant a hill you make with the raise and lower tool , is there any triggers that will recognise the raised and lowered parts or is it all classed as Terrain?

 

[TwoVenomous]

i meant a hill you make with the raise and lower tool , is there any triggers that will recognise the raised and lowered parts or is it all classed as Terrain?

if a terrain is at level 1, even if you raise or lower it, it will still be at level 1. There is none that detects if a terrain is being raised or lowered.

 

[HelloFlighty]

if a terrain is at level 1, even if you raise or lower it, it will still be at level 1. There is none that detects if a terrain is being raised or lowered.

well that sucks, i'll just make all terrain flat except for terrain where trees are

 

[Athur12A2]

This one contains the flying arrow that isn't affected by terrain (more or less) and it gets destroyed when hit higher ground.
Well, I sorry Fruit and Venom for taking the liberty of fixing your edited maps. I was so lazy to create a new one at that time.

 

[HelloFlighty]

This one contains the flying arrow that isn't affected by terrain (more or less) and it gets destroyed when hit higher ground.
Well, I sorry Fruit and Venom for taking the liberty of fixing your edited maps. I was so lazy to create a new one at that time.

thanks i have another question, how do you make it so that when you press left and right, the unit strafes, so it moves left and right but still faces forward?

EDIT: btw your arrow shot map worked the first time, though when i initialized the map i got a trigger error but the map worked anyway, when i tried to initialize it again, i got a bunch of errors and map no longer runs

REEDIT: never mind, it runs again if you reload the map, but trying to run one instance of the map more than once gives errors saying there are triggers missing :?

 

[Athur12A2]

thanks i have another question, how do you make it so that when you press left and right, the unit strafes, so it moves left and right but still faces forward?

EDIT: btw your arrow shot map worked the first time, though when i initialized the map i got a trigger error but the map worked anyway, when i tried to initialize it again, i got a bunch of errors and map no longer runs

The spell I made was MUI. For similar use, you can change the angle, speed or whatever. Create event that detects arrow key and use the same actions like the arrow spell I use (angle +/-90); OR you can create 2 other spells left/right strafe with according angle +/- 90.

Btw, maps with vjass contents requires saving before any testing.

 

[HelloFlighty]

Btw, maps with vjass contents requires saving before any testing.

Thank you for the heads up

EDIT: this is the error i get when trying to save :/

 

[Athur12A2]

The map works fine with me, and I couldn't replicate your image. It seems there was something wrong with the library. Try to update your jasshelper and open again.

 

[HelloFlighty]

The map works fine with me, and I couldn't replicate your image. It seems there was something wrong with the library. Try to update your jasshelper and open again.

okay i'll do that, just wanted to ask, will this trigger work, "PLAYERREDDROID" is the variable i'm using to represent the unit each player controls throughout the game, since each player only controls one unit on the map

• Camera Check and reset
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (PLAYERREDDROID[(Player number of (Triggering player))] is being transported) Equal to True
      • Then - Actions
        • Do nothing
      • Else - Actions
        • Trigger - Turn off Tri Fighter Camera <gen>
        • Trigger - Turn off AAT Camera <gen>
        • Camera - Lock camera target for (Owner of PLAYERREDDROID[(Player number of (Triggering player))]) to PLAYERREDDROID[(Player number of (Triggering player))], offset by (0.00, 0.00) using Default rotation
        • Trigger - Turn on Default Camera <gen>

 

[Dehua_Darbuya]

I assume it would work but since the shortest periodic interval the game can run at is 0.03125 (1/32), you're better of with using 0.03 instead.

 

[HelloFlighty]

I assume it would work but since the shortest periodic interval the game can run at is 0.03125 (1/32), you're better of with using 0.03 instead.

all other triggers run perfectly with 0.01

EDIT: how do i make this trigger turn itself off once 10 players have selected 1 unit each?

• Setting players droid
  • Events
    • Player - Player 1 (Red) Selects a unit
    • Player - Player 2 (Blue) Selects a unit
    • Player - Player 3 (Teal) Selects a unit
    • Player - Player 4 (Purple) Selects a unit
    • Player - Player 5 (Yellow) Selects a unit
    • Player - Player 6 (Orange) Selects a unit
    • Player - Player 7 (Green) Selects a unit
    • Player - Player 8 (Pink) Selects a unit
    • Player - Player 9 (Gray) Selects a unit
    • Player - Player 10 (Light Blue) Selects a unit
  • Conditions
  • Actions
    • Set GroupSelect = (Units currently selected by (Triggering player))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in GroupSelect) Equal to 1
      • Then - Actions
        • Set PLAYERREDDROID[(Player number of (Triggering player))] = (Triggering unit)
      • Else - Actions
        • Set StrafingUnit[(Player number of (Triggering player))] = No unit
    • Custom script: call DestroyGroup( udg_GroupSelect )

 

[KILLCIDE]

I assume it would work but since the shortest periodic interval the game can run at is 0.03125 (1/32)

Where did you hear that from?

 

[Dehua_Darbuya]

Where did you hear that from?

Heard about it years ago here on The Hive and other WC3 modding sites. I managed to find this thread though, where Nestharus brings up how Jass can only execute code 32 times a second and explains it very well. Should definitely check it out; it's worth the read, assuming he's right! Either way, having a code run 100 times a second compared to 32 times a second is a significant difference.

Looking back, I probably could've worded my previous post better.

 

[HelloFlighty]

also this trigger seems to not work, the camera still

Heard about it years ago here on The Hive and other WC3 modding sites. I managed to find this thread though, where Nestharus brings up how Jass can only execute code 32 times a second and explains it very well. Should definitely check it out; it's worth the read, assuming he's right! Either way, having a code run 100 times a second compared to 32 times a second is a significant difference.

Looking back, I probably could've worded my previous post better.

Sounds pretty interesting, it's helpful to know these things

 

[Fruit Forest]

EDIT: this is the error i get when trying to save :/

Change
set udg_unit = your unit
set point = position of unit
set udg_real[1] = GetLocationZ(udg_point)
and then do your stuff

 

[HelloFlighty]

Change
set udg_unit = your unit
set point = position of unit
set udg_real[1] = GetLocationZ(udg_point)
and then do your stuff

Thanks