[Trigger] Does it leak? (confused)

[Erkowich]

I got these two triggers that are used in my map, and since i am experiencing some minor lagg i am wondering if this could be part of it.

• Create food
  • Events
    • Time - Every 3.00 seconds of game time
  • Conditions
  • Actions
    • Do Multiple ActionsFor each (Integer A) from 1 to 12, do (Actions)
      • Loop - Actions
        • Wait 0.20 game-time seconds
        • Set foodgroup = (Units owned by (Player((Integer A))) of type Food)
          • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • ((Player((Integer A))) Food cap) Greater than (>) 0
              • (Number of units in foodgroup) Equal to (==) 0
            • Then - Actions
              • Set foodpoint = (Center of Food place <gen>)
              • Unit - Create 1 Food for (Player((Integer A))) at foodpoint facing Default building facing (270.0) degrees
              • Set food_unit[(Integer A)] = (Last created unit)
              • Custom script: call RemoveLocation (udg_foodpoint)
            • Else - Actions
        • Custom script: call DestroyGroup (udg_foodgroup)

At least leakchecker says that Set food_unit[(Integer A)] = (Last created unit) is leaking. Should i just remake the triggers or can i keep it like this?

• Food equals 0
  • Events
    • Player - Player 1 (Red)'s Food cap becomes Equal to 0.00
    • Player - Player 2 (Blue)'s Food cap becomes Equal to 0.00
    • Player - Player 3 (Teal)'s Food cap becomes Equal to 0.00
    • Player - Player 4 (Purple)'s Food cap becomes Equal to 0.00
    • Player - Player 5 (Yellow)'s Food cap becomes Equal to 0.00
    • Player - Player 6 (Orange)'s Food cap becomes Equal to 0.00
    • Player - Player 7 (Green)'s Food cap becomes Equal to 0.00
    • Player - Player 8 (Pink)'s Food cap becomes Equal to 0.00
    • Player - Player 9 (Gray)'s Food cap becomes Equal to 0.00
    • Player - Player 10 (Light Blue)'s Food cap becomes Equal to 0.00
    • Player - Player 11 (Dark Green)'s Food cap becomes Equal to 0.00
    • Player - Player 12 (Brown)'s Food cap becomes Equal to 0.00
  • Conditions
  • Actions
    • Unit - Remove food_unit[(Player number of (Triggering player))] from the game

 

[Pharaoh_]

You have a time event that you specify for yourself, I don't see why you need a wait, especially when i) waits under 0.27 are not accurate and ii) 12x0.2 will eventually exceed the 3.00 seconds period of the trigger. Remove that wait.

Other than that, I don't see anything else wrong. What about your rest triggers?

 

[Erkowich]

I got a bunch of triggers, but that is the only periodical one. And i can't really post the rest of them, would require shit loads of space.

If you don't want to look at the map itself, which i tried to make people do before without success

 

[Pharaoh_]

Send me the map and let me know at which point it starts lagging.
Integer loops can result lag as well. :]

 

[Erkowich]

Just gotta know if you have newgen and then umswe enabled, cause else you wont be able to open it.

 

[Pharaoh_]

Hm, I can't test them anyway, I have some problems with jngp lately.

 

[Erkowich]

JNGP=Jass newgen pack i guess?
Well, then you wont be able to check it.

 

[Dr Super Good]

Unit - Remove food_unit[(Player number of (Triggering player))] from the game

Leaks. It is a blizzard bug. It fails to properly remove the unit this way.

You need to make the unit explode and then kill the unit.

 

[Erkowich]

Leaks. It is a blizzard bug. It fails to properly remove the unit this way.

You need to make the unit explode and then kill the unit.

Are you serious ?
Sounds rather odd.

 

[Dr Super Good]

Yup. Then again it is no more odd than the local handle leaks.

 

[mckill2009]

I suspect your other triggers caused the lags, anyway you're running per 3 secs and you're looping 12 times, so that means you're creating food for 0.27, maybe that caused the lag?...

and yeah you should remove the wait, instead use timers...

 

[Dr Super Good]

Unit - Create 1 Food for (Player((Integer A))) at foodpoint facing Default building facing (270.0) degrees

This opperation is demanding. Spawning units ontop of each other costs a lot of time for the displacement algorthim. It is probably better to use existing food units or to spawn them randomly throughout a rect.