Custom Script to Stop its leaking Animation on the Unit...

[Admiral Jack]

Guys how will be the custom script of this Trigger because the animation causes
leak.....
How to destroy this:

• Berserk
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Berserk (Rugbyboys Warlord)
  • Actions
    • Set Unit_Array_Special_Effect[1] = (Triggering unit)
    • Special Effect - Create a special effect attached to the origin of Unit_Array_Special_Effect[1] using Abilities\Spells\Undead\Cripple\CrippleTarget.mdl
    • Wait 15.00 seconds
    • Special Effect - Destroy (Last created special effect)
    • Custom script: call RemoveLocation ( udg_VO_Point[3] )

Thanks.....

 

[Bribe]

1) Move the "destroy effect" above the wait.
2) Why do you have "RemoveLocation"? There is no location.

 

[Adiktuz]

@Bribe - he can't do that as the effect should last for 15 seconds...

anyway, you could save the effect into a variable indexed to the unit or in a hash so that you could destroy it afterwards...

or just make the effect as the effect of the buff of that spell, if ever it uses buffs...

 

[Maker]

Throw in a little bit of JASS and it becomes easy:

• Actions
  • Custom script: local effect e
  • Set u = Triggering unit
  • Custom script: set e = AddSpecialEffectTarget("Abilities\\Spells\\Undead\\Cripple\\CrippleTarget.mdl", udg_Unit_Array_Special_Effect[1], "origin")
  • Wait 15.00 seconds
  • Custom script: call DestroyEffect(e)
  • Custom script: set e = null

 

[Dr Super Good]

Be aware that wait is inaccurate and polledwait (wait game time in GUI) leaks.

 

[Admiral Jack]

Thanks Maker!!! Your a good GUI or Jass corrector.... I hope i can give you more rep...

 

[defskull]

Using Wait by GUI action and using TriggerSleepAction(), it has same efficiency, or not ?

 

[Adiktuz]

Wait == TSA

 

[D4RK_G4ND4LF]

Using Wait by GUI action and using TriggerSleepAction(), it has same efficiency, or not ?

Wait x.xx seconds is equal to http://www.mappedia.de/wiki/Jass:TriggerSleepAction

Wait x.xx game time seconds is http://www.mappedia.de/wiki/Jass:PolledWait and therefore bad (and the reason why I always correct it every time I see it [you probably didn't notice] )

edit:
was the wrong way round
thanks to purplepoot for pointing that out

 

[Berb]

Be aware that wait is inaccurate and polledwait (wait game time in GUI) leaks.

That's right it does. They forget to null the timer variable. Funny stuff.

 

[PurplePoot]

Wait x.xx game time seconds is equal to http://www.mappedia.de/wiki/Jass:TriggerSleepAction

Wait x.xx seconds is http://www.mappedia.de/wiki/Jass:PolledWait and therefore bad (and the reason why I always correct it every time I see it [you probably didn't notice] )

No, you have it backwards. Also PolledWait is better than TSA for long waits.

 

[D4RK_G4ND4LF]

No, you have it backwards. Also PolledWait is better than TSA for long waits.

oops...you are right

 

[Justify]

That's right it does. They forget to null the timer variable. Funny stuff.

Well, they never wanted that nulling is necessary. If the reference counter would work well, what they thought that it does, nulling would be useless.