[Solved] Create Region at Unit

[EndOfWorld]

function CreateRegionAtHouse takes unit House returns region
    local location TempPoint = GetUnitLoc(House)
    local location TempPointX = Location((GetLocationX(TempPoint)-185),(GetLocationY(TempPoint)-185))
    local location TempPointY = Location((GetLocationX(TempPoint)+185),(GetLocationY(TempPoint)+185))
    local rect TempRect = RectFromLoc( TempPointX, TempPointY)
    local region TempRegion = CreateRegion()
    set TempRegion = RegionAddRect(TempRegion, TempRect)
    return TempRegion
endfunction

So I want to create a 370*370 Region at the House

My problem is: set TempRegion=RegionAddRect(TempRegion, TempRect)
Error: Cannot convert nothing to region

 

[deathismyfriend]

you do know the whole point of locals is to shorten the names and make it faster and easier right ?

Don't use locations when using jass.
do it like this.

function CreateRegionAtHouse takes unit u returns region
    local real x = GetUnitX( u)
    local real y = GetUnitY( u)
    local rect rct = Rect( x - 185, y - 185, x + 185, y + 185)
    local region r = CreateRegion()
    call RegionAddRect( r, rct)
    set rct = null
    // problem is when returning like this the local region always leaks.
    return r
endfunction

so do it like this to prevent leaks.
create a region in the trigger you call this function from.

function CreateRegionAtHouse takes unit u, region r returns region
    local real x = GetUnitX( u)
    local real y = GetUnitY( u)
    local rect rct = Rect( x - 185, y - 185, x + 185, y + 185)
    call RegionAddRect( r, rct)
    set rct = null
    // now it doesn't leak the region
    return r
endfunction

Also note that regions are created by multiples of 32. so creating a region that isn't a division of 32 can cause unwanted results.

Also this is not vJass

 

[PurgeandFire]

Just use:

call RegionAddRect(TempRegion, TempRect)

The function itself will add the rect to "TempRegion". You don't have to assign it again. Remember that variables are just pointers.

EDIT: Death posted before me.

you do know the whole point of locals is to shorten the names and make it faster and easier right ?

It is okay to have longer names. It is nice for explicitness. In the end, it is up to the user.

 

[deathismyfriend]

Just use:

call RegionAddRect(TempRegion, TempRect)

The function itself will add the rect to "TempRegion". You don't have to assign it again. Remember that variables are just pointers.

i beat you again.

 

[EndOfWorld]

Ok thanks guys,
it's working now
I am pretty new to Jass, so forgive me for these mistakes

 

[deathismyfriend]

Ok thanks guys,
it's working now
I am pretty new to Jass, so forgive me for these mistakes

It's ok everyone makes mistakes.
Look at my tutorial converting GUI to efficient jass it should be able to help you.