[JASS] Convert Ability Name to Item

[mastermike707]

I am trying to create an item at a given location based on what the name of a target of an ability was.

Here I am:

function Trig_Pack_Up_Target_Actions takes nothing returns nothing
     local MyItem = GetObjectName(GetSpellTargetUnit())
     call RemoveUnit (GetSpellTargetUnit())
     call CreateItem (MyItem, GetUnitX(GetSpellTargetUnit()), GetUnitY(GetSpellTargetUnit()))
endfunction

For example if I target the unit "Chicken" I want it to turn into the item "Chicken"

Help plz!!

 

[Hundirse]

your local variable is not anything right now, you forgot to tell it what it should be. Try this

function Trig_Pack_Up_Target_Actions takes nothing returns nothing
     local item MyItem = GetObjectName(GetSpellTargetUnit())   
     call CreateItem (MyItem, GetUnitX(GetSpellTargetUnit()), GetUnitY(GetSpellTargetUnit()))
     call RemoveUnit (GetSpellTargetUnit())
endfunction

Not sure if it makes a difference but you removed the unit, then your using it in the future code, so i just switched when it happens

 

[mastermike707]

alright, makes sense, but I still have no idea how to convert the name of the item (effectively "GetObjectName(GetSpellTargetUnit())" to its id.

 

[Hundirse]

Oops, sorry for my sloppy code didnt realize it wasnt formed correctly until i posted it. So, you want to take the name of the of the target of your spell, and create an item based on the target? Try something like this

function Trig_Pack_Up_Target_Actions takes nothing returns nothing
    local unit u = GetSpellTargetUnit()
    local integer target = GetUnitTypeId(GetSpellTargetUnit())
// IF/THEN/ELSE, make one for every different target
    if target == 'xxxx' then
    call CreateItem ('xxxx', GetUnitX(u), GetUnitY(u))
    endif
    call RemoveUnit (u)
    set u = null
endfunction

bascially gets the target of spell, and its id. If its id is something, it will do this. i cant think of anyway of making it shorter, so a bunch of ifthen statements will work

 

[Soga-]

This won't work. Items use a different naming convention than units.

 

[mastermike707]

So this is simply impossible... Is there a workaround of any form? Could I perhaps draw upon a link from the item that created the unit?

I am a JASS beginner, sorry for my lack of understanding.

 

[Hundirse]

I disagree on what soga says. Items have a 4 digit id just like units do. I is entirly possible to use a bunch of if/then/else statements (one per target) saying if the units id is this, create this item.

 

[RunBa]

you can create items named (chicken, oig, stag etc.) and
do it with GUI... not small job but not the hard one...

 

[Troll-Brain]

Or you can use the cache to link the names with the id.

 

[Soga-]

I meant Hundirse's solution wouldn't work, not that this was impossible. It is possible, you just need a bunch of if-then-else's or as Troll-Brain says, use the cache.

Though I'd go with the if-then-else's.

 

[PurplePoot]

Cache would be way faster and cleaner than if/then/else for more than a few units.

 

[mastermike707]

Cache? I have no idea what you guys are talking about , but it sounds promising. An example perhaps?

 

[Troll-Brain]

We are talking about the game cache.
You can store integers with string references.

native  StoreInteger    takes gamecache cache, string missionKey, string key, integer value returns nothing

So you need to store all the itemId at the initialisation.

missionkey == "ItemId" // or whatever
key == nameOfYourItem, or let's say nameOfYourUnit

And in your trigger use this function :

native  GetStoredInteger        takes gamecache cache, string missionKey, string key returns integer

It will return 0 if there is no integer stored.

missionkey == "IemId"
key == GetUnitName(GetSpellTargetUnit())

Don't forget to create the cache and init it.