[cnnn12] Simple Spells Pack 1.0

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

12:58, 18th Jul 2014
BPower:
Your code has location leaks.
Furthermore I recommend you check out the tutorial link I posted in comment 13
Public spell resources must have a configuration trigger instead of beeing completly hard-coded.

 

[GywGod133]

Cho'gath in LoL (League of Legends)

and please post the trigger to easy review

 

[cnnn12]

Okay edited

 

[GywGod133]

In all Trigger Loop must be use in 0.03125

Custom Script: set udg_VarReal = 0.03125
and add it in triggers

This Trigger - Turn on Trigger Loop <gen>
must be put it in ITE

 

[cnnn12]

Question: why must be 0.03125 ?

This Trigger - Turn on Trigger Loop <gen>
must be put it in ITE

you mean ?

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • ((This trigger) is on) Equal to False
  • Then - Actions
    • Trigger - Turn on (This trigger)
  • Else - Actions

 

[GywGod133]

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • ((This trigger) is on) Equal to False
  • Then - Actions
    • Trigger - Turn on (This trigger)
  • Else - Actions

Yes

why must be 0.03125 ?

you can also use 0.03 but more efficient if you use 0.03125
this 0.03125 mostly use in DURATION

 

[cnnn12]

I got it, thanks a lot

 

[GywGod133]

I forgot something......

- Add Config in every spells (Set All Ability, AoE, Damage, etc)

- In Inferno New Loop, this Set Inferno_Integers[3] = 6 inf front just remove it. In every 0.10, the udg_Inferno_Integers[3] set in 6, so why you put this Set Inferno_Integers[3] = (Inferno_Integers[3] - 1)

- In Inferno Move Loop, you have Unit Group and Point leaks. So in UnitGroup, you forgot add add set bj_wantDestroy=true or call DestroyGroup( udg_VarUG)

- In Inferno Stop N Finish, change this Set PlayerNumber_Integers[0] = (Player number of (Owner of (Casting unit))) to Set PlayerNumber_Integers[0] = (Player number of ( Triggering Player)

- In Inferno Return Animation, Inferno Equal to (Unit-type of (Dying unit)) and Animation - Change (Dying unit)'s animation speed to 300.00% of its original speed, change the Dying Unit into Triggering Unit

- In Glacial Spike, remove this Unit Group - Remove all units from GlacialSpike_SafeGroups[PlayerNumber_Integers[0]], in your loop Set GlacialSpike_Integers[0] = 6. You have Unit Group, SFX (Using Point) Point leaks

so Need Fix

 

[cnnn12]

Oops ^^
i forgot Set Inferno_Integers[3] = 6 just use in my other map (6 players)
thanks alot ^^

 

[GywGod133]

Oops ^^
i forgot Set Inferno_Integers[3] = 6 just use in my other map (6 players)
thanks alot ^^

oh... okay
just put it in other trigger cuz its not a part of your spell

 

[cnnn12]

i add call DestroyGroup( udg_VarUG) at the end of loop at first cast it work properly, but the second and then that UG isn't work anymore it does multiple damage on a unit

 

[Wrda]

Because it was destroyed, you have to create it again:

• Custom script: set udg_VaRUG = CreateGroup()

Also you have many array variables that are unnecessary, make them array ONLY if really needed.

 

[BPower]

I recommend you to get familiar with this way of indexing Dynamic Indexing

 

[Malhorne]

I think you were a bit harsh with the period.
It has been proven that 0.03 is the best period and GUI and still you can use this one, in term in perf and eye-candy.
But we prefer 0.0312500 because it is 1/32, you know you have exactly 32 frame per second.