call removelocation with playernumber?

[kingarmor1]

how i can removelocation of point variable with playernumber?

• Set Point25[(Player number of (Owner of (Picked unit)))] = ((Owner of (Picked unit)) start location)

i try with this but don't work and give error :/

• Custom script: call RemoveLocation (udg_Point25[GetPickedUnit()])

which would be correct?

 

[WaterKnight]

Transfer the location to another non-array variable and use this one in RemoveLocation. It would be futile to teach you specific jass identifiers.

 

[kingarmor1]

then work equally for all without array and a group of unit?

 

[WaterKnight]

What? You shall use the array where you need it but when you want to destroy the location, transfer it from your array to a single variable in order to simplify the notation.

 

[kingarmor1]

this works for all players in the group?
playerstartlocation variable, without array?

 

[WaterKnight]

• Set Point25[(Player number of (Owner of (Picked unit)))] = ((Owner of (Picked unit)) start location)
• //do actions
• Set tmpLocationVariable = Point25[(Player number of (Owner of (Picked unit)))]
• Custom script: call RemoveLocation (udg_tmpLocationVariable)

 

[kingarmor1]

ok thanks

 

[Greenwhy]

• Set Point25[(Player number of (Owner of (Picked unit)))] = ((Owner of (Picked unit)) start location)
• //do actions
• Set tmpLocationVariable = Point25[(Player number of (Owner of (Picked unit)))]
• Custom script: call RemoveLocation (udg_tmpLocationVariable)

I thought this will leak? It doesn't leak?

 

[Almia]

Its not GetPickedUnit(), its GetEnumUnit()



That above will leak,coz 2 location variables will share the same coordinates,creating two locations

 

[Greenwhy]

Its not GetPickedUnit(), its GetEnumUnit()



That above will leak,coz 2 location variables will share the same coordinates,creating two locations

so then this should work:

• Custom script: call RemoveLocation (udg_Point25[GetEnumUnit()])

 

[Almia]

no,units are not integers. This should do.
call RemoveLocation(udg_Point5[GetPlayerId(GetOwningPlayer(GetEnumUnit()))])

 

[Greenwhy]

for player 1 (red) the JASS PlayerID would be 0. if you have set the array values to player numbers in GUI then I think you might need to 1 to the integer returned from Almia's above function. I'm not sure though because it depends how you are assigning the point array.

 

[Almia]

No,don't increment it. Just decrement a player variable

 

[Maker]

I recommend using GetPlayerId(...) + 1 in the custom script, if otherwise one uses GUI.

 

[Almia]

^ that doesn't make any sense Maker.

If his player is 1 in GUI, then decrement it to 0 because players in JASS starts with 0.
If he increment that,he will end up with Player 2.

https://www.hiveworkshop.com/forums...807/?prev=search=aos%20multiboard&d=list&r=20

 

[Greenwhy]

It seems to me that either would work.
either
+1 increment in code to match up with GUI
ot
-1 in GUI to match up with code.

as long as it's consistent. If GUI is what you generally use and it is what you know best then I would do the former to avoid confusing yourself in early hours of the morning.

 

[Almia]

Blizzard increment player id's to one to be used in GUI.
But now,we are talking in custom scripts,so we decrement it

 

[Maker]

• Untitled Trigger 090
  • Events
    • Unit - A unit Dies
  • Conditions
  • Actions
    • Set points[(Player number of (Triggering player))] = (Position of (Triggering unit))
    • Custom script: call RemoveLocation(udg_points[GetPlayerId(GetOwningPlayer(GetTriggerUnit())) + 1])

 

[Almia]

Meh i think you are right.We are talking about arrays here.

 

[WaterKnight]

That above will leak,coz 2 location variables will share the same coordinates,creating two locations

False. Locations are objects, which is why you would destroy them in the first place. The variables are only pointers to those objects. If you set locationVarA = locationVarB, both variables will reference the same object. Player's start location is a function creating a new location.