boolean ? boolexpr ?

[gengar]

Hello,
Please help me somebody...
I don't know what's wrong there, I know that my function returns boolean, but the function GetUnitsInRectMatching requie something like boolexpr code ... ???? what is boolexpr ?
What do I have to do?

GetUnitsInRectMatching(GetPlayableMapRect(), IsAttackable(GetFilterUnit()))

my function IsAttackable looks like that:

    private function IsAttackable takes unit u returns boolean // HERE YOU CAN SET UP WHICH UNITS ARE AFFECTABLE BY KNOCK AND STUN EFFECTS
        if IsUnitEnemy(u, GetOwningPlayer(caster)) == FALSE or IsUnitType(u, UNIT_TYPE_STRUCTURE) or IsUnitType(u, UNIT_TYPE_MECHANICAL) or GetWidgetLife(u) <= 0.405 or UnitHasBuffBJ(u, 'B001') then
            return FALSE
        endif
        return TRUE
    endfunction

I want that to select all units around whole map which returns TRUE if I call IsAttackable with them as in ()..
Please tell me what to do :-(
Thanks for any help

 

[Marcelo Hossomi]

boolexpr is a "converted" boolean function. You can convert it using the Condition( function YourConditionFunction)) function.

Your IsAttackable function does not need any parameters as GetFilterUnit() will always exist in boolexpr functions (also, the function you use inside Condition(...) cannot take any parameters).

Remember that boolexpr leaks. You ought to make it a global boolexpr or destroy it after using it.

 

[Mooglefrooglian]

Boolexprs does NOT leak. It only leaks when you use the And() and Or() functions on it. They are tabled like strings.

You should use Filter(function something), not Condition.

As mentioned, your filters should take nothing and return a boolean.

Remember to efficientize your function, too. As it is, it looks like converted GUI. one big long return line could do it.

Where are you getting your "caster" variable from? Is it global? If not, your filter cant use it.

 

[Marcelo Hossomi]

Boolexprs does NOT leak. It only leaks when you use the And() and Or() functions on it. They are tabled like strings.

Really? Didn't know that. People told me to destroy boolexprs -.-'

You should use Filter(function something), not Condition.

What's the difference? I've always used Condition...

 

[YourNameHere]

What's the difference? I've always used Condition...

Condition returns a conditionfunc and Filter returns a filterfunc. Are there any more differences? :/

 

[Marcelo Hossomi]

Condition returns a conditionfunc and Filter returns a filterfunc. Are there any more differences? :/

I've always used Condition even for filters... Nothing bad has ever happened o.o'

 

[gengar]

Thanks

It looks like converted GUI

It is not.

Where are you getting your "caster" variable from? Is it global?

Yes, it is.

As mentioned, your filters should take nothing and return a boolean.

Thank you very much. I'll try your hints. I'll inform if it doesn't work.

Just to realize, what happen if I don't destroy leaks?
Thanks

 

[Dr Super Good]

Boolexprs are recycled as they are hashed so the same function will boolexpr to the same boolexpr. However, you should still destroy them if the trigger they were for (or function they were used in) will never be used again just to save some memory (why waste memory?). Luckilly you can just remove them by Conditioning the function again to get the boolexpr to remove, but even if you do not this leak is so small it does not make a difference.

 

[lelyanra]

Someone told me destroing a boolexpr is dangerous for the map. May cause a crash or something like that. Never found that out. Anyway, i always try to avoid destroying boolexpr.

and ugh... I'd try to avoid those BJ you are using over there. Try to make equivalent functions that are more efficient (although that often makes the trigger more complex). If i recall correctly, those two BJs leaks a group each. Even if you manage do destroy the groups, destroying them leaks aswell.

Edit: The BJ GetPlayableMapRect don't seem to leak but the other one...

function GetUnitsInRectMatching takes rect r, boolexpr filter returns group
    local group g = CreateGroup()
    call GroupEnumUnitsInRect(g, r, filter)
    call DestroyBoolExpr(filter)
    return g
endfunction

I THINK doing this solves it;

    call GroupEnumUnitsInRect(GroupYouWantStore, bj_mapInitialPlayableArea, Filter(IsAttackable))

no need to destroy boolexprs =)

plz let me know if I am wrong.

 

[Pharaoh_]

You revived a 4.5 month thread. This is against the rules. Problems that have not been accessed for so long have been probably solved or the author had no further interest.

 

[lelyanra]

ugh, sorry dude, forgot to check the date not going to happen again.