[JASS] Atan2 question

[Flame_Phoenix]

Hi guys, I want to use atan2, but i don't know how ... i saw the formula but i just can't use it right ... so i am using GetUnitFacing() instead, which is really bad =S

Can some1 help me out plz ?

 private function Actions takes nothing returns nothing  
        local unit att = GetAttacker()  
        local player p = GetOwningPlayer(att)
        local real angle = GetUnitFacing(att)  //I want to use Atan2 but i dunno how ... plz help !!
        
        local unit ef
        local integer counter = 0
        local real distance = 100
        
        local real x
        local real y
        local group g = CreateGroup()
        local unit dum
        local unit vic
    
        loop
            exitwhen(counter > 6)
            set x = GetUnitX(att) + distance * Cos(angle * bj_DEGTORAD)
            set y = GetUnitY(att) + distance * Sin(angle * bj_DEGTORAD)
            set ef = CreateUnit(p, EFFECTID, x, y, 0.0)
            call UnitApplyTimedLife(ef, 'BTLF', 1.0)  
        
            //now to select purge and damage enemy units
            call GroupEnumUnitsInRange(g, GetUnitX(ef), GetUnitY(ef), AOE, Filter(null))
            loop  
                set vic = FirstOfGroup(g)  
                exitwhen (vic == null)  
                if IsUnitEnemy(vic, p) then
                    set dum = CreateUnit( p, DUMID, GetUnitX(ef), GetUnitY(ef), 0)  
                    call UnitApplyTimedLife(dum, 'BTLF', 2.5)  
                    call UnitAddAbility(dum, SPELLID)
                    call SetUnitAbilityLevel(dum, SPELLID, GetUnitAbilityLevel(att, BOOKID))
                    call IssueTargetOrder(dum, SPELLORDER, vic)    
                    call SetUnitState(vic, UNIT_STATE_LIFE, GetWidgetLife(vic) - (25 * GetUnitAbilityLevel(GetAttacker(), BOOKID)))   
                endif  
                call GroupRemoveUnit(g, vic)
            endloop
        
            set distance = distance + 100
            set counter = counter + 1
        endloop
    
        call DestroyGroup(g)
        set att = null  
        set ef = null
        set dum = null
        set g = null
        set p = null
    endfunction

EDIT EDIT EDIT

I managed to do something, but it is a little buggy =S Sometimes i create two lines of "eff" when i should only create one

 local real angle = (180.0 / 3.14159) * Atan2(GetUnitY(GetTriggerUnit()) - GetUnitY(att), GetUnitX(GetTriggerUnit()) - GetUnitX(att))

Can any1 help me ? =S

 

[spiwn]

You know, Atan and Atan2 return rads(no idea how the whole word is in english).
So either use Atan2BJ

function AtanBJ takes real degrees returns real
    return Atan(degrees) * bj_RADTODEG
endfunction

or Multiply by bj_RADTODEG

 

[Ciebron]

do u wanna get angle between 2 points? then u do like this Atan2(y-y2,x-x2)*57.27589

also dont use bj_RADTODEG its constant real bj_DEGTORAD=bj_PI/180.0 faster to do 3.14159/180 instead

 

[PurplePoot]

You know, Atan and Atan2 return rads(no idea how the whole word is in english).

That's why he multiplies between 180/pi

And they're Radians.

Also, why are you all so insistent on degrees?

So either use Atan2BJ

Erm... no >>

do u wanna get angle between 2 points? then u do like this Atan2(y-y2,x-x2)*57.27589

You actually have it exactly backwards.

The angle between two x/y with Atan2 from x,y to x2,y2 is Atan2(y2-y,x2-x).

 

[Ciebron]

ye did it fast just to show that, not so much light on it

 

[Captain Griffen]

do u wanna get angle between 2 points? then u do like this Atan2(y-y2,x-x2)*57.27589

also dont use bj_RADTODEG its constant real bj_DEGTORAD=bj_PI/180.0 faster to do 3.14159/180 instead

It's faster I'm betting to do *bJ_DEGTORAD than adding an extra division in there. *57.3... whatever would be faster, but harder to read and type, and bj_DEGTORAD is inlined anyway by Vex's optimizer, so no speed difference in release versions.

Hence, use *bj_DEGTORAD.

 

[Flame_Phoenix]

 local real angle = bj_DEGTORAD * Atan2(GetUnitY(GetTriggerUnit()) - GetUnitY(att), GetUnitX(GetTriggerUnit()) - GetUnitX(att))

Ok so i now have this ... but what about my problem ? can any1 help me :S

 

[PurplePoot]

Atan2 returns radians...

 

[Captain Griffen]

IE: bj_RADTODEG.

 

[PurplePoot]

Or just don't convert at all.

But definitely don't convert radians to radians as if they're degrees; bad things happen.

 

[Flame_Phoenix]

SOoooo, what do i do after all ??? convert, no convert !? I won't use GetUnitFacing, that is bad ... =S

 

[Captain Griffen]

GetUnitFacing is degrees. Atan2 gives radians.

Convert depending on what you have and what you need.

 

[spiwn]

That was not and still is not his problem
I wonder what did you mean by:
"Sometimes i create two lines of "eff" when i should only create one"

 

[Flame_Phoenix]

spwin is (as usually) rit ...
If you look at code, you will see i intent to create a line. I create a unit "eff" and 100 ahead another and so on...

Problem is that sometimes i create 2 lines, which means that my first iteration creates 2 units instead of 1 ... and i dunno why :S

I can post map :S

 

[spiwn]

You are person number n who misspells my nick
Now I get why no one understood - your unit is ef and you say eff
Interesting.
Post whole trigger, at least.
P.s. and in your first post you say you create 2 lines of units , not 2 units at one spot.

 

[Flame_Phoenix]

You are person number n who misspells my nick

Sry about that :S

Post whole trigger, at least.
P.s. and in your first post you say you create 2 lines of units , not 2 units at one spot.

Yes. Because i initially create two units, the trigger seems to be activated for each of them, thus creating two lines :S
I don't think the other functions (Init, and Conditions) are important but i can post them if you need.

 

[spiwn]

Well, probably not
Will sleep on it(most probably not)
Will get down to it when I get up early in the morning(absolutely not, maybe later)