[Trigger] Another hocus pocus not working

[jot0017]

Hi ppl , I know Im maybe bothering you too much but i'm taking big steps with this map im doping and im trying to introduce some new cooler than before spells.
Well, basically what the spell is about is that the ice giant sacrifices 10% of his current life to summon a block of ice wich deals a quantity based in the amount sacrificed , the damage is per second. It's not really not working, but the issue here is that by the 5th or 7th time casting it creates a devirginizer LAG, anyways here it is

Hocus Pocus Init Sudden Winter Events Unit - Ice Giant 0019 <gen> Starts the effect of an ability Conditions (Ability being cast) Equal to Sudden Winter Actions Set SW_Real = ((Life of Ice Giant 0019 <gen>) / 10.00) Set SW_Damage[1] = (SW_Real x 0.50) Set SW_Damage[2] = SW_Real Set SW_Damage[3] = (SW_Real x 1.50) Set SW_Damage[4] = (SW_Real x 2.00) Set SW_Damage[5] = (SW_Real x 3.00) If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Integer((Percentage life of Ice Giant 0019 <gen>))) Less than or equal to 5 Then - Actions Set SuddenWinter = Sudden Winter Set SuddenWinter_Level = (Level of SuddenWinter for Ice Giant 0019 <gen>) Unit - Remove SuddenWinter from Ice Giant 0019 <gen> Unit - Add SuddenWinter to Ice Giant 0019 <gen> Unit - Set level of SuddenWinter for Ice Giant 0019 <gen> to SuddenWinter_Level Game - Display to (All players matching ((Matching player) Equal to (Triggering player))) for 4.00 seconds the text: |c00FFFF00The hero ... Else - Actions Unit - Create 1 Dummy Unit (Sudden Winter) for (Triggering player) at (Target point of ability being cast) facing Default building facing degrees Set SW_Dummy = (Last created unit) Countdown Timer - Start SW_Timer to expire in 0.55 seconds, as a One-shot timer, performing (Animation - Change SW_Dummy's animation speed to 0.00% of its original speed) upon expiration. Unit - Cause SW_Dummy to damage Ice Giant 0019 <gen>, dealing SW_Real damage of attack type Chaos and damage type Universal Unit - Add Inmolación permanente (Sudden Winter) to SW_Dummy Unit - Set level of Inmolación permanente (Sudden Winter) for SW_Dummy to (Level of Sudden Winter for Ice Giant 0019 <gen>) Unit - Add a 14.00 second Generic expiration timer to SW_Dummy Set SW_Point = (Position of SW_Dummy) Trigger - Turn on Sudden Winter Check <gen> Trigger - Turn on Sudden Winter Damage Alt <gen>

Hocus Pocus Checking Sudden Winter Check Events Time - Every 0.05 seconds of game time Conditions Actions If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (SW_Dummy is alive) Equal to False Then - Actions Custom script: call RemoveLocation (udg_SW_Point) Custom script: call RemoveRect(udg_SW_Rect) Trigger - Turn off (This trigger) Trigger - Turn off Sudden Winter Damage Alt <gen> Environment - Turn (Last created weather effect) Off Else - Actions Set SW_Rect = (Region centered at SW_Point with size (350.00, 350.00)) Environment - Create at SW_Rect the weather effect Northrend Snow (Heavy) Environment - Turn (Last created weather effect) On

Hocus Pocus Damage Sudden Winter Damage Alt Events Time - Every 1.00 seconds of game time Conditions Actions Custom script: set bj_wantDestroyGroup = true Unit Group - Pick every unit in (Units within 450.00 of (Position of SW_Dummy) matching ((((Matching unit) belongs to an enemy of (Owner of Ice Giant 0019 <gen>)) Equal to True) and ((((Matching unit) is A structure) Equal to False) and (((Matching unit) is dead) Equal to False)))) and do (Actions) Loop - Actions Unit - Cause SW_Dummy to damage (Picked unit), dealing SW_Damage[(Level of Sudden Winter for Ice Giant 0019 <gen>)] damage of attack type Spells and damage type Normal

EDIT: Lol okay, I thought that could make it more readable actually, there you go D

 

[Chaosy]

can you post it without all those comments? it ruins the readability completely.

edit: either way,

Leak:

• Unit - Create 1 Dummy Unit (Sudden Winter) for (Triggering player) at (Target point of ability being cast) facing Default building facing degrees

Also store the giant into a variable in the cast trigger. Then use that variable instead of manually clicking on the unit 5 times.

 

[jot0017]

Thanks! buuut, Does setting the giant to a variable does improves something? or your advice is just for be more practical?

 

[Chaosy]

Using a variable is slightly faster than using a raw value.

It might not do any wonders, but it should help.

 

[jot0017]

Now that I thnik about it, that timer might be leaking aswell, but the we haven't find yet what makes the DEVIRGINIZER LAG :CC

 

[Chaosy]

To be honest, I have never, ever, used that action. But yeah, it is likely leaking since it's never destroyed. But unless you got really crappy RAM (google it if you don't know what it is) you shouldn't be affected by so few leaks.

 

[jot0017]

okay, thanks aaaand
Bump

 

[Dr Super Good]

Units within 450.00 of (Position of SW_Dummy) matching

Leaks a location.

"Position of SW_Dummy" generates a location which you never remove.

There might be more but that raised alarm bells immediately.

Edit:
Another location leak...

Unit - Create 1 Dummy Unit (Sudden Winter) for (Triggering player) at (Target point of ability being cast) facing Default building facing degrees

"Target point of ability being cast" generates a location which you never remove.

You also leak a lot of environment weather effect (probably source of poor performance). Turning something off is not the same as destroying it. You either need to recycle (use again later) it or destroy it.

 

[jot0017]

Great! thats why i praise you doc
How could I recycle that weather effect?

 

[Dr Super Good]

Not sure if you can for this case since there appears to be no natives to move weather. You can however destroy it using this native...

native RemoveWeatherEffect takes weathereffect whichEffect returns nothing

Which should have a GUI action wrapper which calls this...

function RemoveWeatherEffectBJ takes weathereffect whichWeatherEffect returns nothing
    call RemoveWeatherEffect(whichWeatherEffect)
endfunction

Use the action on the weather effect and it will be removed.

 

[jot0017]

So, Additional question, by destroying the weather effect (by storing it in a variable i guess) it turns it automatically off?

 

[Dr Super Good]

it turns it automatically off?

Seeing how it should not exist anymore there is no way it should be able to be "on".

Art might take a while to disappear (smooth transition).