Annoying part of a trigger that refuses to work

[terranempire]

So, this is a part of a trigger that refuses to work, and I can't figure out why.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • And - All (Conditions) are true
      • Conditions
        • (Charges remaining in (Item carried by (Picked unit) of type ITEM)) Less than 10
        • (Owner of (Picked unit)) Not equal to Neutral Passive
        • (Owner of (Picked unit)) Not equal to Neutral Hostile
  • Then - Actions
    • Set OtherPoint = (Position of (Picked unit))
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units within 200.00 of OtherPoint) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • (Unit-type of (Picked unit)) Equal to Something Centre
                • (Unit-type of (Picked unit)) Equal to Something
                • (Unit-type of (Picked unit)) Equal to Something
                • (Unit-type of (Picked unit)) Equal to Something
                • (Unit-type of (Picked unit)) Equal to Something
                • (Unit-type of (Picked unit)) Equal to Something Battleship
                • (Unit-type of (Picked unit)) Equal to Something
                • (Unit-type of (Picked unit)) Equal to Something
          • Then - Actions
          • Else - Actions
            • Item - Set charges remaining in (Item carried by (Picked unit) of type ITEM) to ((Charges remaining in (Item carried by (Picked unit) of type ITEM)) + 1)
    • Custom script: call RemoveLocation(udg_OtherPoint)
  • Else - Actions

It's the second part that doesn't work, it's supposed to check if this or that unit is nearby and then, if they are, it does nothing but if not then it proceeds as usual.

Oh and I have like 7 different copies of this same trigger (and another one that is about this large (EDIT: MUCH larger)) and it's causing loads of lag, is there anyway to optimise it?

BTW, I've tried doing the conditions as not equal to and the Then action as the set charges, but it didn't work either.

 

[Pharaoh_]

Do it like this:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • And - All (Conditions) are true
      • Conditions
      • (Charges remaining in (Item carried by (Picked unit) of type ITEM)) Less than 10
      • (Owner of (Picked unit)) Not equal to Neutral Passive
      • (Owner of (Picked unit)) Not equal to Neutral Hostile
  • Then - Actions
    • Set Unit1 = (Picked unit)
    • Set OtherPoint = (Position of (Unit1))
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units within 200.00 of OtherPoint) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • (Unit-type of (Picked unit)) Not Equal to Something Centre
                • (Unit-type of (Picked unit)) Not Equal to Something
                • (Unit-type of (Picked unit)) Not Equal to Something
                • (Unit-type of (Picked unit)) Not Equal to Something
                • (Unit-type of (Picked unit)) Not Equal to Something
                • (Unit-type of (Picked unit)) Not Equal to Something Battleship
                • (Unit-type of (Picked unit)) Not Equal to Something
                • (Unit-type of (Picked unit)) Not Equal to Something
          • Then - Actions
            • Item - Set charges remaining in (Item carried by (Picked unit) of type ITEM) to ((Charges remaining in (Item carried by (Picked unit) of type ITEM)) + 1)
          • Else - Actions
    • Custom script: call RemoveLocation(udg_OtherPoint)
  • Else - Actions

Changes made:

• The comparisons for the Unit-type are set to Not Equal
• Used a unit variable for the "Picked" unit [called Unit1], because, since you involve another unit group pick afterwards, the "Picked unit" will not refer to the unit you initially picked.

 

[terranempire]

Uhm, didn't work, instead, it made it add 2 charges instead of 1. And the part for preventing charges still doesn't work.

 

[Pharaoh_]

Sorry, I forgot to change the line:

• Item - Set charges remaining in (Item carried by (Unit1) of type ITEM) to ((Charges remaining in (Item carried by (Unit1) of type ITEM)) + 1)

 

[terranempire]

Sorry, I forgot to change the line:

• Item - Set charges remaining in (Item carried by (Unit1) of type ITEM) to ((Charges remaining in (Item carried by (Unit1) of type ITEM)) + 1)

Eh, I had already added that.

 

[Bond009]

would it be better to pick all units and do the if then's inside it.. that way you have the units you want to reference.. also instead of using Custom script: set bj_wantDestroyGroup = true
Assign it to a temp group and then remove it that way the trigger can work over and over again.

If thats your whole trigger why are you addressing picked units before you even pick a unit? It shouldnt know what the picked unit even is yet at that point in the trigger.

 

[terranempire]

Well, it still adds 2 instead of 1, why is this?
And the part that should stop it from adding doesn't work.