Am I doing this codeless loading wrong?

[LazZ]

I've been trying to solve the desyncs in my map for almost a month now. I've looked through every trigger and script and I can't find anything suspect but my save/load system and I'm wondering if I'm doing things wrong. I got inspired by TriggerHappy's Codeless save/load system and since I'm writing in Lua I can't import his library (JASS) into my map, so I decided to just look at the code, try to understand it and make my own.

function InitLoad()
    local trig = CreateTrigger()
    TriggerAddAction(trig, SyncData)
    for i = 0, bj_MAX_PLAYER_SLOTS do
        BlzTriggerRegisterPlayerSyncEvent(trig, Player(i), "LoadData", false)
    end

    -- Load all player saves
    ForForce(GetPlayersAll(), LoadStrings)
end

function LoadStrings()
    local player = GetConvertedPlayerId(GetEnumPlayer())
    -- increase when more character slots are created
    for i = 1, 3 do
        if (player < 24) then
            local data = ""
            Preloader("\\AzerothRPG\\Hero" .. i .. ".txt")
            data = BlzGetAbilityTooltip(1097690227, 0)
            BlzSetAbilityTooltip(1097690227, originalTooltip, 0) -- Reset tooltip
            if (GetLocalPlayer() == GetEnumPlayer()) then
                BlzSendSyncData("LoadData", data)
            end
        end
    end
end

function SyncData()
    local player = GetConvertedPlayerId(GetTriggerPlayer())

    if (characterNext[player] == nil) then
        characterNext[player] = 1
    else
        characterNext[player] = characterNext[player] + 1
    end

    characterLoadStrings[player][characterNext[player]] = BlzGetTriggerSyncData()

    LoadCharacterForPlayer(player, characterNext[player])
end

For context, the preloader loads a file that injects code that changes an ability tooltip for the players (locally) but sends the data for the current player in the loop to a synced event so everyone is in sync... is the idea at least. It works, except I think it's causing a desync and I'm sort of blaming the fact that I'm doing this inside a loop, but I'm just not sure.

 

[Planetary]

I've been going through the Codeless system to get a better grasp of it. Based on my understanding, looks pretty congruent with the ordering of things.

    Preloader("\\AzerothRPG\\Hero" .. i .. ".txt")
    data = BlzGetAbilityTooltip(1097690227, 0)
    BlzSetAbilityTooltip(1097690227, originalTooltip, 0) -- Reset tooltip
    if (GetLocalPlayer() == GetEnumPlayer()) then
        BlzSendSyncData("LoadData", data)
    end

I'm wondering if this needs to be altered.

From the Codeless system, any client updates seem to be limited to after BlzGetTriggerSyncData() using the data fetched i.e. the tooltip changes might need to pushed into LoadCharacterForPlayer after being read from characterLoadStrings. I also wonder if empty strings do weird things for sync updates. Maybe want to also add a check for empty strings before calling BlzSendSyncData for that player.

I'd also suspect a loop might cause issues if there's a data sync timeout since all of the calls are happening together with mixed player ping, but not an expert here. edit2: what I said here doesn't hold true as the engine utilizes networking where ping is always a problem; maybe that's different for manual sync natives.

edit: nevermind this previous comment, I don't think tooltips would be effected

 

[TriggerHappy]

It looks fine to me. How do you know your desync is related to this code?

 

[LazZ]

I don't, I just can't find anything else that causes it, but if this is fine I guess I have to keep looking.

 

[Planetary]

Did you do the Linksys Customer Support trick of turning it off and back on again to check if it fixes desync?

Not off and back on literally, but turn off and see if that solves it

 

[LazZ]

Linksys Customer Support

lul

Sry, didn't follow up on this, but I think I know what causes the desyncs now. I'm using Bribe's Damage Engine and his engine uses 'GetHandleId' to register and store attack types and stuff, and since Lua by nature generates different handles per client, the handles the Damage Engine uses will be different on each client and desync the game. I haven't tested it, but that's most likely the cause.