[Trigger] Adding abilities to group issue

[Peacehagen]

What the triggers are supposed to do is add some random passives to a group of units that spawn at the beginning of the map. However, only the first group recieves their random abilities, the next group gets none. I will post all the triggers below. Would be very grateful if anyone could find the problem.

--- SPAWNING TRIGGERS ---

• Spawn Elites 1 DF
  • Events
    • Time - Elapsed game time is 5.00 seconds
  • Conditions
  • Actions
    • -------- The Dark Forest --------
    • Set Integer_Randomizer = (Random integer number between 1 and 2)
    • Set Unit_EliteSpawn = Unit_EliteType[Integer_Randomizer]
    • Set Integer_Randomizer = (Random integer number between 1 and 6)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Integer_Randomizer Equal to Integer_NoSpawn
      • Then - Actions
        • Trigger - Run Spawn Elites 1 DF <gen> (checking conditions)
      • Else - Actions
        • Set Integer_NoSpawn = Integer_Randomizer
        • For each (Integer A) from 1 to 3, do (Actions)
          • Loop - Actions
            • Unit - Create 1 Unit_EliteSpawn for Player 1 (Red) at Point_DFEliteSpawn[Integer_Randomizer] facing Default building facing degrees
            • Unit Group - Add (Last created unit) to UnitGroup_Elite[1]
        • Set Integer_EliteGroup = 1
        • Trigger - Run Set Affix 1 <gen> (checking conditions)

• Spawn Elites 2 DF
  • Events
    • Time - Elapsed game time is 10.00 seconds
  • Conditions
  • Actions
    • -------- The Dark Forest --------
    • Set Integer_Randomizer = (Random integer number between 1 and 2)
    • Set Unit_EliteSpawn = Unit_EliteType[Integer_Randomizer]
    • Set Integer_Randomizer = (Random integer number between 1 and 6)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Integer_Randomizer Equal to Integer_NoSpawn
      • Then - Actions
        • Trigger - Run Spawn Elites 2 DF <gen> (checking conditions)
      • Else - Actions
        • Set Integer_NoSpawn = 0
        • For each (Integer A) from 1 to 3, do (Actions)
          • Loop - Actions
            • Unit - Create 1 Unit_EliteSpawn for Player 1 (Red) at Point_DFEliteSpawn[Integer_Randomizer] facing Default building facing degrees
            • Unit Group - Add (Last created unit) to UnitGroup_Elite[2]
        • Set Integer_EliteGroup = 2
        • Trigger - Run Set Affix 1 <gen> (checking conditions)

--- ABILITY TRIGGERS ---

• Set Affix 1
  • Events
  • Conditions
  • Actions
    • Set Integer_Randomizer = (Random integer number between 1 and 8)
    • Set Ability_EliteAffix2[1] = Ability_EliteAffix[Integer_Randomizer]
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Ability_EliteAffix2[1] Equal to War Stomp (Neutral Hostile 1)
      • Then - Actions
        • Trigger - Run (This trigger) (checking conditions)
      • Else - Actions
        • Set Ability_EliteAffix[Integer_Randomizer] = War Stomp (Neutral Hostile 1)
        • Unit Group - Pick every unit in UnitGroup_Elite[Integer_EliteGroup] and do (Actions)
          • Loop - Actions
            • Unit - Add Ability_EliteAffix2[Integer_Randomizer] to (Picked unit)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • Difficulty_Nightmare Equal to True
                • Difficulty_Hell Equal to True
                • Difficulty_Inferno Equal to True
          • Then - Actions
            • Trigger - Run Set Affix 2 <gen> (checking conditions)
          • Else - Actions
            • Trigger - Run Reset Affixes <gen> (checking conditions)

• Set Affix 2
  • Events
  • Conditions
  • Actions
    • Set Integer_Randomizer = (Random integer number between 1 and 8)
    • Set Ability_EliteAffix2[2] = Ability_EliteAffix[Integer_Randomizer]
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Ability_EliteAffix2[2] Equal to War Stomp (Neutral Hostile 1)
      • Then - Actions
        • Trigger - Run (This trigger) (checking conditions)
      • Else - Actions
        • Set Ability_EliteAffix[Integer_Randomizer] = War Stomp (Neutral Hostile 1)
        • Unit Group - Pick every unit in UnitGroup_Elite[Integer_EliteGroup] and do (Actions)
          • Loop - Actions
            • Unit - Add Ability_EliteAffix2[2] to (Picked unit)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • Difficulty_Hell Equal to True
                • Difficulty_Inferno Equal to True
          • Then - Actions
            • Trigger - Run Set Affix 3 <gen> (checking conditions)
          • Else - Actions
            • Trigger - Run Reset Affixes <gen> (checking conditions)

• Set Affix 3
  • Events
  • Conditions
  • Actions
    • Set Integer_Randomizer = (Random integer number between 1 and 8)
    • Set Ability_EliteAffix2[3] = Ability_EliteAffix[Integer_Randomizer]
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Ability_EliteAffix2[3] Equal to War Stomp (Neutral Hostile 1)
      • Then - Actions
        • Trigger - Run (This trigger) (checking conditions)
      • Else - Actions
        • Set Ability_EliteAffix[Integer_Randomizer] = War Stomp (Neutral Hostile 1)
        • Unit Group - Pick every unit in UnitGroup_Elite[Integer_EliteGroup] and do (Actions)
          • Loop - Actions
            • Unit - Add Ability_EliteAffix2[3] to (Picked unit)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • Difficulty_Inferno Equal to True
          • Then - Actions
            • Trigger - Run Set Affix 4 <gen> (checking conditions)
          • Else - Actions
            • Trigger - Run Reset Affixes <gen> (checking conditions)

• Set Affix 4
  • Events
  • Conditions
  • Actions
    • Set Integer_Randomizer = (Random integer number between 1 and 8)
    • Set Ability_EliteAffix2[4] = Ability_EliteAffix[Integer_Randomizer]
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Ability_EliteAffix2[4] Equal to War Stomp (Neutral Hostile 1)
      • Then - Actions
        • Trigger - Run (This trigger) (checking conditions)
      • Else - Actions
        • Unit Group - Pick every unit in UnitGroup_Elite[Integer_EliteGroup] and do (Actions)
          • Loop - Actions
            • Unit - Add Ability_EliteAffix2[4] to (Picked unit)
        • Trigger - Run Reset Affixes <gen> (checking conditions)

• Reset Affixes
  • Events
  • Conditions
  • Actions
    • Set Ability_EliteAffix[1] = Deflect [Elite Affix]
    • Set Ability_EliteAffix[2] = Fast [Elite Affix]
    • Set Ability_EliteAffix[3] = Fiery Soul [Elite Affix]
    • Set Ability_EliteAffix[4] = Might [Elite Affix]
    • Set Ability_EliteAffix[5] = Reflect [Elite Affix]
    • Set Ability_EliteAffix[6] = Stoneskin [Elite Affix]
    • Set Ability_EliteAffix[7] = Vampiric [Elite Affix]
    • Set Ability_EliteAffix[8] = Frozen Soul [Elite Affix]

Thanks for any help on this, +rep ofc.

 

[deathismyfriend]

u should not do this.
make sure u check the random number thing in wc3 otherwise it will make the same numbers appear all the time.
Also dont use integer A.
if u still havea problem try debugging it to see what line ur trigger stops at. if u dont know how to debug check out the chapter in my tutorial about debugging.https://www.hiveworkshop.com/forums/tutorial-submission-283/things-gui-user-should-know-233242/

 

[Peacehagen]

How do I check the random number?
I replaced Integer A with my own variable, didnt solve the problem.
Made a debugg check and everything runs as it should. So there must be some problem with identifying the group or something?

 

[Maker]

Unit groups are created automatically only for indexes 0 and 1 at map initialization. Increase the default size of the unit group array to create more groups or use

Custom script : set udg_groupName[indexNumber] = CreateGroup()

 

[Peacehagen]

That solved it! Thanks alot!
Do you perhaps know how to make it more random? Since it seems random number between x and y always gives the same numbers :/

 

[Xerxes]

How would it give you the same numbers if it's random? Maybe you mean the same pattern?

Did you do this:

• Set Integer = Random Number between 1 and 100

?

 

[Maker]

Untick "use fixed random seed" in file -> preferences.

 

[Xerxes]

Untick "use fixed random seed" in file -> preferences.

Oh yeah I forgot to ask you Maker what does that do?

 

[Peacehagen]

I cant find that option there Maker, is it perhaps in NewGen only?

 

[Xerxes]

I cant find that option there Maker, is it perhaps in NewGen only?

Go To File > Preferences > Test Map tab > there toggle the box.

It's in any kind of World Editor.

 

[deathismyfriend]

it does what it says lol.
if its ticked its a fixed random seed. ( not random)
unticked is random numbers again.